Removing old code

by **Fnoed** » 06 Feb 2011, 18:42

I noticed when upgrading the Quest data structure that there is an even older version lying around at the default package level. Can we remove that so that future maintenance becomes easier?

I also want to remove the old Quest UI as soon as possible as back-porting quest core changes becomes more and more difficult as the UIs diverge. Can I do it now or wait until the new one is a bit more stable.

Finally, I noticed that we still have references to the old game UI. With all the work going into the new one I don't see a reason to keep the old one around; as far as I know the new one is at parity with the old one, feature-wise.

What do you guys think?

TL;DR: Hulk wanna smash old code.

by **Hellfish** » 06 Feb 2011, 18:52

I'm all for removing old code but I think some people are having issues with the new in-game UI to the point of unplayability.The old quest UI and the old old quest data structure I see no problem with nuking, however.

by **Chris H.** » 06 Feb 2011, 19:22

Rares did the original quest mode. Dennis added some new features which resulted in the newer fantasy quest mode. The older version of the Quest data structure is probably from Rares first version.

Once you feel that the new quest GUI is stable we can get rid of the old one.

We should keep both the old and new battlefield GUIs for the time being. Hellfish makes a good point about some people having issues with the new GUI battlefield making the game unplayable.