It is currently 12 Sep 2025, 14:59
   
Text Size

r10057 has broken the build (

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

r10057 has broken the build (

Postby Max mtg » 29 Aug 2011, 18:03

Unfortunatelly, Braids has not commited the moved classes

http://svn.slightlymagic.net/websvn/lis ... &rev=10057
Code: Select all
- Splash view/model renamed, moved to forge.view.swing folder
- Small fix to decouple interface from implementation
- Add dispatch thread test
- Updated javadoc
So I guess, until Braids commits the missing files, for that time being we should restore the old version from SVN to make the build working again
    /trunk/src/main/java/net/slightlymagic/braids/util/progress_monitor/SplashModelProgressMonitor.java
    /trunk/src/main/java/net/slightlymagic/braids/util/progress_monitor/SplashViewProgressMonitor.java
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: r10057 has broken the build (

Postby jendave » 29 Aug 2011, 18:53

Fixed
jendave
 
Posts: 307
Joined: 01 Jun 2008, 07:19
Has thanked: 8 times
Been thanked: 21 times

Re: r10057 has broken the build (

Postby Sloth » 29 Aug 2011, 19:24

jendave wrote:Fixed
There's still something messed up.

EDIT: I think I fixed.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: r10057 has broken the build (

Postby Max mtg » 29 Aug 2011, 19:45

jandave, sloth, thanks a lot!
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: r10057 has broken the build (

Postby Doublestrike » 30 Aug 2011, 16:19

Just finally found and read this post (ouch).

General apologies all around. :oops:

Could someone tell me why this happened (or how to prevent)? To my understanding (which generally follows the explanation at viewtopic.php?f=52&t=1093&start=105#p68947) I get things working on my machine, update to the head, then commit. When anyone opens up their dev environment, they update to the latest revision, and off they go. I must be missing something...?
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Re: r10057 has broken the build (

Postby Sloth » 30 Aug 2011, 16:57

Doublestrike wrote:Just finally found and read this post (ouch).

General apologies all around. :oops:

Could someone tell me why this happened (or how to prevent)? To my understanding (which generally follows the explanation at viewtopic.php?f=52&t=1093&start=105#p68947) I get things working on my machine, update to the head, then commit. When anyone opens up their dev environment, they update to the latest revision, and off they go. I must be missing something...?
I think you forgot to submit new (or newly named) classes in commit 10057. This happened to me all the time. The program I use (TortoiseSVN) won't check unversioned files by default only chnaged ones.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 26 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 26 users online :: 0 registered, 0 hidden and 26 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 26 guests

Login Form