It is currently 12 Sep 2025, 17:17
   
Text Size

Issue 157: which classes do we need?

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Issue 157: which classes do we need?

Postby jendave » 29 Aug 2011, 16:20

Rob Cashwalker wrote:FYI, the SlightlyMagic SVN is going quite fast. I recall with GoogleCode, updating all 5000+ cards took an hour due to the stream crapping out every few hundred cards. It just did 8829 updates in about 6 minutes.
I agree. While Git was faster, the slightlymagic SVN speed is vastly better than Google's
jendave
 
Posts: 307
Joined: 01 Jun 2008, 07:19
Has thanked: 8 times
Been thanked: 21 times

Re: Issue 157: which classes do we need?

Postby Braids » 29 Aug 2011, 16:44

Max mtg wrote:
Braids wrote:i'm doing ok with svn. i'm having to do the update one letter folder at a time from the command line. i am very glad i was able to split the cardsfolder up alphabetically several weeks ago.

@Max mtg, i've added two boolean fields to CardRules: removedFromAIDecks and removedFromRandomDecks. i added them to the ctor and added two 'is' accessors for them. these values are important for being able to generate random decks for both the player and the AI, and also for AI drafting.
I strongly support the decision of splitting the cardsfolder - now the directories open faster and the needed card is faster to located. Despite of the update of all over 9000 files took me about a minute

You've done it right. These fields are definitelly necesary once we switch completely to generators based on lighweight classes.
well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Issue 157: which classes do we need?

Postby Max mtg » 29 Aug 2011, 17:49

Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
But why? What happened to you? Is that about javadocs?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Issue 157: which classes do we need?

Postby Sloth » 29 Aug 2011, 18:37

Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
I hope you will be back. A lot of important topics that haven't been touched for years have been discussed very lively because of you. [-o<
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Issue 157: which classes do we need?

Postby slowe » 29 Aug 2011, 22:40

Sloth wrote:
Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
I hope you will be back. A lot of important topics that haven't been touched for years have been discussed very lively because of you. [-o<
Take care, Braids. I may not post often, but I lurk about, and I hate to see someone so involved in Forge's progress leave. Hope you feel refreshed soon; we'll always be glad to see you back!
slowe
 
Posts: 127
Joined: 05 Jan 2010, 14:04
Has thanked: 6 times
Been thanked: 10 times

Re: Issue 157: which classes do we need?

Postby Max mtg » 30 Aug 2011, 23:09

CardReader is complete. Thanks to Braids, who has made a first and very important step in its development.
Feel free to use CardDb class - from now it contains all cards printed, among those, known by Forge of course. Mtg-data.txt is no longer unsed (but keep parsers' sources please, they might become useful)

Decks, DeckEdtitors (incl cardshop and boosterdraft), the drafting itself and QuestModel updates will follow in some time.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Previous

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 49 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 49 users online :: 0 registered, 0 hidden and 49 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 49 guests

Login Form