The 'edit' file in root directory => Quest decks editor

[Max mtg]

There's a feature well hidden in Forge - if you start with file named 'edit' in ur directory, the deck editor for quest mode obtains a new submenu... it's purpose it not very clear to me, because AI decks are now stored in forge\res\quest\decks\ and can be edited via standard deck editor, so I guess it is not needed there and should be removed.

Is there any reason why I should keep this hidden menu? Is anyone still using this?

[Hellfish]

Huh, never knew that existed. Wonder if there's any other easter egges in Forge

[Sloth]

I never heard of this. I use wordpad to make decks.

[Max mtg]

I never heard of this. I use wordpad to make decks.

Sloth, that's not for long, I promise.
The new deck editor filters cards as you type, no more progress bars and "apply filter" buttons

I've tracked that code - Gui_Quest_DeckEditor_Menu constructor. It's there for over 2 years, no modification has touched it by now, while QuestData was reorganized and deck formats were changed. Well, I'll remove it.

[Chris H.]

Originally, all of the AI decks were included in the questData file. Rares gave us (me) the hidden "edit" file so that I could add some new decks for the AI. At that time new AI decks had to be imported as a serialized (?) object and was done via this hidden menu. We did not have the individual AI .dck files at that time.

Dennis modified the code while developing the fantasy quest mode. His work separated the AI decks from the questData file. This made it far easier for people to add new quest AI decks.

It should be safe to remove that old code at this time.

[Doublestrike]

Here's a good place to mention, at Max MTG mostly, that I'm attacking bug 4 (http://cardforge.org/bugz/view.php?id=4) which is transitioning quest decks meta from hard code, into the .dck file.

It was going great for the first 272 battle files, but now I'm into the quest files whose mechanics are more convoluted and can be coded more efficiently.

As I'm working away I'll be making a few very minor name changes that might affect methods or references outside of my immediate work. So Max I'll try to stay out of your way but there may be a reference or method name that is changed here or there. Functionality will stay the same.

An example of this is http://svn.slightlymagic.net/websvn/lis ... &rev=10134 where the old method names were not very helpful. There are also other cases where the same method name is used in different classes misleading and just begging to be fixed.

[Sloth]

Here's a good place to mention, at Max MTG mostly, that I'm attacking bug 4 (http://cardforge.org/bugz/view.php?id=4) which is transitioning quest decks meta from hard code, into the .dck file.

It was going great for the first 272 battle files, but now I'm into the quest files whose mechanics are more convoluted and can be coded more efficiently.

As I'm working away I'll be making a few very minor name changes that might affect methods or references outside of my immediate work. So Max I'll try to stay out of your way but there may be a reference or method name that is changed here or there. Functionality will stay the same.

An example of this is http://svn.slightlymagic.net/websvn/lis ... &rev=10134 where the old method names were not very helpful.

Here's also a good place to mention that I appreciate your work Doublestrike.
Not having to modify three files to add a single new AI deck is relieving.

[Doublestrike]

Cheers Sloth glad my work is making a difference so quickly!

[Chris H.]

Oh, and a big thank you is deserved for adding the specific metadata to all of those AI .dck files.

[Doublestrike]

Oh, and a big thank you is deserved for adding the specific metadata to all of those AI .dck files.

Actually that was the easy part, a quick script or five in PHP and 'twas finished. And not quite all, still working on those quest ones.

Also splitting model and view while I'm here, since I'll be back for GUI work later.

[Max mtg]

DoubleStrike, I've seen your commit moving metadata from code to deck files - it's wonderful! That's the thing that should have been done long ago, and I am very glad you've made it.

As for method names and intersections of code - I have all the decks and their editors checked out, beacause I switch them to lightweight CardPrinted class. Will commit really soon - today or tommorow. The method name changes are no problem at all, I'm merging recent changes into this branch of mine.
QuestData too.

[Doublestrike]

OK great thanks for the confirmation Max. I hope for no problems, although I feel like I'm walking a minefield - mooove verrryyy sloowwwwllyy...