my introduction with minor bugfix patch attached
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
2 posts
• Page 1 of 1
my introduction with minor bugfix patch attached
by skiera » 30 Jan 2012, 22:00
Hi,
My name is Pawel Skierczynski. I'm from Poland. Java developer for 10y+ with swing and mvn experience.
I have my own magic cube, but it's hard for our group to play as often as I'd like to.
I've tried wagic, mage, magareana and forge. Forge had much more cards implemented and 'cube hack' worked wery well. AI was not very impresive, but still it was fun.
I can see new version (I haven't been here for a while) has AI improved somehow and nice new graphics.
At first I checked out code from trunk, put my cube into it (SkieraCube) and just played. After a month or two someone made refactoring that broke cube drafting.
Cube is singleton format and during drafts cards were repeated...
So I fixed it the best I could (added "Singleton:True" keyword in draft definition).
That was the time I asked for commit permision - I felt I can 'givet it back' to community. By the way I've commited my cube definition. I think this fix is still there, I haven't checked.
Now this weekend after a long break I've made project update. Then I've updated my cube definition to be most recent. Unfortunatelly there is new minor bug in drafting that, I've fixed. I wanted to commit it - had no access - end of story.
I've no idea about your development plans, used standards or anything. I could also put patches here in case like that.
----------------------------------------------------------
Anyway I've attached two patches for someone to commit:
Array contains cards drafted for ALL players, that means human also; element [0] is human deck, so there must be +1 somewhere... (alternatively there can be added Mirror match to the draft list at position 0 - it's wierd but also somehow interesting)
Update of my cube also some more cards are implemented now
My name is Pawel Skierczynski. I'm from Poland. Java developer for 10y+ with swing and mvn experience.
I have my own magic cube, but it's hard for our group to play as often as I'd like to.
I've tried wagic, mage, magareana and forge. Forge had much more cards implemented and 'cube hack' worked wery well. AI was not very impresive, but still it was fun.
I can see new version (I haven't been here for a while) has AI improved somehow and nice new graphics.
At first I checked out code from trunk, put my cube into it (SkieraCube) and just played. After a month or two someone made refactoring that broke cube drafting.
Cube is singleton format and during drafts cards were repeated...
So I fixed it the best I could (added "Singleton:True" keyword in draft definition).
That was the time I asked for commit permision - I felt I can 'givet it back' to community. By the way I've commited my cube definition. I think this fix is still there, I haven't checked.
Now this weekend after a long break I've made project update. Then I've updated my cube definition to be most recent. Unfortunatelly there is new minor bug in drafting that, I've fixed. I wanted to commit it - had no access - end of story.
I've no idea about your development plans, used standards or anything. I could also put patches here in case like that.
----------------------------------------------------------
Anyway I've attached two patches for someone to commit:
ControlDraft.txt- (698 Bytes) Downloaded 168 times
Array contains cards drafted for ALL players, that means human also; element [0] is human deck, so there must be +1 somewhere... (alternatively there can be added Mirror match to the draft list at position 0 - it's wierd but also somehow interesting)
SkieraCube.txt- (21.23 KiB) Downloaded 174 times
Update of my cube also some more cards are implemented now
Re: my introduction with minor bugfix patch attached
by Chris H. » 30 Jan 2012, 22:20
Hello, and thank you for your interest and contribution. 
I am Chris H and I am one of the Forge Forum Moderators. I help with the development but my skill set is limited. My primary responsibility is with the releases. I am also one of the four Group Leaders of the forge group.
Doublestrike is in charge of the new UI and would appreciate any help that you may be able to offer.
Dave is in charge of the Maven build and release setup.
Rob Cashwalker is in charge of the recent draft mode work and I am sure that he would appreciate your patch and any help that you may want to offer in this area.
With your introduction Rob may decide to give you commit status which will allow you to push your update to the trunk on our SVN.
Our development plans are discussed on this Developer's Corner Forum and we invite you to participate in any discussions that interest you.
I am Chris H and I am one of the Forge Forum Moderators. I help with the development but my skill set is limited. My primary responsibility is with the releases. I am also one of the four Group Leaders of the forge group.
Doublestrike is in charge of the new UI and would appreciate any help that you may be able to offer.
Dave is in charge of the Maven build and release setup.
Rob Cashwalker is in charge of the recent draft mode work and I am sure that he would appreciate your patch and any help that you may want to offer in this area.
With your introduction Rob may decide to give you commit status which will allow you to push your update to the trunk on our SVN.
Our development plans are discussed on this Developer's Corner Forum and we invite you to participate in any discussions that interest you.
-

Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
2 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 11 guests