Deck Editor Problem

[ArsenalNut]

Deck Editor is messed up. It saves decks out of order so the next time you start Forge the deck shows up with the last card name and won't open.

[Chris H.]

I created this constructed mode deck using this morning's snapshot build and it looks like this:

snapshot | Open

[metadata]
Name=AEther
Deck Type=Constructed
[main]
1 AErathi Berserker|LEG
1 AEther Adept|M11
1 AEther Barrier|NMS
1 AEther Burst|ODY
1 AEther Charge|ONS
[sideboard]

`
Using rev 13545 the same deck file now looks like this:

rev 13545 | Open

1 AErathi Berserker|LEG

1 AEther Adept|M11

1 AEther Barrier|NMS

1 AEther Burst|ODY

1 AEther Charge|ONS

Deck Type=Constructed

Name=AEther

[main]

[metadata]

[sideboard]

[friarsol]

Hey Max, looks like this was your change. Not sure what the plan was here, care to chime in?

[Max mtg]

Yes, the change was mine.

The general idea was to save most files by calling FileUtil.writeFile(final File file, final List<String> data) without creating BufferedWriters in game code. However, that method did contain collectins.sort(data)... for unknown reason.

fixed in 13548

[Max mtg]

+ The reason is known: that method was mainly used to save ratings. Someone decided to sort the data right in writeFile, which turned out in a contract violation (other developers don't expect writeFile to do something besides saving strings to disk).

I tried to add precon decks to quest shop and could not imagine how to store them in memory, so maybe a cleanup of deckmanager, that manages too much at the moment, might help. That's what I am about to do.

[Rob Cashwalker]

I've always thought the Deck and DeckManager classes were in need of over-haul.

[Max mtg]

Look at them now, Rob... or at what remains of them.

Evolution is not over, however. Deckmanager still has a couple of methods for each action - one for constructed, other for draft. These twins will recieve some surgery soon.