It is currently 29 Oct 2025, 12:34
   
Text Size

Patch: New preferences for quest mode

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Patch: New preferences for quest mode

Postby Roujin » 04 Feb 2012, 21:06

Hey everyone,

I made a patch for changing some hardcoded values regarding how the shop works in quest mode into preferences. I already posted it over in this thread, but as it wasn't noticed yet and it fits better in the development subforum anyway, I'll post it here now.
If any dev approves of this, please go ahead and commit it :)

The preferences, their min and max values, and their defaults are:

Maximum Packs: 1-25, default 6
Starting Packs: 0-15, default 4
Wins for Pack: 1-25, default 10
Common Singles: 0-15, default 7
Uncommon Singles: 0-15, default 3
Rare Singles: 0-15, default 1

With the default settings, behavior is unchanged.
Attachments
forge_new_quest_prefs_r13810.txt
SVN Patch for my changes based on r13810
(7.75 KiB) Downloaded 393 times
Roujin
 
Posts: 75
Joined: 01 Nov 2011, 21:58
Has thanked: 6 times
Been thanked: 13 times

Re: Patch: New preferences for quest mode

Postby Sloth » 05 Feb 2012, 08:16

I applied your patch Roujin. Thank you.

You can have commit status if you want to contribute more.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Patch: New preferences for quest mode

Postby Roujin » 05 Feb 2012, 13:29

Thanks for including :)

I'd rather not at the current time - I actually have a load of work to do right now, I was just granting myself a little time off. If I had direct commit rights to this wonderful project I fear my self discipline would not be enough to prevent me from neglecting my work in favor of coding stuff for Forge :lol:

Maybe at some later point though :)

Edit: Doublestrike, if you're reading this, your commit r13822 that touched QuestPreferencesHandler.java missed to remove the line
Code: Select all
lblErrShop.setFontStyle(Font.BOLD);
(I guess, since you removed that line for the other lblErrs)
Roujin
 
Posts: 75
Joined: 01 Nov 2011, 21:58
Has thanked: 6 times
Been thanked: 13 times

Re: Patch: New preferences for quest mode

Postby Doublestrike » 06 Feb 2012, 00:06

Roujin wrote:I fear my self discipline would not be enough to prevent me from neglecting my work in favor of coding stuff for Forge :lol:
I have this problem myself - apologies to my boss :-$


Edit: Doublestrike, if you're reading this, your commit r13822 that touched QuestPreferencesHandler.java missed to remove the line
Code: Select all
lblErrShop.setFontStyle(Font.BOLD);
(I guess, since you removed that line for the other lblErrs)
Okey doke, will fix when home (hopefully I remember).
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 14 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 14 users online :: 0 registered, 0 hidden and 14 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 14 guests

Login Form