AbilityFactory TODO list

[slapshot5]

Ok, it's all working now. Charm should work properly in triggers.

I've added Inquisitor Exarch also.

-slapshot5

[slapshot5]

What's the best way to handle the choices part of things like Gabriel Angelfire? Right now, I've got this working:

Code: Select all

Name:Gabriel Angelfire
ManaCost:3 G G W W
Types:Legendary Creature Angel
Text:no text
PT:4/4
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | Execute$ TrigChoice | TriggerDescription$ At the beginning of your upkeep, choose flying, first strike, trample, or rampage 3. CARDNAME gains that ability until your next upkeep.
SVar:TrigChoice:AB$ GenericChoice | Cost$ 0 | Defined$ You | Choices$ SVar1,SVar2,SVar3,SVar4
SVar:SVar1:DB$ Pump | Defined$ Self | KW$ Flying | UntilYourNextUpkeep$ True | ChoiceDescription$ Flying
SVar:SVar2:DB$ Pump | Defined$ Self | KW$ First Strike | UntilYourNextUpkeep$ True | ChoiceDescription$ First strike
SVar:SVar3:DB$ Pump | Defined$ Self | KW$ Trample | UntilYourNextUpkeep$ True | ChoiceDescription$ Trample
SVar:SVar4:DB$ Pump | Defined$ Self | KW$ Rampage 3 | UntilYourNextUpkeep$ True | ChoiceDescription$ Rampage 3
SVar:RemAIDeck:True
SVar:Picture:http://www.wizards.com/global/images/magic/general/gabriel_angelfire.jpg
End


Is it better to integrate that choice into AF Pump? Or does a generic choice like this seem like a way to script Sarpadian Empires, Vol. VII? I was kind of unsure after I thought of how the Color choice is built into AF Protection.

-slapshot5

[Sloth]

What's the best way to handle the choices part of things like Gabriel Angelfire? Right now, I've got this working:

Code: Select all

Name:Gabriel Angelfire
ManaCost:3 G G W W
Types:Legendary Creature Angel
Text:no text
PT:4/4
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | Execute$ TrigChoice | TriggerDescription$ At the beginning of your upkeep, choose flying, first strike, trample, or rampage 3. CARDNAME gains that ability until your next upkeep.
SVar:TrigChoice:AB$ GenericChoice | Cost$ 0 | Defined$ You | Choices$ SVar1,SVar2,SVar3,SVar4
SVar:SVar1:DB$ Pump | Defined$ Self | KW$ Flying | UntilYourNextUpkeep$ True | ChoiceDescription$ Flying
SVar:SVar2:DB$ Pump | Defined$ Self | KW$ First Strike | UntilYourNextUpkeep$ True | ChoiceDescription$ First strike
SVar:SVar3:DB$ Pump | Defined$ Self | KW$ Trample | UntilYourNextUpkeep$ True | ChoiceDescription$ Trample
SVar:SVar4:DB$ Pump | Defined$ Self | KW$ Rampage 3 | UntilYourNextUpkeep$ True | ChoiceDescription$ Rampage 3
SVar:RemAIDeck:True
SVar:Picture:http://www.wizards.com/global/images/magic/general/gabriel_angelfire.jpg
End


Is it better to integrate that choice into AF Pump? Or does a generic choice like this seem like a way to script Sarpadian Empires, Vol. VII? I was kind of unsure after I thought of how the Color choice is built into AF Protection.

-slapshot5

I think an AF like this would be helpful in the long run. The broken AF Choice is only for abilities where the mode is chosen before resolution. There are some more cards that have some weird choices on resolution (like Clockspinning).

[friarsol]

This isn't quite AFs, but it seemed like the best place to put it:

We should probably change Transmute to just shortcut for an AF, to make use of all of our good structure. This will also fix an issue where Transmute doesn't show the library before that.

Transmute X => AB$ ChangeZone | Cost$ X Dicard<1/CARDNAME> | ActivationZone$ Hand | SorcerySpeed$ True | ChangeType$ Card.cmcEQY

At some point, we should probably convert Cycling and Typecycling to their respective AFs although we probably need to do something with Astral Slide, Fluctuator, Stabilizer and similar, since they all count as Cycling.