It is currently 08 Sep 2025, 11:36
   
Text Size

Implementing variants

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Implementing variants

Postby Hellfish » 08 Dec 2012, 11:54

Alright,I'll see about reintegration when I get home tomorrow :)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Implementing variants

Postby Hellfish » 09 Dec 2012, 20:52

Oh, for the love of... Anybody else care to reintegrate? My computer refuses to recognize my modem so unless I can mooch off the gf's laptop I won't be coding much for a while. (Unless someone knows of an svn-app for android.. :/ )
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Implementing variants

Postby friarsol » 09 Dec 2012, 23:55

Hellfish wrote:Oh, for the love of... Anybody else care to reintegrate? My computer refuses to recognize my modem so unless I can mooch off the gf's laptop I won't be coding much for a while. (Unless someone knows of an svn-app for android.. :/ )
I use rabbitvcs at work for Linux. It's like tortoise svn, but not quite so good.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Implementing variants

Postby Hellfish » 10 Dec 2012, 08:47

There's about 5 svn apps on the Play-store and 4 of them are view-only and the last one does not support merge.. I guess I'm out for a while. :/
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Implementing variants

Postby Sloth » 10 Dec 2012, 19:44

I will try to reintegrate the branch.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Implementing variants

Postby Sloth » 13 Dec 2012, 08:39

The "Download LQ Set Pictures" function currently skips all Schemes ("Skipped Download for: res\preferences\..\pics\ARC\Your Will Is Not Your Own.full.jpg"). Does anyone know why?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Implementing variants

Postby moomarc » 13 Dec 2012, 10:36

Sloth wrote:The "Download LQ Set Pictures" function currently skips all Schemes ("Skipped Download for: res\preferences\..\pics\ARC\Your Will Is Not Your Own.full.jpg"). Does anyone know why?
I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Implementing variants

Postby Sloth » 13 Dec 2012, 12:33

moomarc wrote:I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.
That's not the issue here. Downloading the Set pictures is trying to get them from magiccards.info not cardforge.org.

Code: Select all
SVar:Picture:http://www.cardforge.org/fpics/lq_schemes/your_will_is_not_your_own.jpg
SetInfo:ARC|Common|http://magiccards.info/extras/scheme/archenemy/your-will-is-not-your-own.jpg
I haven't tried the non-set LQ pictures.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Implementing variants

Postby moomarc » 13 Dec 2012, 13:36

Sloth wrote:
moomarc wrote:I know it was working fine when I first uploaded them. Unfortunately I'm not home at the moment though so can't check it out until later.

EDIT: I think I know what happened. There were a problem with a few of the images originally because the base images had different PPIs so my resize script cropped them incorrectly. When I uploaded the set again I must have first renamed the files to their clean name before encrypting them. I'll fix and re-upload this evening.
That's not the issue here. Downloading the Set pictures is trying to get them from magiccards.info not cardforge.org.

Code: Select all
SVar:Picture:http://www.cardforge.org/fpics/lq_schemes/your_will_is_not_your_own.jpg
SetInfo:ARC|Common|http://magiccards.info/extras/scheme/archenemy/your-will-is-not-your-own.jpg
I haven't tried the non-set LQ pictures.
Why on earth would it do that? Sets are always grabbed from cardforge. Maybe it has something to do with the separation of traditional cards and extras? But then, Vanguard shouldn't download either, surely.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Implementing variants

Postby moomarc » 14 Dec 2012, 05:42

Turns out it was the name of the decrypted cardforge files that was causing problems. Should be working now.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Implementing variants

Postby swordshine » 21 Dec 2012, 07:04

For some Vanguard avatars, e.g. Goblin Warchief avatar, pics from different urls have different informations about the hand size or life modifier.
http://www.cardforge.org/fpics/vgd-lq/goblin_warchief_avatar.jpg
http://magiccards.info/extras/other/vanguard-mtgo/goblin-warchief.jpg
Which one is correct?
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

Re: Implementing variants

Postby moomarc » 21 Dec 2012, 07:11

swordshine wrote:For some Vanguard avatars, e.g. Goblin Warchief avatar, pics from different urls have different informations about the hand size or life modifier.
http://www.cardforge.org/fpics/vgd-lq/goblin_warchief_avatar.jpg
http://magiccards.info/extras/other/vanguard-mtgo/goblin-warchief.jpg
Which one is correct?
If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.

EDIT: just checked oracle text on gatherer and +1/+2 is the correct modifier.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Implementing variants

Postby swordshine » 21 Dec 2012, 07:22

moomarc wrote:If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.
Thanks, the life modifier from both pictures of Royal Assassin Avatar is -3, but the template gives +0.
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

Re: Implementing variants

Postby moomarc » 21 Dec 2012, 07:34

swordshine wrote:
moomarc wrote:If you used the card template script to get the card outline, the hand/life modifier should be correct seeing as it's grabbed from arch's mtgdata file which is in turn taken from gatherer. If an image on cardforge is wrong, just let me know. Some of my images might be old and were corrected since the initial release.
Thanks, the life modifier from both pictures of Royal Assassin Avatar is -3, but the template gives +0.
Just checked oracle and the template wins again. ;) I'll modify the image later today some time. Thanks! (And thanks for all the new avatars. Been planning to get a few more done but with my wife being home for holiday, I don't get much forge time :mrgreen: )
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Implementing variants

Postby swordshine » 21 Dec 2012, 09:25

moomarc wrote:Just checked oracle and the template wins again. ;) I'll modify the image later today some time. Thanks! (And thanks for all the new avatars. Been planning to get a few more done but with my wife being home for holiday, I don't get much forge time :mrgreen: )
Enjoy yourself! Here in China, the winter solstice is also a triditional holiday :D and I'm gonna have a party with my friends.
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 79 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 79 users online :: 0 registered, 0 hidden and 79 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 79 guests

Login Form