It is currently 10 Aug 2025, 20:06
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby Sloth » 25 Jun 2011, 12:02

pwangsta wrote:Kor Hookmaster - tapped an Aura Gnarlid, but it didn't stay tapped on the AI's next untap step -> reproduced with a different monster (don't remember which) the next turn
SoulStorm wrote:: Mayael's Aria puts counters on creatures you control even if you don't control a creature with power GE5.
These two are now fixed! Thanks pwangsta and SoulStorm.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby slapshot5 » 25 Jun 2011, 12:50

pwangsta wrote:Elspeth, Knight-Errant - after stealing Elspeth from AI with Dominus of Fealty and killing it by using the -8 ability, the emblem ends up on the AI's side of the board, not mine (although I DO get the effects of the emblem).
This is now fixed.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby goonjamin » 25 Jun 2011, 15:09

SVN r10048

I receive the following error when trying to open the deck editor in quest mode.

Code: Select all
An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


CardFactory : getCard() invalid card name - AErathi Berserker


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_26 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: CardFactory : getCard() invalid card name - AErathi Berserker
   at forge.card.cardFactory.CardFactory.getCard2(Unknown Source)
   at forge.card.cardFactory.CardFactory.getCard(Unknown Source)
   at forge.Gui_Quest_DeckEditor_Menu.covertToCardList(Unknown Source)
   at forge.Gui_Quest_DeckEditor.show(Unknown Source)
   at forge.quest.gui.main.QuestMainPanel.showDeckEditor(Unknown Source)
   at forge.quest.gui.main.QuestMainPanel$7.actionPerformed(Unknown Source)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
goonjamin
 
Posts: 133
Joined: 19 Aug 2010, 19:51
Has thanked: 39 times
Been thanked: 5 times

Re: SVN Bug Reports

Postby Hellfish » 25 Jun 2011, 15:25

I'm on it, goonjamin. It's a bit of a transitional period, in those names.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Chris H. » 25 Jun 2011, 16:09

Hellfish wrote:I'm on it, goonjamin. It's a bit of a transitional period, in those names.
`
What about all of the decks that people have created and saved on their own computer? And the decks that are posted to the decks forum?
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Hellfish » 25 Jun 2011, 16:23

I can use the same backwards-compatibility code as for the questData.Hasn't the deck format changed since the Decks Forum was instituted?
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Chris H. » 25 Jun 2011, 16:39

Hellfish wrote:I can use the same backwards-compatibility code as for the questData.
`
Great

Hellfish wrote:Hasn't the deck format changed since the Decks Forum was instituted?
`
Yeah, I guess that at some point the older style of decks tend to scroll off into oblivion.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby goonjamin » 26 Jun 2011, 00:29

Code: Select all
C:\Users\Mike\Downloads\forge>java -Xmx1024m -jar run-forge.jar
LOR/Aquitect's Will.full.jpg http://cardforge.org/fpics//QXF1aXRlY3QncyBXaWxsLmZ
1bGwuanBn
basedir: res\pics
0/1 - 12271
Error - the LQ picture for LOR/Aquitect's Will.full.jpg could not be found on th
e server. [http://cardforge.org/fpics//QXF1aXRlY3QncyBXaWxsLmZ1bGwuanBn] - http:
//cardforge.org/fpics//QXF1aXRlY3QncyBXaWxsLmZ1bGwuanBn
1/1 - 6723
I think all that need to be changed is the SetInfo from LOR to LRW in the cardcode. At least I changed it here and everything seems to have downloaded fine.
goonjamin
 
Posts: 133
Joined: 19 Aug 2010, 19:51
Has thanked: 39 times
Been thanked: 5 times

Re: SVN Bug Reports

Postby Braids » 26 Jun 2011, 01:40

Chris H. wrote:Yeah, I guess that at some point the older style of decks tend to scroll off into oblivion.
is support for loading (or importing) .dec, .mwDeck, or (modo) .txt files being worked by anyone, or are any of those in the plans?
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: SVN Bug Reports

Postby Chris H. » 26 Jun 2011, 02:13

Braids wrote:is support for loading (or importing) .dec, .mwDeck, or (modo) .txt files being worked by anyone, or are any of those in the plans?
`
It may have been mentioned in the feature request topic.

The Import Deck command is a left over from the original code base. In the past all of the decks were stored in a single file. The export and import commands allowed people to trade individual decks. We still have some of these old relics on the decks forum.


On a similar note:

Fnoed spent some time recently adding some limited metadata to the deck files. The hope being that he or someone else would eventually add in additional metadata.

Sloth and I look forward to the day when we no longer need the separate easy.txt, medium.txt, hard.txt files and the QuestBattle.buildDeckList() method. Allowing this quest related data to be included in the actual quest decks for the AI would be great.

Sol also mentioned that additional metadata could be used in the deck files that would tell the AI which cards should be returned via a tutor.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Braids » 26 Jun 2011, 03:15

Chris H. wrote:Sol also mentioned that additional metadata could be used in the deck files that would tell the AI which cards should be returned via a tutor.
good idea, to get the combos out for that deck. it would help shrink minimax's game tree, too... though we might want a few random cards thrown in to the decision list just in case there is an unexpected win using one.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: SVN Bug Reports

Postby friarsol » 26 Jun 2011, 19:30

It looks like the AI will never cast Spike creatures since they have 0 Toughness and the etbCounter keyword is erased once it is "applied"

Code: Select all
        if (card.isCreature()
                && card.getNetDefense() <= 0
                && !card.hasStartOfKeyword("etbCounter")
                && !card.getText().contains("Modular"))
            return false;
Last edited by friarsol on 26 Jun 2011, 19:55, edited 1 time in total.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Jaedayr » 26 Jun 2011, 19:48

r10072

Hmmm, not sure what to do here. I got
Code: Select all
CardFactory : getCard() invalid card name - AErathi Berserker
when I started a match today, it was fine yesterday. Looking at r10042 I see that card text was modified from AE to one character that has both AE smashed together. (Sorry that I don't know what that is called) The change looks fine online, but when I pull up the card in Eclipse it looks like this
Code: Select all
Name:Ærathi Berserker
Anybody else having this problem? And what can be done to fix it?
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby Hellfish » 26 Jun 2011, 19:56

Are you using Snacko's script or Eclipse to get the latest revision? Because that seems to be where the problem lies.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Braids » 26 Jun 2011, 20:15

Jaedayr wrote:from AE to one character that has both AE smashed together. (Sorry that I don't know what that is called)
it's called "an AE character". i pronounce it "an eye-ee character".

We are presently discussing non-ascii character usage in this thread: http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=4887&p=63341#p63341
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 33 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 33 users online :: 0 registered, 0 hidden and 33 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 33 guests

Login Form