It is currently 14 Aug 2025, 13:02
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby lazylockie » 14 Jan 2011, 18:12

r5138

When suspending 2 Rift Bolt at the same time, only one resolves and the other one disappears. I suspect this is also true for multiple spells with suspend resolving at the same time.
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby friarsol » 14 Jan 2011, 20:05

r5138
Gaze of Justice doesn't list it's additional cost of tapping untapped white creatures. This needs to be added into spellToString() in Ability_Cost.

Actually, the whole toString() section of Cost might be better off being rewritten to have each cost handled as a function that receives whether it's the first cost, and whether it's a spell/ability. And that way we'd only have one primary function with each sub-function handling one specific cost.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Jaedayr » 14 Jan 2011, 20:27

r5139

Activating Imperious Perfect triggers Elvish Vanguard, however the message on the stack says
Code: Select all
1. Elf Warrior - gets a +1/+1 counter.
Should it say Elvish Vanguard instead?
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby slapshot5 » 14 Jan 2011, 21:04

Jaedayr wrote:r5139

Activating Imperious Perfect triggers Elvish Vanguard, however the message on the stack says
Code: Select all
1. Elf Warrior - gets a +1/+1 counter.
Should it say Elvish Vanguard instead?
Fixed. Thanks.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby Snacko » 14 Jan 2011, 21:19

Chris H. wrote:
Snacko wrote:Did you include the folder in zip ? It needs to have only text files in it otherwise it wont work.
`
I tried it both ways with the same result. I selected the /cardsfolder/ and zipped and I also selected all of the card files located inside of the /cardsfolder/ and zipped. It may be related to my iMac's OS.
You can try placing http://www.mediafire.com/file/pbngm2ooc ... folder.zip into cardsfolder folder and see if it works. If it does then there must be something with the zip you're creating.
Snacko
DEVELOPER
 
Posts: 826
Joined: 29 May 2008, 19:35
Has thanked: 4 times
Been thanked: 74 times

Re: SVN Bug Reports

Postby Chris H. » 14 Jan 2011, 21:55

Snacko wrote:[You can try placing http://www.mediafire.com/file/pbngm2ooc ... folder.zip into cardsfolder folder and see if it works. If it does then there must be something with the zip you're creating.
`
I downloaded and tried your zip file and it worked.

Mac OS comes with a built in zip file creator that can be accessed from the Mac OS Finder. Using this command on a single file does not create a folder to be used as a wrapper around the contents. I suspect that selecting multiple files and then zipping them with this command creates a folder to wrap around the multiple files being zipped.

I guess that there must be utils for Mac OS that would not create this folder as a wrapper. When I launched Forge using your archive I did not notice much of a speed increase. Computers with a slower clock speed or hard drive might notice an improvement.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby friarsol » 15 Jan 2011, 03:26

r5158
Undying Rage on my Wolf Pet. AI casts Hideous End on it. Wolf Pet dies, but Undying Rage doesn't get returned to my hand.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby friarsol » 15 Jan 2011, 03:34

lazylockie wrote:r5138

When suspending 2 Rift Bolt at the same time, only one resolves and the other one disappears. I suspect this is also true for multiple spells with suspend resolving at the same time.
Lockie, what exactly did you do? I did this:

Deck with 2 Mox Ruby and 2 Rift Bolt. Cast 2 Moxen, Suspend both Bolts.

Press space until it's my upkeep. Both Rift Bolts gave me the choice to target, I targeted the AI twice. They both got added to the stack properly and dealt damage properly. So this works for me.

Did you have anything else weird about your situation?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Chris H. » 15 Jan 2011, 12:23

- I just updated my local copy to r5179 and built the project. I see that we have two errors.

Code: Select all
The method setIsReplicate(boolean) is undefined for the type SpellAbility   CardFactory.java   /Test r5179/src/forge   line 804   Java Problem

The method setReplicateManaCost(String) is undefined for the type SpellAbility   CardFactory.java   /Test r5179/src/forge   line 805   Java Problem
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Sloth » 15 Jan 2011, 12:28

Chris H. wrote:- I just updated my local copy to r5179 and built the project. I see that we have two errors.

Code: Select all
The method setIsReplicate(boolean) is undefined for the type SpellAbility   CardFactory.java   /Test r5179/src/forge   line 804   Java Problem

The method setReplicateManaCost(String) is undefined for the type SpellAbility   CardFactory.java   /Test r5179/src/forge   line 805   Java Problem
It seems that an unfinished attempt tp implement Replicate was accidently submited. Just run debug in eclipse and comment it out.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby Chris H. » 15 Jan 2011, 13:43

Yeah, I did a search in cardsfolder for files with "K:Replicate" and did not get any hits. I figure an unfinished keyword slipped through on a commit. Like you said, I found the Replicate method and commented it out.

The people using Snacko's scripts may have to wait until one of us removes this small code block. :D
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Chris H. » 15 Jan 2011, 16:17

Using r5186 I attempted to start a new game with the AI and myself set to use the Generate Deck option in the deck selector.

It generates this error exception:

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Mac OS X Version: 10.6.6 Architecture: x86_64

Java Version: 1.6.0_22 Vendor: Apple Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.Gui_NewGame.genDecks(Gui_NewGame.java:681)
   at forge.Gui_NewGame.startButton_actionPerformed(Gui_NewGame.java:593)
   at forge.Gui_NewGame$11.actionPerformed(Gui_NewGame.java:445)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
   at java.awt.Component.processMouseEvent(Component.java:6352)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
   at java.awt.Component.processEvent(Component.java:6117)
   at java.awt.Container.processEvent(Container.java:2085)
   at java.awt.Component.dispatchEventImpl(Component.java:4714)
   at java.awt.Container.dispatchEventImpl(Container.java:2143)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4621)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
   at java.awt.Container.dispatchEventImpl(Container.java:2129)
   at java.awt.Window.dispatchEventImpl(Window.java:2478)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:635)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby friarsol » 15 Jan 2011, 16:56

Chris H. wrote:Using r5186 I attempted to start a new game with the AI and myself set to use the Generate Deck option in the deck selector.
Looks like this was caused by r5181 which removed Display having a base Display.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Jaedayr » 15 Jan 2011, 20:31

r5196

I have noticed a few cards, among them Armadillo Cloak, now have repeated text in the right side info box during a game. Since the txt does not appear to have changed for a long time I wonder if a recent change somewhere else is causing this?

Code: Select all
Enchant creature
Whenever enchanted creature deals damage, you gain that much life.

Enchanted creature gets +2/+2 and has trample.
Enchanted creature gets +2/+2 and has trample.
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby slapshot5 » 15 Jan 2011, 21:21

Chris H. wrote:Yeah, I did a search in cardsfolder for files with "K:Replicate" and did not get any hits. I figure an unfinished keyword slipped through on a commit. Like you said, I found the Replicate method and commented it out.

The people using Snacko's scripts may have to wait until one of us removes this small code block. :D
That's my bad. I fixed this in r5183. I guess you know what I'm working on now... :)

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 7 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 7 guests

Login Form