SVN Bug Reports

[Braids]

Code: Select all

AbilityFactory Parsing Error in getAbility() : Split length of Cost$ Cost$ tapXType<1/Cleric> in Master Apothecary is not 2.

Version:
Forge -- official beta: $Date: 2011-07-02 00:20:39 -0400 (Sat, 02 Jul 2011) $, SVN revision: $Revision: 10300 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_21 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: AbilityFactory Parsing Error in getAbility() : Split length of Cost$ Cost$ tapXType<1/Cleric> in Master Apothecary is not 2.
   at forge.card.abilityFactory.AbilityFactory.getMapParams(AbilityFactory.java:188)
   at forge.card.abilityFactory.AbilityFactory.getAbility(AbilityFactory.java:210)
   at forge.card.cardFactory.CardFactory.getCard2(CardFactory.java:823)
   at forge.card.cardFactory.CardFactory.getCard(CardFactory.java:373)
   at forge.card.cardFactory.CardFactory.<init>(CardFactory.java:105)
...


[Chris H.]

Code: Select all

AbilityFactory Parsing Error in getAbility() : Split length of Cost$ Cost$ tapXType<1/Cleric> in Master Apothecary is not 2.

Version:
Forge -- official beta: $Date: 2011-07-02 00:20:39 -0400 (Sat, 02 Jul 2011) $, SVN revision: $Revision: 10300 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_21 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: AbilityFactory Parsing Error in getAbility() : Split length of Cost$ Cost$ tapXType<1/Cleric> in Master Apothecary is not 2.
   at forge.card.abilityFactory.AbilityFactory.getMapParams(AbilityFactory.java:188)
   at forge.card.abilityFactory.AbilityFactory.getAbility(AbilityFactory.java:210)
   at forge.card.cardFactory.CardFactory.getCard2(CardFactory.java:823)
   at forge.card.cardFactory.CardFactory.getCard(CardFactory.java:373)
   at forge.card.cardFactory.CardFactory.<init>(CardFactory.java:105)
...


`
Fixed.

At times a simple scripting error will slip thorough the cracks. They are farily easy to find and to fix. And it helps to fill out the change file with lots of bug fixes.

[Braids]

At times a simple scripting error will slip thorough the cracks. They are farily easy to find and to fix. And it helps to fill out the change file with lots of bug fixes.

i ran into another one last night, too. it was fixed pretty fast. it's nice that forge graciously works around the problem. it's also nice that people are monitoring the board to fix these things. thank you.

[Chris H.]

Would someone mind testing Festival from version 10637? The effect token is there, but the keyword does not get placed on any creatures. Just want to verify it.

`
I tested it and it is working for me. The keyword was added as a non ability to the detail panel and the creatures did not attack. Looks good from my end.

[jeffwadsworth]

Thanks. That is the second card in two days that misbehaved for me but turned out to be fine.

[timmermac]

R10627: Computer dropped 2x Painter's Servant early thanks to an Aluren that I cast. Later in the game, with those Servants still out, he put a Red Ward on a Galina's Knight. This shouldn't be possible, as the Red Ward is a red card, thanks to the Servants, and the Knight already had protection from red.

[Braids]

R10627: Computer dropped 2x Painter's Servant early thanks to an Aluren that I cast. Later in the game, with those Servants still out, he put a Red Ward on a Galina's Knight. This shouldn't be possible, as the Red Ward is a red card, thanks to the Servants, and the Knight already had protection from red.

are wards exempt from targeting prevention? i know white ward doesn't dispel itself.

[Chris H.]

R10627: Computer dropped 2x Painter's Servant early thanks to an Aluren that I cast. Later in the game, with those Servants still out, he put a Red Ward on a Galina's Knight. This shouldn't be possible, as the Red Ward is a red card, thanks to the Servants, and the Knight already had protection from red.

are wards exempt from targeting prevention? i know white ward doesn't dispel itself.

`
The problem may be with Painter's Servant. I remember testing a code change to get the White Ward to not detach from the enchanted creature a long time ago.

[friarsol]

are wards exempt from targeting prevention? i know white ward doesn't dispel itself.

So the Ward won't remove itself from its own granted ability, but the Knight wasn't a legal target in the first place due to protection on the creature. I'll debug this scenario a bit and see if Painter's Servant is the main issue, or just the sheer targeting.

[friarsol]

So the Ward won't remove itself from its own granted ability, but the Knight wasn't a legal target in the first place due to protection on the creature. I'll debug this scenario a bit and see if Painter's Servant is the main issue, or just the sheer targeting.

Ok. This issue is definitely because of Painter's Servant. It seems like it doesn't follow the Color granting rules quite right, and so while the card seems like it's the right color most of the time, it's not the right color when the spell is being cast. I believe we should be able to convert Painters Servant to Static once AddColor is implemented, which might alleviate this scenario.

The Wards are even a bit trickier (and I'm not sure we handle this situation) but if I cast a White Ward on a creature, and then later give it Protection from White by outside means, the White Ward would fall off (it only stays on from the Protection from White it's granting).

[jeffwadsworth]

So the Ward won't remove itself from its own granted ability, but the Knight wasn't a legal target in the first place due to protection on the creature. I'll debug this scenario a bit and see if Painter's Servant is the main issue, or just the sheer targeting.

Ok. This issue is definitely because of Painter's Servant. It seems like it doesn't follow the Color granting rules quite right, and so while the card seems like it's the right color most of the time, it's not the right color when the spell is being cast. I believe we should be able to convert Painters Servant to Static once AddColor is implemented, which might alleviate this scenario.

The Wards are even a bit trickier (and I'm not sure we handle this situation) but if I cast a White Ward on a creature, and then later give it Protection from White by outside means, the White Ward would fall off (it only stays on from the Protection from White it's granting).

AddColor is implemented. I will look at Painter's Servant right now.

[friarsol]

AddColor is implemented. I will look at Painter's Servant right now.

You sure? I swore I just looked and didn't see it in Continuous.

[jeffwadsworth]

AddColor is implemented. I will look at Painter's Servant right now.

You sure? I swore I just looked and didn't see it in Continuous.

I "thought" I saw it in the SVN...turns out it was in StaticAbility. Oh well.

[SoulStorm]

I'll take a look at which ones are still maintained and include the latest versions back. Some of the ones we were using were quite old/unmaintained.

Thanks Dave!

[jendave]

I'll take a look at which ones are still maintained and include the latest versions back. Some of the ones we were using were quite old/unmaintained.

Thanks Dave!

Well I added back an old version of substance.jar. The process highlighted a problem in the current Eclipse build - the lack of dependency management. The reason I did not add a current version of substance.jar is that substance has several transitive deps. I did not want to create a large manually maintained set of deps in Eclipse. The older jar rolled up the deps but the new ones do not.

On the Maven side, it would have been simple few lines of xml to add substance. Maven would then pick up the transitive deps automatically. I use the Maven plugin for IntelliJ and never have to worry about the transitive deps. There is a Maven plugin for Eclipse at: http://download.eclipse.org/technology/m2e/releases I use it as well and it makes updating deps much easier without affecting the day-to-day development process. It would be great to use it for dep management and so all builds whether by command line or IDE would be consistent.