Bug Reports (snapshot builds)
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Sloth » 16 Feb 2013, 08:06
Are you sure that it doesn't work correctly? The ability of Jade Monolith needs to target a creature (that would be your 5/5 beast token) and then uppon resolution you'd have to select a source (Guilty Conscience).Max mtg wrote:I attack with a beast 5/5 token enchanted by Ai's Guilty Conscience, I also have Jade Monolith.
Cannot use Jade monolith's ability to prevent damage to my creature from the Guilty Conscience, since Jade Monolith's script expects me to choose a creature, though the artifact's Oracle text 'a source of your choice' does not restrict me to a creature
EDIT: I've just tested Jade Monolith and i could select any source like lands and artifacts.
Last edited by Sloth on 16 Feb 2013, 08:12, edited 1 time in total.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by moomarc » 16 Feb 2013, 08:12
The combination actually does work. The initial targeting of a creature during announcement is the selecting the target that damage will be redirected from. Choosing the source only happens at spell resolution. That then creates a temporary replacement effect that handles the redirection.Max mtg wrote:I attack with a beast 5/5 token enchanted by Ai's Guilty Conscience, I also have Jade Monolith.
Cannot use Jade monolith's ability to prevent damage to my creature from the Guilty Conscience, since Jade Monolith's script expects me to choose a creature, though the artifact's Oracle text 'a source of your choice' does not restrict me to a creature
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Bug Reports (snapshot builds)
by storms » 16 Feb 2013, 11:44
jace the memory adept plus 1 not working and Psychic Spiral not working
- storms
- Posts: 10
- Joined: 12 Jan 2013, 20:42
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by bhsfmiao » 16 Feb 2013, 15:35
There're 3 more problems here but not crash.
1.Can't cast Aurelia's Fury or Protean Hydra(or any card with X in it cost) by using Omniscience 's ability.(tried to pay 0 for X but no use)
2."Imprint" ability can't always perform properly. For example, start a new game, cast Land Grant with no land cards in my hand, find out Bayou in my library, put it in my hand and then put it onto the battlefield. If then I cast Chrome Mox, no matter what card was imprinted on it, Chrome Mox can't be tapped.
3.The Pacts aren't performing correctly with Hive Mind. When I cast Pact of the Titan (or any Pact else), it is copied for AI, it doesn't have to pay anything during its upkeep, but I have to pay for both copies of the Pact of the Titan during my next upkeep.
1.Can't cast Aurelia's Fury or Protean Hydra(or any card with X in it cost) by using Omniscience 's ability.(tried to pay 0 for X but no use)
2."Imprint" ability can't always perform properly. For example, start a new game, cast Land Grant with no land cards in my hand, find out Bayou in my library, put it in my hand and then put it onto the battlefield. If then I cast Chrome Mox, no matter what card was imprinted on it, Chrome Mox can't be tapped.
3.The Pacts aren't performing correctly with Hive Mind. When I cast Pact of the Titan (or any Pact else), it is copied for AI, it doesn't have to pay anything during its upkeep, but I have to pay for both copies of the Pact of the Titan during my next upkeep.
- bhsfmiao
- Posts: 4
- Joined: 15 Feb 2013, 17:16
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by friarsol » 16 Feb 2013, 21:14
r19664
Puncture Blast doesn't list Wither in the CardDetailPanel, it does deal damage as -1/-1 counters so this is only a display issue. I was going to just go fix it myself, but it seems where this information is generated has moved since the last time I was in there.
Puncture Blast doesn't list Wither in the CardDetailPanel, it does deal damage as -1/-1 counters so this is only a display issue. I was going to just go fix it myself, but it seems where this information is generated has moved since the last time I was in there.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 16 Feb 2013, 22:19
It's forge.Card.getText() that does not return the correct string, especially forge.Card.getAbilityText()friarsol wrote:I was going to just go fix it myself, but it seems where this information is generated has moved since the last time I was in there.
Line 2373, last change on 11/15/11 by jendave. You really haven't been there for way too long.
Did that stop you from 'fixing that by yourself'?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 16 Feb 2013, 22:48
I couldn't remember the name of the function, just some of what was in there, but what I remember wasn't coming up in the search. And yes, I haven't been in that function in forever.Max mtg wrote:It's forge.Card.getText() that does not return the correct string, especially forge.Card.getAbilityText()friarsol wrote:I was going to just go fix it myself, but it seems where this information is generated has moved since the last time I was in there.
Line 2373, last change on 11/15/11 by jendave. You really haven't been there for way too long.
Did that stop you from 'fixing that by yourself'?
Edit: Thanks for the pointer Max. I guess I was searching for Wither, and expecting it to be listed for permanents, which didn't yield any results. But I think the last time I was in there was probably in late 2010, before that function got split up and simplified (it was even more of a mess back then, which is why I've avoided it since).
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by 7543021 » 17 Feb 2013, 02:05
contagion used by ai can cause game freez
- Attachments
-
2013-02-17-00.txt
- (3.51 KiB) Downloaded 384 times
- 7543021
- Posts: 14
- Joined: 16 Feb 2013, 08:54
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Agetian » 17 Feb 2013, 05:45
r19674:
1) the E key shortcut does not work anymore in the match (which is "pass priority till the next stack event" or something like that, very useful IMO);
2) unbinding a shortcut in preferences (e.g. if I don't want to have a shortcut for Concede Game) causes a NumberFormatException crash when leaving the preferences page;
3) DualListBox.java has the following errors shown when compiling:
1) the E key shortcut does not work anymore in the match (which is "pass priority till the next stack event" or something like that, very useful IMO);
2) unbinding a shortcut in preferences (e.g. if I don't want to have a shortcut for Concede Game) causes a NumberFormatException crash when leaving the preferences page;
3) DualListBox.java has the following errors shown when compiling:
- Code: Select all
Error inconvertible types required: java.util.List<T> found: java.util.List<java.lang.Object> DualListBox.java C:/Users/Agetian/Documents/NetBeansProjects/trunk/src/main/java/forge/gui/DualListBox.java:91
Error inconvertible types required: java.util.List<T> found: java.util.List<java.lang.Object> DualListBox.java C:/Users/Agetian/Documents/NetBeansProjects/trunk/src/main/java/forge/gui/DualListBox.java:103
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by myk » 17 Feb 2013, 07:12
I'll see if I can get these fixed -- I've noticed the 'e' key not working as well, but it's been like that for quite a while. The third issue can likely be fixed with a 'mvn clean' -- it's probably just due to files not getting recompiled properly.Agetian wrote:r19674:
1) the E key shortcut does not work anymore in the match (which is "pass priority till the next stack event" or something like that, very useful IMO);
2) unbinding a shortcut in preferences (e.g. if I don't want to have a shortcut for Concede Game) causes a NumberFormatException crash when leaving the preferences page;
3) DualListBox.java has the following errors shown when compiling:
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by Agetian » 17 Feb 2013, 07:25
Hmm, I tried doing a full clean/rebuild with full update of all dependencies but I'm still getting these errors shown for DualListBox.java :\myk wrote:The third issue can likely be fixed with a 'mvn clean' -- it's probably just due to files not getting recompiled properly.
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by myk » 17 Feb 2013, 08:01
Ah, I see. Do you happen to have a very old or very new version of the java compiler? I'll rewrite those lines to be more "compatible". Edit: try r19679
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by Agetian » 17 Feb 2013, 09:08
Umm I believe I'm using Java 7u13 with the appropriate JDK. Thanks, I'll check it out soon!
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by swordshine » 17 Feb 2013, 13:42
mtg-data.txt is broken for avatars.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by friarsol » 17 Feb 2013, 14:15
How do you mean broken? Do you mean a script that uses it doesn't work? We get it from an outside source, I was just updating it for the set info that was missing.swordshine wrote:mtg-data.txt is broken for avatars.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Who is online
Users browsing this forum: No registered users and 27 guests