It is currently 17 Aug 2025, 07:54
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby krevett » 28 Feb 2012, 17:52

krevett wrote:Yet another bug (sorry for these multiple posts I'm currently playing and post as I notice :) ) still using today's snapshot: A flashbacked spell that is countered by a spell or ability isn't exiled as it should per the rules.
I quote myself because this bug is very annoying, if the AI flashback a spell and I choose to counter it, the AI can flashback it the same turn if it has the ressources because the spell isn't exiled...It makes countering flashbacked spell very poor :twisted:
krevett
 
Posts: 109
Joined: 21 Feb 2012, 22:24
Location: France
Has thanked: 18 times
Been thanked: 9 times

Re: Bug Reports (snapshot builds)

Postby timmermac » 28 Feb 2012, 18:50

Avatar switching bug still exists as of r14436.
Attachments
Avatar switching bug.PNG
In the avatar selection screen, the doll is the AI avatar.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
User avatar
timmermac
Tester
 
Posts: 1512
Joined: 17 May 2010, 20:36
Has thanked: 18 times
Been thanked: 95 times

Re: Bug Reports (snapshot builds)

Postby krevett » 28 Feb 2012, 19:06

timmermac wrote:Avatar switching bug still exists as of r14436.
In fact, when I select my avatars in properties and test in constructed they are well placed, but if I play a match in quest mode they get switched and remain switched after that.
krevett
 
Posts: 109
Joined: 21 Feb 2012, 22:24
Location: France
Has thanked: 18 times
Been thanked: 9 times

Re: Bug Reports (snapshot builds)

Postby Doublestrike » 29 Feb 2012, 00:12

Ahh, the problem is in quest mode. Thanks, Krevett, god is in the details.

Fixed.
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Re: Bug Reports (snapshot builds)

Postby krevett » 29 Feb 2012, 14:09

I don't know if it was fixed in today's snapshot but if that's the case the avatar still switch when going into quest mode (r14456) I report but perhaps the fix will be in tomorrow's snapshot :)
Anyway thanks everyone for this wonderful project!!

Edit: Just to tell that the way avatars are displayed in the options takes much longer to load than the first time they were included...

Edit2: Sorry, just reset the avatars and now it seems to works properly, my preference file was inversed :wink:

Edit3: Eventually, after some match in quest mode, my avatar is inversed with the one I choosed for AI in my preferences but it's not inversed with the icon of my quest oponnent
krevett
 
Posts: 109
Joined: 21 Feb 2012, 22:24
Location: France
Has thanked: 18 times
Been thanked: 9 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 01 Mar 2012, 01:11

r14463
When the AI plays a land with a triggered ability, the trigger isn't flushed to the stack before the AI continues to play. This can create a situation where the AI casts a Sorcery and a Land trigger appears on top/bottom (I forget which) of it.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby krevett » 01 Mar 2012, 13:39

In fact the avatar switch bug now seems to switch between those i've chosen for the AI and myself in settings each time I restart forge.
krevett
 
Posts: 109
Joined: 21 Feb 2012, 22:24
Location: France
Has thanked: 18 times
Been thanked: 9 times

Re: Bug Reports (snapshot builds)

Postby gos » 02 Mar 2012, 13:18

Chris H. wrote:No need to change all of the earlier decks, people can place them into the /decks/ directory and Max's converter will convert and then move them into the /decks/constructed/ directory automatically.
I have to admit, I'm not too happy with the converter renaming all the .dck files...
gos
 
Posts: 4369
Joined: 03 Mar 2011, 15:21
Location: Reykjavík, Iceland
Has thanked: 231 times
Been thanked: 232 times

Re: Bug Reports (snapshot builds)

Postby Chris H. » 02 Mar 2012, 13:21

gos wrote:
Chris H. wrote:No need to change all of the earlier decks, people can place them into the /decks/ directory and Max's converter will convert and then move them into the /decks/constructed/ directory automatically.
I have to admit, I'm not too happy with the converter renaming all the .dck files...
`
Can you give us an example of what you are seeing?
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Bug Reports (snapshot builds)

Postby gos » 02 Mar 2012, 13:34

Chris H. wrote:
gos wrote:
Chris H. wrote:No need to change all of the earlier decks, people can place them into the /decks/ directory and Max's converter will convert and then move them into the /decks/constructed/ directory automatically.
I have to admit, I'm not too happy with the converter renaming all the .dck files...
Can you give us an example of what you are seeing?
Example:

I put a file named Ali Aintrazi's Heartless Rites.dck in the /res/decks/ folder.
After I start forge, and the converter has done its work, the file is in the /res/decks/constructed/ folder, but it's named AliAintrazisHeart.dck.

Worse:

I put the following files in the /res/decks/ folder:
Crypt of Agadeem, Budget Version 2.dck
Crypt of Agadeem, Budget Version 3.dck
Crypt of Agadeem, Final Budget Version.dck
Crypt of Agadeem, Non-Budget Version.dck
Crypt of Agadeem, Version 1.dck


After the conversion, I have the following decks in the /res/decks/constructed/ folder:
CryptofAgadeemBu.dck
CryptofAgadeemFi.dck
CryptofAgadeemNo.dck
CryptofAgadeemVe.dck


That first one is Budget Version 3 - I haven't found Budget Version 2, and I have a sinking feeling that it's been overwritten...
gos
 
Posts: 4369
Joined: 03 Mar 2011, 15:21
Location: Reykjavík, Iceland
Has thanked: 231 times
Been thanked: 232 times

Re: Bug Reports (snapshot builds)

Postby gos » 02 Mar 2012, 13:41

gos wrote:That first one is Budget Version 3 - I haven't found Budget Version 2, and I have a sinking feeling that it's been overwritten...
Yeah, it looks like it's permanently gone and needs to be recreated. I have all the decks I compile from the wizards.com columns in database form, but I have no overview of any other decks that may or may not have been deleted permanently just now.
gos
 
Posts: 4369
Joined: 03 Mar 2011, 15:21
Location: Reykjavík, Iceland
Has thanked: 231 times
Been thanked: 232 times

Re: Bug Reports (snapshot builds)

Postby Chris H. » 02 Mar 2012, 14:01

gos wrote:
gos wrote:That first one is Budget Version 3 - I haven't found Budget Version 2, and I have a sinking feeling that it's been overwritten...
Yeah, it looks like it's permanently gone and needs to be recreated. I have all the decks I compile from the wizards.com columns in database form, but I have no overview of any other decks that may or may not have been deleted permanently just now.
`
I think there is some code which limits the file names in forge when we save a deck in the deck editor. The length limit may be 20 characters? And space characters (and other special chars) are removed when the deck is saved. I guess that the converter is using the same code?

We can edit the file name of a deck outside of forge and make the name longer and add space characters.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 02 Mar 2012, 14:21

Chris H. wrote:We can edit the file name of a deck outside of forge and make the name longer and add space characters.
That's not really a solution. Stripping possibly harmful characters and spaces is one thing, but truncating and overwriting without warning/renaming is really bad.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Chris H. » 02 Mar 2012, 14:29

friarsol wrote:
Chris H. wrote:We can edit the file name of a deck outside of forge and make the name longer and add space characters.
That's not really a solution. Stripping possibly harmful characters and spaces is one thing, but truncating and overwriting without warning/renaming is really bad.
`
I did not mean this to be taken as a solution. It is more of an explanation on how people could rename their decks outside of forge and then with this new version find that they are having the same problem as Gos. I myself have renamed my constructed decks outside of forge. This may end up more widespread.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 02 Mar 2012, 17:56

@14501
Code: Select all
    public final String getBestFileName() {
        return this.getName().replaceAll("[^-_$#@.{[()]} a-zA-Z0-9]", "");
    }
Its older edition was truncating filenames for decks some time ago.

To recreate your decks move all files from res/decks/constructed to res/decks and let deckparser assign some better names
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: Marek14 and 11 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 12 users online :: 1 registered, 0 hidden and 11 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: Marek14 and 11 guests

Login Form