spDiscard[Tgt|Opp]

[Chris H.]

I fixed the addManaCosts method to correctly handle adding a mana cost with no numeric component. Mind Peel costs B, so Integer.valueOf("") apparantly is the number format exception.... In VB Val("") is 0.

`
Thank you for figuring this out. I will add the last card to the SVN later today.

[Rob Cashwalker]

Looking at Duress for implementing the Reveal and Choose mode, I discover that the computer cheats:

Code: Select all

public boolean canPlayAI() {
                    Card[] c = removeLandAndCreats(AllZone.Human_Hand.getCards());
                    return 0 < c.length;
                }

The spDiscardTgt AI:

Code: Select all

                public boolean canPlayAI()
                {
                   int nCards = getNumCards();
                   
                   PlayerZone pzH = AllZone.getZone(Constant.Zone.Hand, Constant.Player.Human);
                   int numHHand = pzH.size();
                   
                   if (numHHand > (nCards - 1))
                   {
                      if (Tgt)
                         setTargetPlayer(Constant.Player.Human);
                      
                      return true;
                   }
                      
                   return false;
                }

My version will practically always be played as long as the human's hand has at least 1 card. It shouldn't matter to the AI to already know the contents of my hand....

If I were playing, my evaluation basically amounts to play it as long as the opponent has cards to discard. The only reason I wouldn't is if I knew the contents of his hand based on a previous reveal....

SSSAAAYYYYYYY, wouldn't it be kinda cool if somewhere we could remember the human's hand following a reveal. As the human plays cards, the game would remove them from this memorized list. This sort of knowledge could be applicable to all sorts of AI tweaks.
For example, knowing the player is holding a Giant Growth can affect the AI attack.

Edit --
While posting the AI code, I had a WTF moment, and realized that the Discarding of a Hand AI would allow the human to have a hand of zero, so those cards need to have the <numcards> parameter changed to 1.
I also am submitting a slight tweak to the AI code -

Code: Select all

if (numHHand >= nCards)

Don't know why I wrote it the way above....

[Rob Cashwalker]

I just added the RevealYouChoose method to the the SVN.

Cards we already have:

Code: Select all

Coercion
2 B
Sorcery
no text
spDiscardOpp:RevealYouChoose:1:Target opponent reveals his or her hand. You choose a card from it. That player discards that card.:Coercion - opponent reveals hand and discards a card

Distress
B B
Sorcery
no text
spDiscardTgt:RevealYouChoose/Artifact.nonLand,Creature.nonLand,Enchantment,Instant,Planeswalker,Sorcery:1:Target player reveals his or her hand. You choose a nonland card from it. That player discards that card.:Distress - player reveals hand and discards a card 

Thoughtseize
B
Sorcery
no text
spDiscardTgt:RevealYouChoose/Artifact.nonLand,Creature.nonLand,Enchantment,Instant,Planeswalker,Sorcery:1:Drawback$YouLoseLife/2:Target player reveals his or her hand. You choose a nonland card from it. That player discards that card. You lose 2 life.:Thoughtsieze - player reveals hand and discards a card

Duress
B
Sorcery
no text
spDiscardOpp:RevealYouChoose/Artifact.nonCreature.nonLand,Enchantment.nonCreature,Instant,Planeswalker,Sorcery:1:Target opponent reveals his or her hand. Choose a noncreature, nonland card from it. That player discards that card.:Duress - opponent reveals hand and discards a card

Ostracize
B
Sorcery
no text
spDiscardOpp:RevealYouChoose/Creature:1:Target opponent reveals his or her hand. Choose a creature card from it. That player discards that card.:Ostracize - opponent reveals hand and discards a card


Cards that can be added:

Code: Select all

Brainbite
2 U B
Sorcery
no text
spDiscardOpp:RevealYouChoose:1:Target opponent reveals his or her hand. You choose a card from it. That player discards that card.:Brainbite - opponent reveals hand and dicards a card
Draw a card.

Encroach
B
Sorcery
no text
spDiscardTgt:RevealYouChoose/Land.nonBasic:1:Target player reveals his or her hand. You choose a nonbasic land card from it. That player discards that card.:Encroach - player reveals hand and discards a card

Psychic Spear
B
Sorcery
no text
spDiscardTgt:RevealYouChoose/Creature.Spirit,Instant.Arcane,Sorcery.Arcane:1:Target player reveals his or her hand. You choose a Spirit or Arcane card from it. That player discards that card.:Psychic Spear - player reveals hand and discards a card

Shattered Dreams
B
Sorcery
no text
spDiscardOpp:RevealYouChoose/Artifact:1:Target opponent reveals his or her hand. You choose an artifact card from it. That player discards that card.:Shattered Dreams - opponent reveal hand and discards a card



[Chris H.]

Looks good. Thank you.

[Chris H.]

Looks good. Thank you.

`
I merged the new code from the SVN into my local copy and found an error in line 617 at CardFactory.java

Code: Select all

CardListUtil.sortByTextLen(dPChHand);

`
I checked CardListUtil and could not find this method. Did you forget to merge this part of your new code?

[Rob Cashwalker]

probably...

I just uploaded it.

[Chris H.]

I just uploaded it.

`
Thank you.

[Chris H.]

I just added the RevealYouChoose method to the the SVN.

Cards we already have:

Cards that can be added:

`
I merged this material into the SVN.

[Sloth]

Sorry to bring this up again Rob, but Wrench Mind still isn't fixed. If the AI uses it against you, you can discard any number of cards, it won't help unless you discard an artifact.
If you use it on the AI, compy will just ignore it, if it doesn't have any artifacts in hand.

[Rob Cashwalker]

I think I've fixed this - r1973.

The number of cards to be discarded (if not type) was not being set.