New keyword: spDestroyAll

[friarsol]

That might work better, but you probably need to do the calculation twice. Once before the creatures are destroyed and once after they are destroyed. And then subtract the difference. And since I don't know when the calculation occurs I'm not sure if that's quite right either.

We might be better always counting how many of the type is Destroyed during the keyworded resolution and setting an SVar there. Then we can just use that variable instead if it's needed.

We would need the two destroy functions to return a boolean to make this work.
But something like this could do the trick, instead of the current code

Code: Select all

int destroyedCount = 0;
boolean destroyed;
for(int i = 0; i < all.size(); i++) {
  Card c = all.get(i);
  if(NoRegen[0])
     destroyed = AllZone.GameAction.destroyNoRegeneration(c);
  else
     destroyed = AllZone.GameAction.destroy(c);
  if (destroyed) destroyedCount++;
}
card.setSVar("CountDestroyed", Integer.toString(destroyedCount));


[Rob Cashwalker]

No, just "X" does the job. The resolve method counts the number of creatures in play matching the criteria, then counts the remaining ones. The difference is passed to the drawback handler, which uses it as "X".
It's not a number that should be needed for longer than handling the drawback, so it's not necessary to store it as an SVar.

So Hellfire works exactly as I posted.

[Chris H.]

No, just "X" does the job. The resolve method counts the number of creatures in play matching the criteria, then counts the remaining ones. The difference is passed to the drawback handler, which uses it as "X".
It's not a number that should be needed for longer than handling the drawback, so it's not necessary to store it as an SVar.

So Hellfire works exactly as I posted.

`
OK, I think I understand. The X is calculated as part of the code and no additional calculations are needed. So this works as is:

spDestroyAll:Creature.nonBlack:Drawback$DamageYou/X.Plus.3

[Sloth]

There are three cards that have a similar drawback (Multani's Decree, Righteous Fury and Fracturing Gust). They don't count the permanents put into the graveyard, but the permanents destroyed, which is different when cards like Progenitus or Legacy Weapon are involved. Should we leave them for now, ignore the difference and just put them in or do we need another SVar for them?

[Rob Cashwalker]

Once again, the code counts the affected cards on the battlefield before and after the destruction. It doesn't check the graveyard, so those should work OK.

Edit - while I was in CardFactory checking on drawback code to make sure it doesn't execute if the target becomes illegal, I realized that the original code was checking the graveyard. I have now corrected it to reflect the above statement.