Milestone Approaching

[Hellfish]

One better: Here is a zip with data for all sets for the latest beta.
http://www.mediafire.com/?gdytmy2gr7fl3t1

If you can run python scripts you can download Arch's mtg-data files from here:http://www.slightlymagic.net/forum/viewtopic.php?f=27&t=1347&start=105#p43078

If you then put the mtg-data.txt from that archive into your res folder you can run PerSetTracking.py to generate this data for any version of Forge that you have handy.

[slapshot5]

Is there a reason not to check mtg-data.txt into our SVN?
-slapshot5

[Chris H.]

Is there a reason not to check mtg-data.txt into our SVN?
-slapshot5

`
Sounds good to me.

[slapshot5]

Can someone tell me if this patch works for PerSetTracking.py on Windows/Linux.

I tested on Mac OS X.

Code: Select all

Index: res/PerSetTracking.py
===================================================================
--- res/PerSetTracking.py   (revision 5044)
+++ res/PerSetTracking.py   (working copy)
@@ -9,10 +9,10 @@
         raw_input("")
         sys.exit()
 
-if not os.path.isdir(sys.path[0] + "\\PerSetTracking Results") :
-        os.mkdir(sys.path[0] + "\\PerSetTracking Results")
+if not os.path.isdir(sys.path[0] + os.sep + 'PerSetTracking Results') :
+        os.mkdir(sys.path[0] + os.sep + 'PerSetTracking Results')
 
-forgeFolderContents = os.listdir(sys.path[0] + "\\cardsfolder")
+forgeFolderContents = os.listdir(sys.path[0] + os.sep + "cardsfolder")
 forgeFolderFiles = []
 forgeCards = []
 mtgDataCards = {}
@@ -39,9 +39,10 @@
                 if hasFetchedSets :
                         if not hasFetchedCardName :
                                 tmpName = line
+                                tmpName = tmpName.replace('\n','')
                                 hasFetchedCardName = True
                         if line == "\n" :
-                                mtgDataCards[tmpName] = prevline
+                                mtgDataCards[tmpName] = prevline.replace('\n', '')
                                 hasFetchedCardName = False
 
                 prevline = line
@@ -49,13 +50,15 @@
 #Parse Forge
 print("Parsing Forge")
 for i in forgeFolderContents :
-        if os.path.isfile(sys.path[0] + "\\cardsfolder\\" + i) == True :
+        if os.path.isfile(sys.path[0] + os.sep + "cardsfolder" + os.sep + i) == True :
                 forgeFolderFiles.append(i)
 for file in forgeFolderFiles :
-        with open(sys.path[0] + "\\cardsfolder\\" + file) as currentForgeCard :
+        with open(sys.path[0] + os.sep + "cardsfolder" + os.sep + file) as currentForgeCard :
                 tmpname = currentForgeCard.readline()
-                tmpname = tmpname[5:len(tmpname)].replace("AE","Ae")
+                tmpname = tmpname[5:].replace("AE","Ae")
+                tmpname = tmpname.replace('\r\n', '')
                 forgeCards.append(tmpname)
+
                 
 #Compare datasets and output results
 print("Comparing datasets and outputting results.")
@@ -79,14 +82,14 @@
       currentMissing.sort()
       currentImplemented.sort()
       
-        with open(sys.path[0] + "\PerSetTracking Results\set_" + currentSet + ".txt","w") as output :
+        with open(sys.path[0] + os.sep + "PerSetTracking Results" + os.sep + "set_" + currentSet + ".txt", "w") as output :
                 output.write("Implemented (" + str(len(currentImplemented)) + "):\n")
                 for everyImplemented in currentImplemented :
-                        output.write(everyImplemented)
+                        output.write(everyImplemented + '\n')
                 output.write("\n")
                 output.write("Missing (" + str(len(currentMissing)) + "):\n")
                 for everyMissing in currentMissing :
-                        output.write(everyMissing)
+                        output.write(everyMissing + '\n')
                 output.write("\n")
                 output.write("Total: " + str(total) + "\n")
                 output.write("Percentage implemented: " + str(percentage) + "%\n")
@@ -102,7 +105,7 @@
 totalMissing = 0
 totalImplemented = 0
 fullTotal = 0
-with open(sys.path[0] + "\PerSetTracking Results\CompleteStats.txt","w") as statsfile:
+with open(sys.path[0] + os.sep + "PerSetTracking Results" + os.sep + "CompleteStats.txt", "w") as statsfile:
         statsfile.write("Set: Implemented (Missing) / Total = Percentage Implemented\n")
         for dataKey in sorted(totalData.keys()) :
                 totalImplemented += totalData[dataKey][0]


-slapshot5

[sentient6]

Why not just uses os.path.join for the paths?

[slapshot5]

Looks like with r5498, each core set and each major expansion set is at least 40% implemented. When cards made possible by the trigger scripting are added, it's not unlikely that each core set and each expansion will be at least 50% implemented.

-slapshot5

[slapshot5]

I think Chris just put us over 7000 cards with Zirbert's grave cost stuff.

-slapshot5

[Chris H.]

I think Chris just put us over 7000 cards with Zirbert's grave cost stuff.

`
Yep, I just thanked Zirbert for his submission. Good job.

[slapshot5]

I'm not sure if this counter as a milestone or not, but GameActionUtil.java is under 9000 lines of code, down from it's biggest somewhere around 24,000 lines of code.

That's about 15,000 lines of code removed by converting to triggers, stPump*, and stSetPT.

Pretty cool I'd say.

-slapshot5

[friarsol]

That's a pretty good milestone. I haven't looked at in a few days but I think we were about 5-10 Betrayers cards short of having 50% minimum on all sets.

[slapshot5]

That's a pretty good milestone. I haven't looked at in a few days but I think we were about 5-10 Betrayers cards short of having 50% minimum on all sets.

Yep. Six at the moment.

[ZzzzSleep]

I'll have a go at the remaining ninjas today.

[jeffwadsworth]

I'll have a go at the remaining ninjas today.

If you do any from this list, please remove them accordingly. Thanks.

http://www.slightlymagic.net/wiki/Forge ... f_Kamigawa

[slapshot5]

That's a pretty good milestone. I haven't looked at in a few days but I think we were about 5-10 Betrayers cards short of having 50% minimum on all sets.

We have attained this threshold. Each core set and each expansion set has at least 50% of the cards implemented.

-slapshot5

[Chris H.]

I'm not sure if this counter as a milestone or not, but GameActionUtil.java is under 9000 lines of code, down from it's biggest somewhere around 24,000 lines of code.

That's about 15,000 lines of code removed by converting to triggers, stPump*, and stSetPT.

Pretty cool I'd say.

`
The run-forge.jar file from 10-19-2010 is about 8.1 MB and the run-forge.jar from 03-04-2011 is about 7.4 MB in size.