Phase Work

[slapshot5]

Same problem as Library of Alexandria when activating Old Man of the Sea 's "control creature" ability.
-slapshot5

[friarsol]

Ah. Looks like an issue with Input_NoCost_TapAbility and Ability_Tap. I may end up just converting all of those to use Ability_Activated and Cost/Target.

[Jaedayr]

Just finished downloading the latest changes, not sure if this is related to the phase work or not. I lost the first game to the computer and when the second game started my life total was -1. I played a couple more turns, took one point of damage and my life is now 19. I won second game and at start of third game computer showed life of -2 and mine was 17. However when we each took damage it was subtracted from 20. I think that the only problem is what is displayed at the start of the game.

[friarsol]

Hmm.. I haven't noticed this issue, but it sounds like the UI observer code isn't being called.

I'll keep an eye out. What type of game where you playing? Quest or regular?

[Jaedayr]

Regular game has the problem. Just finished first quest match and everything was fine.

[friarsol]

Ok. The issue with Input_NoCost_TapAbility is it wasn't resetting the input control after it added its ability to the stack. This is now fixed so we don't have to try to update however many cards today to use the newer form.

We should keep an eye out for random other Input classes that my testing didn't cover that may need this same thing for. The symptoms should be similar, it looks like it's on the Stack, but the Input message says it isn't.

[friarsol]

Jaedayr I see it now. Should be fixed in latest submission.

[Hellfish]

I think this rather weird bug has to do with the input states, which I gather from the above posts that it was a big part of your work so I'm posting it here.

I was playing with the Arcane Spirits UBG Theme vs a Mono Black Theme and had just traded a Kami of the Tended Garden for a Corrosive Mentor and selected to use the Soulshift it provided when I was hit with a StackOverflow exception. I would paste the full report in but my clipboard bugged out somehow. I did have a Thief of Hope in the graveyard that I could've Soulshifted.

Note that Forge seems to have entered the Input_Cleanup inputstate in a bugged way. Wth?

[friarsol]

I get an error with that Theme. It says Reach Through Mists doesn't exist?

I'll just tested Soulshift, and it looks like my last submission has fixed this problem. I ran into it trying to test out some other stuff. If it's not working for you after you Sync, lemme know and i'll look into it further.

[Jaedayr]

Life total display works as expected now! Thank you.

[Hellfish]

I get an error with that Theme. It says Reach Through Mists doesn't exist?

I'll just tested Soulshift, and it looks like my last submission has fixed this problem. I ran into it trying to test out some other stuff. If it's not working for you after you Sync, lemme know and i'll look into it further.

No problems anymore as of r3166! Thanks!

[Chris H.]

I was play testing the new phase work and the spReturnTgt keyword and at one point the message window states:

Human's Upkeep: Human has priority for Spells or Abilities. Stack is Empty

`
For the heck of it I attempted to cast the Sorcery Raise Dead and was successful.

[friarsol]

Sounds like an issue with spReturn not calling super.canPlay(). See if that fixes the issue? I won't be able to look at it till tomorrow at some point.

[slapshot5]

Not sure if this is your stuff or not:

When Kitsune Dawnblade enters play (with no other creatures in play), you are prompted to select a target card for Kitsune Dawnblade. But,

1) Selecting Kitsune Dawnblade does nothing.
2) clicking on "Cancel" button does nothing.

-slapshot5

[timmermac]

Correct me if I'm wrong here, but with cards with effects like that, shouldn't the game simply ignore that effect and let you continue?