It is currently 12 Nov 2025, 23:11
   
Text Size

Images by Set

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Re: Images by Set

Postby friarsol » 19 Nov 2010, 19:32

Hilarious. Ok, I'll have a fix up in a few minutes.

Edit: Fix is in. The trick I was using to find the set abbreviation was confused by Zendikar, so I lengthened the search term.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 19 Nov 2010, 19:55

Now THAT is hilarious. Mind if I resubmit the script with the card name printing? It's better to see some action, than wonder if it's working. And if there's a problem, there's at least some idea of what card broke it.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 19 Nov 2010, 20:08

Rob Cashwalker wrote:Now THAT is hilarious. Mind if I resubmit the script with the card name printing? It's better to see some action, than wonder if it's working. And if there's a problem, there's at least some idea of what card broke it.
Not a problem. I'd slightly prefer it writing to the error file, but it doesn't matter all that much.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 19 Nov 2010, 20:33

Well I see it writes to the file, but the console is where it needs to indicate activity.

BTW, it doesn't want to update Cloud Pirates, every time the script stops due to timeout (somewhat often so far) it starts with Cloud Pirates again, then skips the others it did already.

Another BTW, this script needs Python 2.7 not 3.2...
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 19 Nov 2010, 21:06

I didn't think I said anything Python requirements anywhere? Was it incompatible in 3.2? I think I have 2.6 on my machine, so I've never tried it on v3s.

Command Prompt writing is a touchy subject between programmers. Some people think you shouldn't fill it if you are doing automated tasks, and some people think you should write things to indicate activity. I'll take a look at Cloud Pirates. I'm guessing it's a Portal related thing.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby friarsol » 19 Nov 2010, 21:18

Portal issue is fixed for Cloud Pirates. Bull Hippo and possibly other Portal cards in that part of the alphabet should be re-run.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 19 Nov 2010, 22:00

Yep it's all done now.

It took so long to do all this that I don't have time to upload the cards to the SVN.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby Rob Cashwalker » 22 Nov 2010, 17:22

I just noticed some cards that eclipse recognized as not having been changed by the setInfoScript.
thanks to my print-out to the console, I have this list:
Code: Select all
Argothian Treefolk
Armistice
Attunement
Barrage Ogre
Bazaar of Baghdad
Benalish Heralds
Bonded Fetch
Boneknitter
Brass Secretary
Brightstone Ritual
Brilliant Plan
Call to the Netherworld
Careful Study
Carnage Altar
Caverns of Despair
Cephalid Broker
Cephalid Looter
Champion Lancer
Combust
Compulsion
Compulsive Research
Control of the Court
Courier's Capsule
Crawlspace
Cruel Bargain
Death's Duet
Disturbed Burial
Divination
Elven Fortress
Emmessi Tome
Enchanted Being
Energy Storm
Etherium Astrolabe
False Defeat
False Mourning
Fluctuator
Footbottom Feast
Frontline Sage
Godtoucher
Grave-Shell Scarab
Guardian Seraph
Heart Warden
Hivis of the Scale
Holy Light
Ironhoof Ox
Jace's Ingenuity
Kongming, "Sleeping Dragon"
Kor Haven
Leyline of Punishment
Lifespark Spellbomb
Life from the Loam
Lymph Sliver
Macabre Waltz
Mental Discipline
Necrogen Spellbomb
Night's Whisper
Norwood Riders
Obsessive Search
Pang Tong, "Young Phoenix"
Pinpoint Avalanche
Piper's Melody
Plated Pegasus
Purity
Pyrite Spellbomb
Pyromancy
Reach Through Mists
Reborn Hope
Return to Battle
Royal Falcon
Salvage
Sapseep Forest
Scepter of Insight
Sea Eagle
Serum Visions
Silent Arbiter
Sphere of Duty
Sphere of Grace
Sphere of Law
Sphere of Purity
Sphere of Reason
Sphere of Truth
Staff of Domination
Stormscale Anarch
Sunbeam Spellbomb
Temple Bell
Think Twice
Tower of Fortunes
Tresserhorn Skyknight
Trigon of Thought
Unearth
Unfulfilled Desires
Urborg Uprising
Urza's Blueprints
Vampiric Sliver
Vision Skeins
Vorrac Battlehorns
Wall of Putrid Flesh
Willow Elf
Windseeker Centaur
Wistful Thinking
Words of Wisdom
Yuan Shao, the Indecisive
Zo-Zu the Punisher
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 22 Nov 2010, 17:38

Looks like this is the fix for the Portal issue causing problems. I'll see if I can get it working more generically.

Edit: It looks like the two with quotes don't play nice with magiccards.info. I tested a random sampling of 10 cards besides those two and all of those worked, so hopefully this will be the final trick.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 22 Nov 2010, 18:40

OK, so the list is now reduced:

Kongming, "Sleeping Dragon"
Pang Tong, "Young Phoenix"
Royal Falcon
Sea Eagle
Willow Elf
Windseeker Centaur

I realize the double quotes may throw it off, but I was able to do the search on magiccards.info with the quotes.

Edit - I realize that those last 4 cards are allegedly not part of any actual set, either with Special rarity or box sets.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 22 Nov 2010, 18:43

Regular searches work but getting "Exact Card" search doesn't. I'll look into the other 4.

Edit: The other 4 all have Rarity of Special, which I specifically skip over.

How do we want to handle them? Windseeker Centaur was a card give away with one of the books, the other three are in Starter.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 22 Nov 2010, 18:50

Magiccards.info reports set membership that doesn't match gatherer. In gatherer, Sea Eagle is a common in both starters and 8ED.

For a few vanilla creatures, I guess it's not worth it, and if they have no set info, then they just won't show up in a set-specific draft, or set-specific picture.. no big deal, I guess.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 22 Nov 2010, 19:00

Yea I have a feeling there may be other Starter cards that are missing their setinfo because our source doesn't have the data. We can just disallow people from trying to draft Starter boosters and at the end of the day it won't be noticeable.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Images by Set

Postby Rob Cashwalker » 22 Nov 2010, 19:29

Not accepting the Special rarity will prevent the Time Spiral purple cards to be included.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Images by Set

Postby friarsol » 22 Nov 2010, 19:44

I know. They also need Time Spiral "Timeshifted" to be included in the set list.

We can tackle that once everything is working as expected.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 29 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 29 users online :: 0 registered, 0 hidden and 29 guests (based on users active over the past 10 minutes)
Most users ever online was 9824 on 10 Nov 2025, 04:33

Users browsing this forum: No registered users and 29 guests

Login Form