Who is planning to do what?

[Max mtg]

these are not bosses - otherwise they would be avaliable once every N battles without a possibility to skip them
Mission - maybe. Will be especially good when you have objectives like 'win duel without using any instants in 10 turn'
I like 'challenges' most.


I also think that my next assignment will be those challenges improvement - to be able to setup the whole battle with needed restrictions to get challenges like "here's the table, win in 1 turn" as it was in DotP 2010

However, I'll have to wait Doublestrike to commit his changes to quest challenges, since he is working on QuestAssignment as well.

[Sloth]

these are not bosses - otherwise they would be avaliable once every N battles without a possibility to skip them

Future feature?

Mission - maybe. Will be especially good when you have objectives like 'win duel without using any instants in 10 turn'
I like 'challenges' most.

Yes, 'challenges' sounds good.

I also think that my next assignment will be those challenges improvement - to be able to setup the whole battle with needed restrictions to get challenges like "here's the table, win in 1 turn" as it was in DotP 2010

This sounds like the Puzzle mode we got lots of requests for. We can incorporate it into (but not exclusively) the quest mode by giving out some prices the first time a riddle is solved.
It should be made clear though, whether the player plays with his own deck or everything is set.

[Max mtg]

Oh, really? Is that the puzzle mode? very well then.
After implementing the mechanics I think both options will be possible: start with everything set up as well as use your own deck to meet some conditions during the challenge.

But let me write the code first.

[Doublestrike]

Challenges it is, then. That renaming will have to wait a bit for a future commit, since there's other priorities at the moment.

@Max - when you have a look at the architecture when my commit finally happens, puzzle mode should be easy to integrate. Will talk later.

Am planning to commit in about 10 hours after work. Have to fix a few errors, and who knows what will pop up, but hoping all is OK.

[friarsol]

Challenges it is, then. That renaming will have to wait a bit for a future commit, since there's other priorities at the moment.

Right click, Refactor, Rename. All done!

[Doublestrike]

Right click, Refactor, Rename. All done!

Would work but there's some variable names that use "quest" or "qq" or something. Also some documentation that uses the current terminology. God is in the details. Anyway no worries it'll get done.

[Hellfish]

Starting to work on the Haunt keyword now, unless anyone objects with their own plans/already made progress.
EDIT:Initial commit done! Couldn't do Orzhov Pontiff for the same reasons we can't do the NPH Exarchs but otherwise got all Haunt cards working.

[Max mtg]

I still cannot understand the whole mechanics for the spells pipeline, so I'll switch to deckbuilding. I would like to implement a special form for import: you copy-paste a deck as seen on some website to the left part of the form and see what forge has understood in a list on the right.

If a deck is well-recognized, player hits accept, otherwise tries to correct the text or enter cards manually (by selecting them from a list)

[friarsol]

Starting to work on the Haunt keyword now, unless anyone objects with their own plans/already made progress.
EDIT:Initial commit done! Couldn't do Orzhov Pontiff for the same reasons we can't do the NPH Exarchs but otherwise got all Haunt cards working.

Hellfish, I don't think the Haunting card needs to be a creature when it dies to haunt things. http://wiki.mtgsalvation.com/article/Haunt

[Sloth]

@Hellfish: I've looked at your Radiance code and it seems that the spells target all the cards (not just the first) which is not correct. The whole implementation is not necessary anyway, Cleansing Beam was already scripted:

| Open

Code: Select all

Name:Cleansing Beam
ManaCost:4 R
Types:Instant
Text:no text
A:SP$ DealDamage | Cost$ 4 R | ValidTgts$ Creature | TgtPrompt$ Select target creature | NumDmg$ 2 | SubAbility$ SVar=DBDamageAll | RememberTargets$ True | ForgetOtherTargets$ True | SpellDescription$ Radiance - CARDNAME deals 2 damage to target creature and each other creature that shares a color with it.
SVar:DBDamageAll:DB$DamageAll | NumDmg$ 2 | ValidCards$ Remembered.Creature+Other+SharesColorWith | SubAbility$ DBCleanup
SVar:DBCleanup:DB$Cleanup | ClearRemembered$ True
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/cleansing_beam.jpg
SetInfo:RAV|Uncommon|http://magiccards.info/scans/en/rav/118.jpg
SetInfo:COM|Uncommon|http://magiccards.info/scans/en/cmd/116.jpg
Oracle:Radiance - Cleansing Beam deals 2 damage to target creature and each other creature that shares a color with it.
End

[Hellfish]

@Sol, if you're referring to the comment in the postFactoryKeywords Haunt-block Saying "First, create trigger that runs when the haunter dies (if it's a creature)", that's just poorly worded. I meant to say "(if it's a creature with haunt as opposed the instants/sorceries with haunts)". The Instants/Sorceries don't get that trigger. So if the Haunting creature gets turned into an enchantment or whatever and then go to the graveyard the trigger will still go off.

@Sloth Cleansing Beam, Leave No Trace & Wojek Embermage work,yes but they're such kludgy workarounds, IMHO. Much better to just specify a parameter in the first ability.The targeting bit is my mistake, will fix ASAP:
EDIT:Actually, the targeting bit is correct already. The "Radiated" cards (Cards not targeted but sharing a color with the target) are not targeted as much as added to the list of targets after the fact. You can test this with a deck with Phantasmal Dragon,another blue creature and Wojek Siren. Cast Wojek Siren on the other blue creature and Phantasmal Dragon correctly gets +1/+1 without being sacrificed.

[friarsol]

@Sol, if you're referring to the comment in the postFactoryKeywords Haunt-block Saying "First, create trigger that runs when the haunter dies (if it's a creature)", that's just poorly worded. I meant to say "(if it's a creature with haunt as opposed the instants/sorceries with haunts)". The Instants/Sorceries don't get that trigger. So if the Haunting creature gets turned into an enchantment or whatever and then go to the graveyard the trigger will still go off.

Perfect, I was just skimming the code and noticed the wording, so I wasn't sure if you were checking it or not. So it got me curious enough to look it up.

[Sloth]

@Sloth Cleansing Beam, Leave No Trace & Wojek Embermage work,yes but they're such kludgy workarounds, IMHO. Much better to just specify a parameter in the first ability.The targeting bit is my mistake, will fix ASAP:
EDIT:Actually, the targeting bit is correct already. The "Radiated" cards (Cards not targeted but sharing a color with the target) are not targeted as much as added to the list of targets after the fact. You can test this with a deck with Phantasmal Dragon,another blue creature and Wojek Siren. Cast Wojek Siren on the other blue creature and Phantasmal Dragon correctly gets +1/+1 without being sacrificed.

But what if the first blue creature gets removed before Wojek Siren resolves, will it fizzle? What if Phantasmal Dragon has protection from white?
(and even if everything works now, you have to make everything future proof)

EDIT: I've just checked the rulings and you should even be able to change the color of the targeted card before the resolution of the radiance spell to change the effect. The implementation of Cleansing Beam is no workaround it's exactly what it should do.

[Hellfish]

1.Yes, Wojek Siren will fizzle if the first blue creature in the example dies while Wojek Siren is on the stack. Try this: With two Phantasmal Dragon s out, cast Wojek Siren on one of them. The targeted Phantasmal Dragon will be sacrificed, Wojek Siren will fizzle and the other Phantasmal Dragon will not get a pump.

2.The radiated cards are grabbed as part of the resolution, so if the color of the target changes before then, the grabbed cards changes as well.

Thanks for examining this, a second set of eyes always help!

EDIT: Forgot to say, I didn't miss your Protection from White-point, I will delve deeper into it tomorrow morning though, damn weeknights..

[Sloth]

2.The radiated cards are grabbed as part of the resolution, so if the color of the target changes before then, the grabbed cards changes as well.

Ah I see. This sounds much safer now. Thank you for the explanation Hellfish.