Cleanup old functions/variables

[Doublestrike]

Hi fellas, I'm back! Glad to be back, I've been excited about refining the new UI.

Although I haven't read all the posts I missed while I was gone, this seems like a good place to chime in.

In my opinion, the old UI code can be sliced out completely since it is somewhat chunky and doesn't really follow the neat package organization present througout the working parts of the project.

One of the things I was worried about was new users (like @mark, looks like he's making some great contributions, thanks mark) being confused with all the legacy code. So I think it should be out ASAP, for that reason and that the project organization will leap forward further - view in view packages, card stuff in card packages, etc. It's a good thing.

All this is to say +1 on the ol' cleanup and I'm stoked to be back!

[Doublestrike]

I'm starting to streamline the old/Braids/new UIs. I just condensed the "forge.view.swing" package into plain old "forge.view", since they're pretty much the same thing. Unfortunately that required moving the Main method so I hope this doesn't cause any problems.

[Chris H.]

I'm starting to streamline the old/Braids/new UIs. I just condensed the "forge.view.swing" package into plain old "forge.view", since they're pretty much the same thing. Unfortunately that required moving the Main method so I hope this doesn't cause any problems.

`
I went to Eclipse' Run -> Run Configuration menu command and set the Main class to:

Code: Select all

forge.view.Main

`
and I can once again run forge from within Eclipse.

This added note might be useful for someone else.

[silly freak]

Make sure to check the pom.xml, I'm sure the main class must be referenced somewhere in there

[Chris H.]

Make sure to check the pom.xml, I'm sure the main class must be referenced somewhere in there

`
The pom looks OK:

Code: Select all

<manifest>
    <mainClass>forge.view.Main</mainClass>
    <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>

[friarsol]

Anyone else having problems with this? I can't seem to get my Eclipse to run properly now.

[slapshot5]

Anyone else having problems with this? I can't seem to get my Eclipse to run properly now.

Haven't had any problems. What are you seeing?

[friarsol]

java.lang.NoClassDefFoundError: forge/view/Main
Caused by: java.lang.ClassNotFoundException: forge.view.Main
at java.net.URLClassLoader$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)

[slapshot5]

Does that class exist?

[friarsol]

Yep I was just looking at it.. Not sure what's going on. Something strange.

Edit: Just ended up nuking my /src/ directory and closing/opening project. Seems like it might be working now.

[slapshot5]

Edit: Just ended up nuking my /src/ directory and closing/opening project. Seems like it might be working now.

Yeah, unfortunately, sometimes Eclipse just sticks in finger in its ear. I've had to nuke more than once to fix random glitchy things.

[moomarc]

I keep having to nuke my cardsfolder every few switches between main and DKA branch. Start getting conflicts that just won't resolve so bombs away.

[slapshot5]

How about shouldCycle, shouldTypeCycle, shouldTransmute and shouldSoulshift in CardFactoryCreatures? They're not being called anywhere.

-slapshot5

[ArsenalNut]

I keep having to nuke my cardsfolder every few switches between main and DKA branch. Start getting conflicts that just won't resolve so bombs away.

One way to avoid this is to create two or more projects in your Eclipse workspace. I like to keep one project where I do modifications and one project that is a clean pull from the repository. In your case, you can point one of the projects at the DKA branch and one at the trunk. Just remember to keep only one project open at a time. I've had an occasional issue running Forge from Eclipse when both projects are open.

[slapshot5]

src/main/java/org/eclipse/wb/swing package? Looks like it's not being used. Not sure when/if it ever was used. Anyone know?

-slapshot5