General UI support

[Doublestrike]

weird morphing

Resizing

The resizing is known, and will be addressed at some point.

The morphing is because the panels are re-used instead of creating new instances. I'll be focusing a little more on performance of the UI soon, which will mean changes like not creating new instances of panels and labels everywhere, and hopefully reusing the ones we have.

I'm looking to eliminate those few seconds of transition in between states, while the UI creates itself. Also going to be cleaning out the old UI code. Anyway, the problem will be around for a week or two while I make this change, but per usual, I will try to make it worth the wait.

[friarsol]

Computer's "Flashback" button shows me all cards in AIs graveyard, not all cards he can cast/activate.

[Doublestrike]

Computer's "Flashback" button shows me all cards in AIs graveyard, not all cards he can cast/activate.

Should be fixed now.

[Chris H.]

I noticed a minor display issue in quest mode, hope that it is easy to fix.

I have downloaded all of the quest images and just now checked to verify. The grey question mark icon is not displaying for the Mystery Event opponent. I see that it is now included with the sprite_icons.png file.

I wonder if the real deck description should be displayed for a Mystery Event opponent. We could either have no description or we could come up with some sort of a generic description.
`

[Doublestrike]

That's a funny one - apparently it's actually for Chief Clancy Wiggum, who's missing the [duel] tag (...hate to open an old can of worms, but it really seems that that information belongs in meta) and also the icon

"Chief Clancy Wiggum" | Open

[metadata]
Name=Chief Clancy Wiggum 1
DisplayName=Chief Clancy Wiggum
Difficulty=easy
Description=UG Flashback deck
Deck Type=constructed
Icon=
[main]
10 Island
10 Forest
4 Seaside Citadel
4 Quiet Speculation
1 Cephalid Vandal
1 Hermit Druid
3 Mental Note
2 Mulch
1 Think Tank
1 Strategic Planning
1 Runic Repetition
1 Deranged Assistant
1 Worry Beads
4 Deep Reconnaissance
1 Dematerialize
1 Think Twice
1 Grasp of Phantoms
1 Silent Departure
1 Deep Analysis
1 Fervent Denial
1 Moment's Peace
1 Call of the Herd
1 Beast Attack
1 Acorn Harvest
1 Chatter of the Squirrel
1 Elephant Ambush
1 Grizzly Fate
1 Howling Gale
1 Folk Medicine
1 Travel Preparations
[sideboard]

"Correct format" | Open

[duel]
[metadata]
Name=Cave Troll 3
Title=Cave Troll
Difficulty=hard
Description=Mono B Quest for the Nihil Stone deck with The Rack, Bottomless Pit and Nyxathid
Icon=Cave Troll.jpg
Deck Type=constructed
[main]
2 Chainer's Edict|TOR
2 Go for the Throat|MBS
3 Ravenous Rats|10E
3 Null Brooch|EXO
4 Nyxathid|CFX
2 Executioner's Capsule|ALA
4 Quicksand|WWK
1 Liliana Vess|M11
3 The Rack|TSB
3 Guul Draz Specter|ZEN
19 Swamp|MBS
3 Bottomless Pit|STH
2 Hymn to Tourach|FEM
2 Inquisition of Kozilek|ROE
2 Grasp of Darkness|SOM
2 Cunning Lethemancer|ALA
3 Quest for the Nihil Stone|WWK
[sideboard]

The "Mystery Event" was there for graceful degredation for a problem exactly like this (win!).

These two problems are fixed.

Regarding the icon, if "Unknown.jpg" icon is included in the quest icons (I don't think it is) it will be found...may as well throw it in since a String filename is needed, not an icon or an image. Would need some refactoring to allow this, I think, so easiest just to include the jpg.

[Doublestrike]

The "too sticky combat panel" should be fixed now.

Also, a major performance bottleneck was just eliminated - you should hopefully notice a speedup in the match UI.

Please observe and let me know if there is any unwanted behavior.

[Chris H.]

I updated my local copy to rev 13962 and started forge. There appears to be some sort of a stability issue graphics wise. Moving my mouse pointer over the various components is causing them to appear and disappear with interesting color changes.

[Sloth]

I updated my local copy to rev 13962 and started forge. There appears to be some sort of a stability issue graphics wise. Moving my mouse pointer over the various components is causing them to appear and disappear with interesting color changes.

I can confirm this. When i click on "Download LQ Set Pictures" and close the window that pops up, a differently colored artifact is left where the window was.

[slapshot5]

Yeah, I would guess I'm seeing the same thing Chris is describing. It seems slower too, but maybe that's all related somehow.

-slapshot5

[Chris H.]

Yeah, it does look strange.

The display also changes as I move the mouse pointer and click on the various components.
`

[moomarc]

I'm using the Dark Ascension skin and not getting this problem. But maybe its OS specific? I'm on Windows 7. (Edit: Tested with the default skin and I still don't have the skinning problem. Looking at Chris's screenshot though It seems that the panel isn't clearing properly before its redrawn. So the buttons appear to fade because of the transparency of the skin's 'theme' colour swatch. Its similar to what used to happen to me when I used a personalised skin with a semi-opaque zebra swatch. As you scrolled the deck lists I'd get this type of behaviour.)

Then on another topic though, I just picked up a small UI update bug. If you try start a constructed game with too many colours selected (eg 3xRandom, 3xselected colours) the start button doesn't reset after the error pop-up. Just the start load bar remains with nowhere to click to start the game after you've corrected your selection, so you have to restart Forge.

[Chris H.]

I changed from the default skin to the Dark Ascension skin and I am still getting the same effect.

[friarsol]

We still have the problem with the UI where Mouse Clicks will Click "on" the last thing selected, even if you are no longer selecting them. Before the action gets passed through to the card, we should probably double-check that we're still actually hovered over that card when clicking.

[Roujin]

I thought this could be a fun little task for me where I can learn a bit about the forge codebase at the same time.


So here's a fix as a SVN patch.. although it might be quicker to just copy paste the fix. ControlField.java, line 271 is the culprit.

It's using the detail area's "current card" as the card to handle the mouse click. I guess there was a time when the detail area only showed cards' details as long as you're hovering over them and back then everything was fine. But when the detail area was changed to keep displaying the last hovered-over card, this bug started showing up.

I changed that to the function call that is also used a few lines above in the maCardOver adapter, to set the detail area's current card in the first place. Works fine now, no more accidental playing wrong land / targeting wrong stuff now.


edit: by hand probably much quicker than downloading and applying the patch, so:

Code: Select all

(ControlField.java, line 271)
-                final Card c = t.getDetailController().getCurrentCard();
+                final Card c = ControlField.this.view.getTabletop().getCardFromMouseOverPanel();


[friarsol]

Someone sign Roujin up for commit status already, he clearly wants to directly spend his free time on the project, so we should oblige him