mtg-data.txt db faults =(
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
32 posts
• Page 2 of 3 • 1, 2, 3
Re: mtg-data.txt db faults =(
by moomarc » 09 Mar 2013, 08:37
I think Rob did the base64 encoding to limit direct traffic to the site by people searching by cardname. Keep in mind that when he started up Cardforge to host some backend, we didn't have unlimited bandwidth and there was also a lot of scrambling because at that time WotC had just sent Rares a new round of DMCA notices wanting to shut down the host at the time. I think that was another reason why we didn't want searches for WotC copyrighted material linking directly to the new host. Some of that saga can be caught up on here.myk wrote:I have a quick semi-related question: why is it that our set-specific LQ pics are on the cardforge server with base64-encoded names? Is this how we get them? Is this standard procedure?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: mtg-data.txt db faults =(
by moomarc » 09 Mar 2013, 08:48
I've uploaded the standard cards for Planechase, just need to do the planes now. Should I upload the images in landscape format as they are when grabbing the hq images, or should I rotate the images to match the other cards. You have to read the card with your head tilted 90 degrees like with split cards for now, but the image is a decent size without having to resize your image panel and maybe at some point someone with the know-how could add some code that rotate's Plane cards in the command zone 90 degrees.Chris H. wrote:I attempted to download the new LQ card set pics that have been released to cardforge over the last year or so. This is the list of cards that as of today do not download.
- the list | Open
Any preferences from the rest of you?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: mtg-data.txt db faults =(
by Chris H. » 09 Mar 2013, 13:03
Max mtg wrote:There is no Rhox in online db at gatherer: http://gatherer.wizards.com/Pages/Searc ... anced&set=[%22Starter+2000%22]
Rhox from 8ed can by no chance get into starter 2000 boosters, because the new card design was launched in 2002 only.
It is also present in S00 folder of hq pictures provided by CCGHQ.
Thanks Max.
I guess that the list at http://www.wizards.com/magic/generic/cardlists/s2k_checklist.txt just goes to show that even the people at the http://www.wizards.com site can make mistakes at times.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: mtg-data.txt db faults =(
by friarsol » 09 Mar 2013, 14:37
According to the Wikipedia page, they have the abbreviation as HOP too, And Arch has said in the past those abbreviations come from Gatherer.Max mtg wrote:About planechase - I hand to rename my PCH folder from CCGHQ download into HOP.
I personally don't like that 'hop' abbreviation, because didn't find any confirmation on the net of this being official edition code. Magic online for instance calls them PC1 (first planechase) and PC2 (for 2012)
http://en.wikipedia.org/wiki/List_of_Ma ... ering_sets
But I also think this is a dumb abbreviation and prefer our old abbreviation.
I think following what Gatherer abbreviations for sets to is a bad idea anyway, since it could lead to the issue where we're forced to create an inaccessible folder in Windows. (this is why we don't have CON as the Conflux folder name)
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by friarsol » 09 Mar 2013, 14:42
It definitely wouldn't have been the 8th edition Rhox, but it looks like it was the Nemesis Rhox. Here's an article: https://www.wizards.com/Magic/Magazine/ ... arcana/390Chris H. wrote:Max mtg wrote:There is no Rhox in online db at gatherer: http://gatherer.wizards.com/Pages/Searc ... anced&set=[%22Starter+2000%22]
Rhox from 8ed can by no chance get into starter 2000 boosters, because the new card design was launched in 2002 only.
It is also present in S00 folder of hq pictures provided by CCGHQ.
Thanks Max.
I guess that the list at http://www.wizards.com/magic/generic/cardlists/s2k_checklist.txt just goes to show that even the people at the http://www.wizards.com site can make mistakes at times.
Not sure why he doesn't appear in gatherer, maybe because he was a promo card? And not actually in the decks?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by myk » 09 Mar 2013, 15:20
I am actually doing some work on the res/pics/ folder layout in my branch. I was experimenting with making our layout match MWS folder layout so we could simplify the file lookup algorithms and unify the filename generation algorithms. Is this a good idea? I have to write migration code to move the files from <progDir>/res/pics/ to <cacheDir>/pics/cards/ anyway, so it seemed like an opportune time to make changes like this.friarsol wrote:I think following what Gatherer abbreviations for sets to is a bad idea anyway, since it could lead to the issue where we're forced to create an inaccessible folder in Windows. (this is why we don't have CON as the Conflux folder name)
@marc: the filenames in the new fpics/HOP/ directory are not base64-encoded, so they're not quite accessible yet.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: mtg-data.txt db faults =(
by friarsol » 09 Mar 2013, 15:43
We don't really need duplicate files here, we could just have a symlink for the HOP folder to point to the old Planechase folder.myk wrote:@marc: the filenames in the new fpics/HOP/ directory are not base64-encoded, so they're not quite accessible yet.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: mtg-data.txt db faults =(
by moomarc » 09 Mar 2013, 16:18
Oops, Hadn't realised that there was already a PLC folder. I can easily just rename that to HOP if that would make life easier. Although I might just stick to the new ones I uploaded and just encode them. The quality is a bit better without pushing the file size too high and the planes are decently cropped to avoid white corners from appearing. So are we using HOP or PLC as the extension?friarsol wrote:We don't really need duplicate files here, we could just have a symlink for the HOP folder to point to the old Planechase folder.myk wrote:@marc: the filenames in the new fpics/HOP/ directory are not base64-encoded, so they're not quite accessible yet.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: mtg-data.txt db faults =(
by myk » 09 Mar 2013, 16:23
PLC is the Planar Chaos expansion, isn't it? At least according to our setdata.txt:
- Code: Select all
$ grep PLC setdata.txt
Code2:PLC|Code3:PLC|Type:Expansion|Name:Planar Chaos
$ grep HOP setdata.txt
Code2:HOP|Code3:HOP|Type:Other|Name:Planechase
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: mtg-data.txt db faults =(
by moomarc » 09 Mar 2013, 16:35
Oh rightmyk wrote:PLC is the Planar Chaos expansion, isn't it? At least according to our setdata.txt:
- Code: Select all
$ grep PLC setdata.txt
Code2:PLC|Code3:PLC|Type:Expansion|Name:Planar Chaos
$ grep HOP setdata.txt
Code2:HOP|Code3:HOP|Type:Other|Name:Planechase
I knew that. So which old Planechase folder was the good friar referring to then? There's no PCH folder on Cardforge, so maybe he was just referring to a local folder named something other than HOP? Could you clarify please Sol.On a side note, is it not worth adding PLC as Code:2 or as an alias for HOP in SetData. Then if someone does bring in the folder named that, they don't have to rename it?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: mtg-data.txt db faults =(
by myk » 09 Mar 2013, 16:52
+1 on the alias. Also, what is the correct name for Assault // Battery's pic? By "correct", I mean MWS-compliant. It's on the server as base64("Assault Battery.full.jpg"), but our code looks for it at base64("AssaultBattery.full.jpg").
Last edited by myk on 09 Mar 2013, 16:59, edited 1 time in total.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: mtg-data.txt db faults =(
by Agetian » 09 Mar 2013, 16:59
@ myk: All other split cards follow the pattern LeftsplitRightsplit.full.jpg, as in FireIce.full.jpg, NightDay.full.jpg, etc., so I assume it should be AssaultBattery.full.jpg.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: mtg-data.txt db faults =(
by myk » 09 Mar 2013, 17:03
confirmed -- I just checked in the HQ pics torrent:
Edit2: The issue for the vanguard pics seems to be that those cards have SetInfo:VAN Special x2, so we look for cardname1.full.jpg and cardname2.full.jpg, but only cardname.full.jpg appears on the server.
- Code: Select all
$ for fname in *; do unzip -l $fname; done | grep Assault.*Battery
40808 12-24-1996 23:32 IN/AssaultBattery.full.jpg
200606 12-24-1996 23:32 TSB/AssaultBattery.full.jpg
Edit2: The issue for the vanguard pics seems to be that those cards have SetInfo:VAN Special x2, so we look for cardname1.full.jpg and cardname2.full.jpg, but only cardname.full.jpg appears on the server.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: mtg-data.txt db faults =(
by Max mtg » 09 Mar 2013, 19:17
So, if we do agree to use PCH set code for planechase, should patch the python script settings like this:
- Code: Select all
Index: res/mtgdata-sets-to-forge.txt
===================================================================
--- res/mtgdata-sets-to-forge.txt (revision 20198)
+++ res/mtgdata-sets-to-forge.txt (working copy)
@@ -54,7 +54,7 @@
GU ULG # Urza's Legacy
===H09 # Premium Deck Series: Slivers
HM HML # Homelands
-===HOP # Planechase
+HOP PCH # Planechase
IA ICE # Ice Age
IN INV # Invasion
===ISD # Innistrad
- Code: Select all
Code2:PCH|Code3:PCH|Type:Other|Name:Planechase|Alias:HOP
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: mtg-data.txt db faults =(
by friarsol » 12 Mar 2013, 19:21
Looks like arch just posted a fix for mtg-data file including split cards
viewtopic.php?f=27&t=1347#p112230
I won't be able to update the file till tomorrow night sometime, so if someone can upload, that'd be great.
viewtopic.php?f=27&t=1347#p112230
I won't be able to update the file till tomorrow night sometime, so if someone can upload, that'd be great.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
32 posts
• Page 2 of 3 • 1, 2, 3
Who is online
Users browsing this forum: No registered users and 16 guests