It is currently 22 May 2025, 22:51
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby myk » 29 Mar 2013, 17:11

I see -- I think I can fix this. brb
myk
 
Posts: 439
Joined: 17 Jan 2013, 02:39
Location: California
Has thanked: 38 times
Been thanked: 57 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 29 Mar 2013, 17:18

zezinhu wrote:There's a bug relating to blink effects. I had a Elvish Visionary in play and my opponent targed it with Tragic Slip. In response I play Restoration Angel targeting my elf. This should cause the Tragic Slip to fizzle (lose target) as the original target of the slip was no longer there.
It fizzles just fine for me. What version are you using? Are you sure you said yes to the optional flicker ability?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby myk » 29 Mar 2013, 17:49

friarsol wrote:I see the card back image. I can't see/find out whatever the original creature was.
Fixed in r20668. It's correct that double-sided cards cannot be flipped "face down", right?
Screen Shot 2013-03-29 at 10.44.01 am.png
Screen Shot 2013-03-29 at 10.44.24 am.png
Screen Shot 2013-03-29 at 10.44.42 am.png
Screen Shot 2013-03-29 at 10.45.28 am.png
myk
 
Posts: 439
Joined: 17 Jan 2013, 02:39
Location: California
Has thanked: 38 times
Been thanked: 57 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 29 Mar 2013, 18:04

myk wrote:It's correct that double-sided cards cannot be flipped "face down", right?
Yep. 711.6. A double-faced permanent always has the status "face up" (see rule 110.6). Double-faced permanents can't be turned face down. If a spell or ability tries to turn a double-faced permanent face down, nothing happens.

Thanks!
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 29 Mar 2013, 21:18

myk wrote:
friarsol wrote:I see the card back image. I can't see/find out whatever the original creature was.
Fixed in r20668. It's correct that double-sided cards cannot be flipped "face down", right?
That's not a good implementation, myk.


You see, the extra parameter you've added came to every sentence in the method
http://svn.slightlymagic.net/websvn/dif ... &peg=20668.
And you had to add another overload, and developers will have to think which method they should call and what to pass as extra parameter.

When you have to add extra parameters (that handle some uncommon special cases) to classes that provide core functionality, it's a true sign that you are following a dangerous path of ending up with spaghetti code.

It would be much easier to have face-down cards use same mechanism as flippables do.
Unfortunatelly I have already done so, and you won't have a chance to implement it. (20669)


Now player may either move mouse to CPicture and press the flip button there, or move mouse over card with SHIFT pressed to see a different side of a card when it's avaliable
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 29 Mar 2013, 22:08

Hulk quest deck cast Fallow Wurm with a Forest in hand, but sacrificed the Wurm instead of discarding. I'm putting this as a bug, because it used to discard previously, so it's not really an AI improvement.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby zezinhu » 30 Mar 2013, 16:45

Hello

How do I play a Gravecrawler from the graveyard when i have another zombie in play? I couldn't find a way. Is there a special way for doing this, or is Gravecrawler bugged?

Cheers
zezinhu
 
Posts: 4
Joined: 27 Mar 2013, 23:02
Has thanked: 0 time
Been thanked: 0 time

Re: Bug Reports (snapshot builds)

Postby friarsol » 30 Mar 2013, 18:06

zezinhu wrote:How do I play a Gravecrawler from the graveyard when i have another zombie in play? I couldn't find a way. Is there a special way for doing this, or is Gravecrawler bugged?
Click on the Lightning Bolt icon underneath your player icon. Any Spells/Abilities outside of your Hand/Battlefield that can be Cast/Activated are activated from here.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby sumomole » 31 Mar 2013, 15:39

When Vendilion Clique enters the battlefield and I target the AI, but the list of hand is mine, if I choose a card, my card will be put on the bottom of library and the AI will draw a card.
If I target myself, everything is ok.
Attachments
2.JPG
User avatar
sumomole
Programmer
 
Posts: 611
Joined: 07 Jun 2011, 08:34
Has thanked: 51 times
Been thanked: 234 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 31 Mar 2013, 17:10

friarsol wrote:Hulk quest deck cast Fallow Wurm with a Forest in hand, but sacrificed the Wurm instead of discarding. I'm putting this as a bug, because it used to discard previously, so it's not really an AI improvement.
I am in process with this - there's a very complicated script of Fallow Wurm, I want it to use Unless$ mechanics.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby 7543021 » 31 Mar 2013, 19:36

. Archon of the Triumvirate can only detain one nonland permanent when it attacks in forge20676
7543021
 
Posts: 14
Joined: 16 Feb 2013, 08:54
Has thanked: 0 time
Been thanked: 0 time

Re: Bug Reports (snapshot builds)

Postby friarsol » 31 Mar 2013, 21:41

Description: Playing a quest game and after the first match, my sideboard pops up. When I click on any card in the sideboard I get this message. Input should be trying to mulligan before I finish sideboarding.

NullPointerException | Open
Code: Select all
Forge Version:    SVN
Operating System: Windows 7 6.1 x86
Java Version:     1.6.0_30 Sun Microsystems Inc.

java.lang.NullPointerException
   at forge.control.input.InputMulligan.showMessage(InputMulligan.java:74)
   at forge.gui.InputProxy$2.run(InputProxy.java:76)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.Dialog$1.run(Unknown Source)
   at java.awt.Dialog$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.awt.Dialog.show(Unknown Source)
   at java.awt.Component.show(Unknown Source)
   at java.awt.Component.setVisible(Unknown Source)
   at java.awt.Window.setVisible(Unknown Source)
   at java.awt.Dialog.setVisible(Unknown Source)
   at forge.gui.GuiChoose.order(GuiChoose.java:171)
   at forge.gui.GuiChoose.sideboard(GuiChoose.java:141)
   at forge.game.player.PlayerControllerHuman.sideboard(PlayerControllerHuman.java:165)
   at forge.game.GameNew.newGame(GameNew.java:120)
   at forge.game.MatchController.startRound(MatchController.java:178)
   at forge.gui.match.ControlWinLose.actionOnContinue(ControlWinLose.java:81)
   at forge.gui.match.ControlWinLose$1.actionPerformed(ControlWinLose.java:49)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby tengumai » 01 Apr 2013, 03:19

Castigate

On 1.3.11, Castigate forces me to discard a card from my hand, even when I select an opponent as a target.
tengumai
 
Posts: 12
Joined: 27 Aug 2011, 18:16
Has thanked: 1 time
Been thanked: 0 time

Re: Bug Reports (snapshot builds)

Postby Max mtg » 01 Apr 2013, 07:55

Sol, I could not reproduce that thing with sideboard. Did you do anything specific to achieve that?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby swordshine » 01 Apr 2013, 11:51

Description: Got an NPE in r20698 when I cast Spelljack or Trickbind.
NullPointerException | Open
Code: Select all
java.lang.NullPointerException
   at forge.card.spellability.TargetChooser.chooseTargets(TargetChooser.java:345)
   at forge.card.spellability.TargetChooser.chooseTargets(TargetChooser.java:366)
   at forge.card.spellability.TargetChooser.chooseTargets(TargetChooser.java:394)
   at forge.card.spellability.SpellAbilityRequirements.fillRequirements(SpellAbilityRequirements.java:89)
   at forge.game.GameActionPlay.playSpellAbilityWithoutPayingManaCost(GameActionPlay.java:79)
   at forge.gui.GuiDisplayUtil$1.run(GuiDisplayUtil.java:637)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:722)
Edit: It was fixed in r20699, thanks Hellfish.
Last edited by swordshine on 01 Apr 2013, 13:05, edited 1 time in total.
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 15 guests


Who is online

In total there are 15 users online :: 0 registered, 0 hidden and 15 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 15 guests

Login Form