Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 07 Apr 2013, 13:39
Crash when activating second ability of Molten Hydra. It had two counters on it at the time.
Edit: I tried fixing this by assigning maxCounters up at the top, and then comparing to this new "cntCounters" variable, which prevented the crash, but then it dealt 0 damage. So I'm just gonna leave it alone.
Edit: I tried fixing this by assigning maxCounters up at the top, and then comparing to this new "cntCounters" variable, which prevented the crash, but then it dealt 0 damage. So I'm just gonna leave it alone.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Hellfish » 07 Apr 2013, 14:18
Description: Clicked "Great!" after winning a quest match. No clue what I did different than the 20 other games I've played today. :/
EDIT: My winnings and stats *were* saved,though.
EDIT: My winnings and stats *were* saved,though.
- UncheckedExecutionException | Open
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Bug Reports (snapshot builds)
by Hellfish » 07 Apr 2013, 14:37
Fixed,thanks!moomarc wrote:Crash directly after muligan (AI going first). I assume it was trying to reveal Chancellor of the Dross, but other cards in his hand include Woebearer, Soul Shred, Straw Golem and basic lands.
- NullPointerException | Open
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Bug Reports (snapshot builds)
by Leviathan » 07 Apr 2013, 15:40
When I start a game, the background loads, but not any of the tabs. I get one or two null pointer exceptions, depending on the type of game I try to start (have tried Constructed, Quest, and Vanguard). For example, starting a Constructed game gives the following two exceptions:
Starting a quest duel gives this exception:
I've poked around and it looks like the tabs aren't being set up correctly. Each crash happens when a tab tries to call getParentCell. This first occurred after I updated to revision 20855 (but I was able to play a few games before it started crashing), and continues as of revision 20874, which generated the stack traces above.
- | Open
- | Open
Starting a quest duel gives this exception:
- | Open
I've poked around and it looks like the tabs aren't being set up correctly. Each crash happens when a tab tries to call getParentCell. This first occurred after I updated to revision 20855 (but I was able to play a few games before it started crashing), and continues as of revision 20874, which generated the stack traces above.
- Leviathan
- Posts: 4
- Joined: 29 May 2012, 03:30
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Max mtg » 07 Apr 2013, 23:49
I have written some code to correct this. Yet it has to be tested.friarsol wrote:Crash when activating second ability of Molten Hydra. It had two counters on it at the time.
Edit: I tried fixing this by assigning maxCounters up at the top, and then comparing to this new "cntCounters" variable, which prevented the crash, but then it dealt 0 damage. So I'm just gonna leave it alone.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 08 Apr 2013, 02:52
I just tested this. Same issue I reported in my edit. No more crash, but no damage dealt either.Max mtg wrote:I have written some code to correct this. Yet it has to be tested.friarsol wrote:Crash when activating second ability of Molten Hydra. It had two counters on it at the time.
Edit: I tried fixing this by assigning maxCounters up at the top, and then comparing to this new "cntCounters" variable, which prevented the crash, but then it dealt 0 damage. So I'm just gonna leave it alone.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 08 Apr 2013, 06:26
Thank you for testing, Sol! yesterday I was falling asleep at that moment.
Yet it was not a problem of CostRemoveCounter. It was calculateAmount that had some incorrect order of if-elses.
@Leviathan, exceptions happen due to lack of tabs. I have little idea on how UI works - but maybe if you reset match UI preferences to default that helps.
By resetting I mean delete the file C:\Users\<your_username>\AppData\Roaming\Forge\preferences\match.xml in your system.
Yet it was not a problem of CostRemoveCounter. It was calculateAmount that had some incorrect order of if-elses.
@Leviathan, exceptions happen due to lack of tabs. I have little idea on how UI works - but maybe if you reset match UI preferences to default that helps.
By resetting I mean delete the file C:\Users\<your_username>\AppData\Roaming\Forge\preferences\match.xml in your system.
Last edited by Max mtg on 08 Apr 2013, 12:21, edited 1 time in total.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 08 Apr 2013, 12:14
Yep, I just report 'em as I see them. That makes sense, since it seemed like the value was being set properly.Max mtg wrote:Thank you for testing, Sol! yesterday I was falling asleep at that moment.
Yet it was not a problem of CostRemoveCounter. It was calculateAmount that had some incorrect order of if-elses.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by friarsol » 09 Apr 2013, 14:19
Hey Max,
What's going on with this change? http://svn.slightlymagic.net/websvn/rev ... &rev=20907
You do realize this was added intentionally, since one of the Quest Pets has haste on its own and was part of the balancing of the quest pets.
What's going on with this change? http://svn.slightlymagic.net/websvn/rev ... &rev=20907
You do realize this was added intentionally, since one of the Quest Pets has haste on its own and was part of the balancing of the quest pets.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 09 Apr 2013, 14:39
That comment looked like a complaint that pets have sickness while they should not. It's ok to rollback this change them.friarsol wrote:Hey Max,
What's going on with this change? http://svn.slightlymagic.net/websvn/rev ... &rev=20907
You do realize this was added intentionally, since one of the Quest Pets has haste on its own and was part of the balancing of the quest pets.
No, Sol, I am stupid and don't realize a thing. And you should express yourself more politelly.
Do you have any active bugs related to concurrency?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 09 Apr 2013, 14:49
I wasn't being sarcastic here. Just explaining why it was there, since you may not be familiar with how the quest pets work.Max mtg wrote:That comment looked like a complaint that pets have sickness while they should not. It's ok to rollback them.
No, Sol, I am stupid and don't realize a thing.
Do you have any active bugs related to concurrency?
The only issue I have (I'm not sure if it's related to concurrency or something else) was after declaring attackers the Input box doesn't regain focus to just continue through the inputs using space bar.
I believe someone else mentioned this, but do you know if there's a way to hold repainting while tapping all of the attackers, so it doesn't happen one at a time? When you attack with more than 6 or so on my laptop, it really slows things down to tap and redraw each creature in turn, instead of tapping everything and redrawing once.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 09 Apr 2013, 15:46
The phases like 'do you realize that...?' express some doubt in mental abilities of a person. That's why I don't like this kind of 'explaination'.friarsol wrote:I wasn't being sarcastic here. Just explaining why it was there, since you may not be familiar with how the quest pets work.
You might just have that commit rolled back and write a note here.
Both issue were adressed with 20915.friarsol wrote:The only issue I have (I'm not sure if it's related to concurrency or something else) was after declaring attackers the Input box doesn't regain focus to just continue through the inputs using space bar.
I believe someone else mentioned this, but do you know if there's a way to hold repainting while tapping all of the attackers, so it doesn't happen one at a time? When you attack with more than 6 or so on my laptop, it really slows things down to tap and redraw each creature in turn, instead of tapping everything and redrawing once.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 09 Apr 2013, 16:28
I'm not a big fan of just rolling back other people's changes. Instead, I'll post about it to see if the person making the changes understood what their action actually did.Max mtg wrote:The phases like 'do you realize that...?' express some doubt in mental abilities of a person. That's why I don't like this kind of 'explaination'.friarsol wrote:I wasn't being sarcastic here. Just explaining why it was there, since you may not be familiar with how the quest pets work.
You might just have that commit rolled back and write a note here.
There was no question on your mental abilities here. This is a large project. I personally worked on balancing the quest pets, so I'm familiar that one of them has Haste and the rest do not. You did not work on balancing the quest pets; what I can tell from your posts, you don't play much of quest mode. This may not actually be true, but that is my perception. The reason I used the phrasing as I did was to find out if you were intentionally trying to change functionality, or if you didn't actually realize the purpose behind the comment and conditional statement it referred to just below it that was changed. I don't believe I said "Max is a stupid head, why is he breaking everything ever?" or anything remotely like that.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Almeida » 09 Apr 2013, 18:28
hey guys another bug is
i have Havengul Lich in play hearthless Summoning, 2 Priest of Urabrask and 2 Perilous Myr i played the ability of Havengul on Priest and in myr dont work after 5 times this same ability
i have Havengul Lich in play hearthless Summoning, 2 Priest of Urabrask and 2 Perilous Myr i played the ability of Havengul on Priest and in myr dont work after 5 times this same ability
-
Almeida - Posts: 41
- Joined: 24 Dec 2011, 04:48
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Max mtg » 09 Apr 2013, 19:31
Being the one in charge of quest mode balance you have the full priveleges to rollback any changes in your area of interest. Especially after I have admitted that the change was wrong.friarsol wrote:I'm not a big fan of just rolling back other people's changes. Instead, I'll post about it to see if the person making the changes understood what their action actually did.
There was no question on your mental abilities here. This is a large project. I personally worked on balancing the quest pets, so I'm familiar that one of them has Haste and the rest do not. You did not work on balancing the quest pets; what I can tell from your posts, you don't play much of quest mode. This may not actually be true, but that is my perception. The reason I used the phrasing as I did was to find out if you were intentionally trying to change functionality, or if you didn't actually realize the purpose behind the comment and conditional statement it referred to just below it that was changed. I don't believe I said "Max is a stupid head, why is he breaking everything ever?" or anything remotely like that.
I worked on pets conversion to script, QuestController, saves, duels and events... don't remember everything already. I didn't work on balance, never liked it, actually.
I treated the comment as a complaint, that pets still come into play with sickness [but this needs to be changed]. And that's what I did.
You didn't say that exact words, but that was... "my perception". "Do you understand... [how can you NOT understand such a basic thing!] " - that is what perception has said.
What you said that I break everything too frequently may be close to truth, still I hope that the positive effect of my other changes and my speed overweight that drawback.
I had doubts about that change, performed it as an isolated commit because of that. Easy to locate and revert. So do revert, leave a note here (in case I do something similiar) and there will be no objections, especially when the subject is not in my area of expertise or responsibility.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Who is online
Users browsing this forum: No registered users and 18 guests