It is currently 18 Jul 2025, 10:25
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby friarsol » 17 Apr 2013, 13:08

Max mtg wrote:@Sol, These bugs seem non-urgent and unrelated to my latest changes, so I'd focus on other areas.
While it may not be a crash, the symbol of a defender not showing up can definitely lose you a game and be very frustrating. Especially if you have targeting arrows turned off (since it lags Forge down much more than it did a handful of releases ago).
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 17 Apr 2013, 13:24

friarsol wrote:
Max mtg wrote:@Sol, These bugs seem non-urgent and unrelated to my latest changes, so I'd focus on other areas.
While it may not be a crash, the symbol of a defender not showing up can definitely lose you a game and be very frustrating. Especially if you have targeting arrows turned off (since it lags Forge down much more than it did a handful of releases ago).
That's why other people should also participate in development. I cannot do every single thing.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 17 Apr 2013, 13:26

Max mtg wrote:That's why other people should also participate in development. I cannot do every single thing.
I'm not sure who asked you to do every single thing? This is a place to report bugs, not ask Max to fix things?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 17 Apr 2013, 22:52

AI cast Amnesia on me dropping my whole hand (4-5 cards)

Comodification crash | Open
java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
at java.util.AbstractList$Itr.next(Unknown Source)
at java.util.Collections$UnmodifiableCollection$1.next(Unknown Source)
at com.google.common.collect.Iterators$8.computeNext(Iterators.java:735)
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
at com.google.common.collect.Lists.newArrayList(Lists.java:144)
at com.google.common.collect.Lists.newArrayList(Lists.java:125)
at forge.card.cardfactory.CardFactoryUtil.getActivateablesFromZone(CardFactoryUtil.java:841)
at forge.card.cardfactory.CardFactoryUtil.getExternalZoneActivationCards(CardFactoryUtil.java:760)
at forge.gui.match.nonsingleton.VField.updateZones(VField.java:334)
at forge.gui.match.nonsingleton.CField$16.run(CField.java:135)
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 17 Apr 2013, 23:58

A new place with comodifications!
Wish i could somehow prevent ui from updating till the game is finished modifying its state
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby jjayers99 » 18 Apr 2013, 03:40

Description: Resolving AI attack with 2x Mourning Thrull.

NullPointerException | Open
Code: Select all
Forge Version:    1.3.13-SNAPSHOT-r20997
Operating System: Windows 7 6.1 x86
Java Version:     1.6.0_27 Sun Microsystems Inc.

java.lang.NullPointerException
   at forge.gui.match.views.VLog.updateConsole(VLog.java:116)
   at forge.gui.match.controllers.CLog.update(CLog.java:41)
   at forge.gui.match.controllers.CLog.update(CLog.java:49)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.util.MyObservable.updateObservers(MyObservable.java:38)
   at forge.GameLog.add(GameLog.java:61)
   at forge.game.zone.MagicStack.add(MagicStack.java:351)
   at forge.game.ai.ComputerUtil.playStack(ComputerUtil.java:233)
   at forge.game.zone.MagicStack.chooseOrderOfSimultaneousStackEntry(MagicStack.java:1044)
   at forge.game.zone.MagicStack.chooseOrderOfSimultaneousStackEntryAll(MagicStack.java:997)
   at forge.game.phase.PhaseHandler.setPriority(PhaseHandler.java:159)
   at forge.game.phase.PhaseHandler.resetPriority(PhaseHandler.java:172)
   at forge.game.phase.PhaseHandler.handleBeginPhase(PhaseHandler.java:407)
   at forge.gui.InputProxy$1.run(InputProxy.java:66)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
jjayers99
 
Posts: 5
Joined: 18 Apr 2013, 03:36
Has thanked: 0 time
Been thanked: 0 time

Re: Bug Reports (snapshot builds)

Postby Symphonic » 18 Apr 2013, 18:28

Was using my Tormod's Crypt on the opponent's graveyard
ConcurrentModificationException | Open
Code: Select all
Forge Version:    1.3.13-SNAPSHOT-r21067
Operating System: Windows 7 6.1 amd64
Java Version:     1.6.0_24 Sun Microsystems Inc.

java.util.ConcurrentModificationException
   at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
   at java.util.AbstractList$Itr.next(Unknown Source)
   at java.util.Collections$UnmodifiableCollection$1.next(Unknown Source)
   at com.google.common.collect.Iterators$8.computeNext(Iterators.java:735)
   at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
   at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
   at com.google.common.collect.Lists.newArrayList(Lists.java:144)
   at com.google.common.collect.Lists.newArrayList(Lists.java:125)
   at forge.card.cardfactory.CardFactoryUtil.getActivateablesFromZone(CardFactoryUtil.java:841)
   at forge.card.cardfactory.CardFactoryUtil.getExternalZoneActivationCards(CardFactoryUtil.java:760)
   at forge.gui.match.nonsingleton.VField.updateZones(VField.java:334)
   at forge.gui.match.nonsingleton.CField$16.run(CField.java:135)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Symphonic
 
Posts: 146
Joined: 10 Dec 2011, 19:09
Has thanked: 3 times
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 19 Apr 2013, 06:54

@Sloth, copying to new ArrayList does not solve concurrent modification excepions, unfortunatelly. The List.newArrayList method opens an iterator and is vulnerable at that time.

@Sol, the what you treated as copypaste error was not an error, not my copy-paste error at least. Look for the words "SumPower_valid" in an older revision, they count CMC too, no idea why. I guess it's a part of AI strategy to estimate creature power based on its cmc.
http://svn.slightlymagic.net/websvn/fil ... &peg=21042
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby RumbleBBU » 19 Apr 2013, 06:57

Bug, or maybe rather unexpexted/undesired behavior.

Playing Jamuraa and Shandalar, I get Arabian Nights boosters every now and then. There's something that's been present in Forge for a while but I only realized just now. Since this wasn't the case when I first played Forge, I suspect this is related to the script that automatically gets the Oracle set info/rarity.

In short, the problem is that certain ARN cards never seemed to be generated in ARN boosters. For example, I could get Ali from Cairo as a random rare but never saw one in a booster. Looking at the card in the cardsfolder, sure enough, Ali from Cairo is a Rare in ARN.

However... The booster info for ARN reads: "Set:ARN|Commons:6|Uncommons:2|Images:1". In other words, an ARN Rare card is never generated in an ARN booster? That doesn't sound good to me.

I seem to recall that, historically, Arabian Nights didn't actually have any "Rare" cards - there were just "Common" and "Uncommon" ARN cards. Is that right? The "Rare" specifier, applied to ARN cards, is a new reinterpretation - but since it is being used for Forge ARN cards (as per current Oracle info), perhaps the ARN line in boosters.txt should be modified somehow? Add a "|Rares:1" to the specification (even though historically not correct) since currently you can't get certain ARN cards at all in boosters?

EDIT: A similar problem would seem to affect The Dark, Chronicles, and Homelands boosters as well.
User avatar
RumbleBBU
 
Posts: 394
Joined: 18 Aug 2012, 04:24
Has thanked: 29 times
Been thanked: 66 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 19 Apr 2013, 12:16

Max mtg wrote:@Sol, the what you treated as copypaste error was not an error, not my copy-paste error at least. Look for the words "SumPower_valid" in an older revision, they count CMC too, no idea why. I guess it's a part of AI strategy to estimate creature power based on its cmc.
http://svn.slightlymagic.net/websvn/fil ... &peg=21042
I wasn't trying to imply it was your copy paste error, just 'a' copy paste error.

But that's in xCount, and fixed my not being able to use Mosswort Bridge when I had creatures of power 10 or greater. It shouldn't have anything to do with the AI.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 19 Apr 2013, 12:21

RumbleBBU wrote:I seem to recall that, historically, Arabian Nights didn't actually have any "Rare" cards - there were just "Common" and "Uncommon" ARN cards. Is that right? The "Rare" specifier, applied to ARN cards, is a new reinterpretation - but since it is being used for Forge ARN cards (as per current Oracle info), perhaps the ARN line in boosters.txt should be modified somehow? Add a "|Rares:1" to the specification (even though historically not correct) since currently you can't get certain ARN cards at all in boosters?

EDIT: A similar problem would seem to affect The Dark, Chronicles, and Homelands boosters as well.
Yes this is correct. We shouldn't just be adding a Rare and that's it, we'd have to calculate the likelihood of having an Uncommon boosted to a Rare (sorta like how Rares can be boosted into Mythics) in these sets.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Chris H. » 19 Apr 2013, 14:34

I have noticed a problem when downloading the quest images.There appears to be one item to download and I then press the start button.

No images are downloaded and I get the following text displayed in my terminal window:

Can't create folder/Users/chrish/Documents/* Forge Snapshot/Caches/pics/icons/http:/www.cardforge.org/fpics/questAvatars
Error - possibly missing URL for: Robin
1/1 - /Users/chrish/Documents/* Forge Snapshot/Caches/pics/icons/http:/www.cardforge.org/fpics/questAvatars/Robin
 
I checked the quest-opponent-icons.txt file and it appears to have the correct entry?

http://www.cardforge.org/fpics/questAvatars/Robin.jpg
 
I checked my icons folder and there already is a Robin.jpg image and I can not explain why Forge thinks that this file needs to be downloaded.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 19 Apr 2013, 15:46

friarsol wrote:But that's in xCount, and fixed my not being able to use Mosswort Bridge when I had creatures of power 10 or greater. It shouldn't have anything to do with the AI.
Ok, sounds fair. Good to know you're sure about this change.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby Symphonic » 19 Apr 2013, 19:24

I was attacking with my Illusionary Servant, when the crash happened. A screenshot of the board is underneath.

NullPointerException | Open
Code: Select all
Forge Version:    1.3.13-SNAPSHOT-r21067
Operating System: Windows 7 6.1 amd64
Java Version:     1.6.0_24 Sun Microsystems Inc.

java.lang.NullPointerException
   at forge.gui.match.views.VCombat.updateCombat(VCombat.java:101)
   at forge.game.phase.CombatUtil.showCombat(CombatUtil.java:1091)
   at forge.game.phase.PhaseHandler.handleBeginPhase(PhaseHandler.java:296)
   at forge.gui.InputProxy$1.run(InputProxy.java:66)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
| Open
Unbenannt.png
Symphonic
 
Posts: 146
Joined: 10 Dec 2011, 19:09
Has thanked: 3 times
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby eruditebaboon » 19 Apr 2013, 21:09

Description: played evolving wilds.

ClassCastException | Open
Code: Select all
Forge Version:    1.3.13-SNAPSHOT-r20997
Operating System: Windows 7 6.1 amd64
Java Version:     1.6.0_24 Sun Microsystems Inc.

java.lang.ClassCastException
   at javax.swing.LayoutComparator.compare(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.sort(Unknown Source)
   at java.util.Collections.sort(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.enumerateAndSortCycle(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.LayoutFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getDefaultComponent(Unknown Source)
   at java.awt.FocusTraversalPolicy.getInitialComponent(Unknown Source)
   at java.awt.Window.getMostRecentFocusOwner(Unknown Source)
   at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.SequencedEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
eruditebaboon
 
Posts: 9
Joined: 07 Mar 2013, 20:22
Has thanked: 0 time
Been thanked: 0 time

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 5 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 5 guests

Login Form