Card Development Questions
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Card Development Questions
by drdev » 17 Feb 2014, 23:01
I'm not opposed to the implementation of the "auto-pay" logic being changed. I admit I did it without fully understanding the corner cases that wouldn't play nice with it. I'm just strongly requesting the feature not be removed completely.Max mtg wrote:AI mana payment is not broken, not when it has no spare mana in pool. Just put a breakpoint at ManaPool.java, line 332 and see when it gets hit:drdev wrote:If auto-payment is broken, then so is AI mana payment, since they use the exact same logic. Instead of contemplating removing the Auto button, can we just fix the AI logic?Max mtg wrote:That's the weird autoplay, that attempts to pay mana with the same instances as used for real payment,
I always told this autopay feature should not be there.
You may not find the Auto button useful, but I know for a fact that many do. It's also a nice way to test the AI logic.
1. AI is paying for an ability (ai does not reach this place when it choses which spells it can afford)
2. Human pays for a spell or ability.
3. "Autoplay" feature checks if it can pay for the spell with mana form pool.
Without autoplay it would work properly.
Probably, some people might like autopay, but it's poorly implemented and stands on the way of adding new cards.
I remember your words that code should not stand on the way of new features. Let's apply this principle here!
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Card Development Questions
by Max mtg » 17 Feb 2014, 23:15
Don't worry about it, the autopayment will remain in a single piece. Just a bit of refactoring and it'll work as intended
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Card Development Questions
by swordshine » 18 Feb 2014, 01:50
Yes, I've tried that method. It seems working.Max mtg wrote:swordshiine, sa.getPayingMana() is the method you should use to learn the mana spent
Another bug: when I tried to activate an ability with colorless activation cost (e.g. Voltaic Key) and tap a dual land to pay the cost (e.g. Bayou), I was not able to choose the color. It automatically activated the first mana ability of the land.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by friarsol » 18 Feb 2014, 02:10
I'm not sure that's a bug. We have a specific express mana payment feature to speed up mana payment when it doesn't matter (like in the case of colorless mana). Express mana is skipped for things like Sunburst, we'd need a way to do that for Jeweled Amulet.swordshine wrote:Another bug: when I tried to activate an ability with colorless activation cost (e.g. Voltaic Key) and tap a dual land to pay the cost (e.g. Bayou), I was not able to choose the color. It automatically activated the first mana ability of the land.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Development Questions
by swordshine » 18 Feb 2014, 02:22
Gotcha, forge.game.spellability.SpellAbility.tracksManaSpent().friarsol wrote:I'm not sure that's a bug. We have a specific express mana payment feature to speed up mana payment when it doesn't matter (like in the case of colorless mana). Express mana is skipped for things like Sunburst, we'd need a way to do that for Jeweled Amulet.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by swordshine » 18 Feb 2014, 15:06
I have an idea to script Leonin Arbiter. I'm not sure if this is the best way to implement ignore effects.
The static ability creates a temporary AbilityStatic to ignore the effect on that card. You may click the card to pay the cost of that temporary ability and exclude you from the static effect.
The static ability creates a temporary AbilityStatic to ignore the effect on that card. You may click the card to pay the cost of that temporary ability and exclude you from the static effect.
- Code: Select all
### Eclipse Workspace Patch 1.0
#P Forge
Index: forge-game/src/main/java/forge/game/staticability/StaticAbilityContinuous.java
===================================================================
--- forge-game/src/main/java/forge/game/staticability/StaticAbilityContinuous.java (revision 24896)
+++ forge-game/src/main/java/forge/game/staticability/StaticAbilityContinuous.java (working copy)
@@ -18,6 +18,8 @@
package forge.game.staticability;
import com.google.common.collect.Lists;
+
+import forge.GameCommand;
import forge.card.CardType;
import forge.card.ColorSet;
import forge.card.mana.ManaCostShard;
@@ -28,10 +30,12 @@
import forge.game.card.CardFactoryUtil;
import forge.game.card.CardLists;
import forge.game.card.CardUtil;
+import forge.game.cost.Cost;
import forge.game.player.Player;
import forge.game.replacement.ReplacementEffect;
import forge.game.replacement.ReplacementHandler;
import forge.game.spellability.AbilityActivated;
+import forge.game.spellability.AbilityStatic;
import forge.game.spellability.SpellAbility;
import forge.game.trigger.Trigger;
import forge.game.trigger.TriggerHandler;
@@ -308,6 +312,11 @@
}
}
+ if (params.containsKey("IgnoreEffectCost")) {
+ String cost = params.get("IgnoreEffectCost");
+ buildIgnorEffectAbility(stAb, cost, affectedPlayers, affectedCards);
+ }
+
// modify players
for (final Player p : affectedPlayers) {
@@ -516,6 +525,44 @@
return affectedCards;
}
+ private static void buildIgnorEffectAbility(final StaticAbility stAb, final String costString, final List<Player> players, final List<Card> cards) {
+ final List<Player> validActivator = new ArrayList<Player>(players);
+ for (final Card c : cards) {
+ validActivator.add(c.getController());
+ }
+ final Card sourceCard = stAb.getHostCard();
+ Cost cost = new Cost(costString, true);
+ final AbilityStatic addIgnore = new AbilityStatic(sourceCard, cost, null) {
+
+ @Override
+ public void resolve() {
+ stAb.addIgnoreEffectPlayers(this.getActivatingPlayer());
+ stAb.setIgnoreEffectCards(cards);
+ }
+
+ @Override
+ public boolean canPlay() {
+ return validActivator.contains(this.getActivatingPlayer())
+ && sourceCard.isInPlay();
+ }
+
+ };
+ addIgnore.setTemporary(true);
+ addIgnore.setIntrinsic(false);
+ addIgnore.setDescription(cost + " Ignore the effect until end of turn.");
+ sourceCard.addSpellAbility(addIgnore);
+
+ final GameCommand removeIgnore = new GameCommand() {
+ private static final long serialVersionUID = -5415775215053216360L;
+ @Override
+ public void run() {
+ stAb.clearIgnoreEffects();
+ }
+ };
+ sourceCard.getGame().getEndOfTurn().addUntil(removeIgnore);
+ sourceCard.addLeavesPlayCommand(removeIgnore);
+ }
+
private static ArrayList<Player> getAffectedPlayers(final StaticAbility stAb) {
final Map<String, String> params = stAb.getMapParams();
final Card hostCard = stAb.getHostCard();
@@ -534,6 +581,7 @@
players.add(p);
}
}
+ players.removeAll(stAb.getIgnoreEffectPlayers());
return players;
}
@@ -573,7 +621,7 @@
if (params.containsKey("Affected")) {
affectedCards = CardLists.getValidCards(affectedCards, params.get("Affected").split(","), controller, hostCard);
}
-
+ affectedCards.removeAll(stAb.getIgnoreEffectCards());
return affectedCards;
}
Index: forge-game/src/main/java/forge/game/staticability/StaticAbility.java
===================================================================
--- forge-game/src/main/java/forge/game/staticability/StaticAbility.java (revision 24896)
+++ forge-game/src/main/java/forge/game/staticability/StaticAbility.java (working copy)
@@ -30,6 +30,7 @@
import forge.game.zone.ZoneType;
import forge.util.Expressions;
+import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -40,6 +41,8 @@
public class StaticAbility extends CardTraitBase {
private int layer = 0;
+ private List<Card> ignoreEffectCards = new ArrayList<Card>();
+ private List<Player> ignoreEffectPlayers = new ArrayList<Player>();
// *******************************************************
@@ -568,8 +571,40 @@
return true;
}
+ /**
+ * @return the ignoreEffectCards
+ */
+ public List<Card> getIgnoreEffectCards() {
+ return ignoreEffectCards;
+ }
/**
+ * @param c the ignoreEffectCards to add
+ */
+ public void setIgnoreEffectCards(List<Card> cards) {
+ this.ignoreEffectCards = cards;
+ }
+
+ /**
+ * @return the ignoreEffectPlayers
+ */
+ public List<Player> getIgnoreEffectPlayers() {
+ return ignoreEffectPlayers;
+ }
+
+ /**
+ * @param p the ignoreEffectPlayers to add
+ */
+ public void addIgnoreEffectPlayers(Player p) {
+ this.ignoreEffectPlayers.add(p);
+ }
+
+ public void clearIgnoreEffects() {
+ this.ignoreEffectPlayers.clear();
+ this.ignoreEffectCards.clear();
+ }
+
+ /**
* @return the layer
*/
public int getLayer() {
Index: forge-game/src/main/java/forge/game/StaticEffects.java
===================================================================
--- forge-game/src/main/java/forge/game/StaticEffects.java (revision 24896)
+++ forge-game/src/main/java/forge/game/StaticEffects.java (working copy)
@@ -21,6 +21,7 @@
import forge.game.card.CardUtil;
import forge.game.player.Player;
import forge.game.replacement.ReplacementEffect;
+import forge.game.spellability.AbilityStatic;
import forge.game.spellability.SpellAbility;
import forge.game.staticability.StaticAbility;
@@ -149,7 +150,13 @@
addColors = CardUtil.getShortColorsString(new ArrayList<String>(Arrays.asList(colors.split(" & "))));
}
}
-
+ if (params.containsKey("IgnoreEffectCost")) {
+ for (final SpellAbility s : se.getSource().getSpellAbilities()) {
+ if (s instanceof AbilityStatic && s.isTemporary()) {
+ se.getSource().removeSpellAbility(s);
+ }
+ }
+ }
// modify players
for (final Player p : affectedPlayers) {
p.setUnlimitedHandSize(false);
Index: forge-gui/res/cardsfolder/l/leonin_arbiter.txt
===================================================================
--- forge-gui/res/cardsfolder/l/leonin_arbiter.txt (revision 0)
+++ forge-gui/res/cardsfolder/l/leonin_arbiter.txt (working copy)
@@ -0,0 +1,7 @@
+Name:Leonin Arbiter
+ManaCost:1 W
+Types:Creature Cat Cleric
+PT:2/2
+S:Mode$ Continuous | Affected$ Player | AddKeyword$ CantSearchLibrary | IgnoreEffectCost$ 2 | Description$ Players can't search libraries. Any player may pay {2} for that player to ignore this effect until end of turn.
+SVar:Picture:http://www.wizards.com/global/images/magic/general/leonin_arbiter.jpg
+Oracle:Players can't search libraries. Any player may pay {2} for that player to ignore this effect until end of turn.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by friarsol » 18 Feb 2014, 15:32
Yea this is basically how I always pictured these cards would work. It looks like there are 4 of these right now. http://magiccards.info/query?q=o%3Aigno ... rd&s=cnameswordshine wrote:I have an idea to script Leonin Arbiter. I'm not sure if this is the best way to implement ignore effects.
The static ability creates a temporary AbilityStatic to ignore the effect on that card. You may click the card to pay the cost of that temporary ability and exclude you from the static effect.
Two things to make sure to test, which I believe will work in this scenario:
1/1/2011: Paying
to ignore Leonin Arbiter's effect is a special action. Any player may take this special action any time he or she has priority. It doesn't use the stack and can't be responded to.1/1/2011: If there are multiple Leonin Arbiters on the battlefield, a player must pay
for each one before being able to search libraries that turn.- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Development Questions
by Max mtg » 20 Feb 2014, 18:03
Congratulations, Scars of Mirroding block is now 100% scripted... as well as the currently released sets from Theros block are.
- The remaning 210 cards | Open
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Card Development Questions
by swordshine » 24 Feb 2014, 11:35
Veiled Crocodile has a simple Always trigger.
FAQ says "It can trigger even if a player's hand is empty momentarily during the middle of the resolution of a spell or ability.", which doesn't work in the current version.
Tethered Griffin "10/4/2004: The ability will trigger if you don't control an enchantment, even for a brief moment during the resolution of another spell or ability."
I played Thassa's Emissary and Tethered Griffin, then cast Cloudshift targeting Thassa's Emissary. This should trigger Tethered Griffin.
We shouldn't run Always triggers in checkStateEffects.
Progress: Veiled Crocodile is scripted. Windfall fires the trigger.
Remaining bugs: Cast the last card in your hand and then roll back it fires the trigger, not sure if we should suppress some trigger in HumanPlaySpellAbility (forge.game.GameAction.changeZone(Zone, Zone, Card, Integer) checks static abilities.)
FAQ says "It can trigger even if a player's hand is empty momentarily during the middle of the resolution of a spell or ability.", which doesn't work in the current version.
Tethered Griffin "10/4/2004: The ability will trigger if you don't control an enchantment, even for a brief moment during the resolution of another spell or ability."
I played Thassa's Emissary and Tethered Griffin, then cast Cloudshift targeting Thassa's Emissary. This should trigger Tethered Griffin.
We shouldn't run Always triggers in checkStateEffects.
Progress: Veiled Crocodile is scripted. Windfall fires the trigger.
Remaining bugs: Cast the last card in your hand and then roll back it fires the trigger, not sure if we should suppress some trigger in HumanPlaySpellAbility (forge.game.GameAction.changeZone(Zone, Zone, Card, Integer) checks static abilities.)
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by swordshine » 25 Feb 2014, 14:05
How to add canPlayAI to hardcoded abilities? I scripted Lost in Thought and Volrath's Curse a week ago, both cannot be handled by AI.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by Max mtg » 25 Feb 2014, 14:57
@swordshine, you can not add AI specific methods to hardcoded abilities.
Game must not be aware of AI, so it's no longer possible.
Find another ways through. You may want to identify and intercept the given ability somewhere in forge-ai module.
Some rare exceptions (like Haunt) add their own API types - this seems reasonable for common ability types, like when they are keyworded.
Game must not be aware of AI, so it's no longer possible.
Find another ways through. You may want to identify and intercept the given ability somewhere in forge-ai module.
Some rare exceptions (like Haunt) add their own API types - this seems reasonable for common ability types, like when they are keyworded.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Card Development Questions
by swordshine » 26 Feb 2014, 08:18
Someone reported that Suppression Field is totally broken. It seems cost adjustment is not in the correct place. It's not able to adjust activated abilities without mana cost (and it affected replacement effects scripted starting with "AB"). We also have two cards with non-mana cost adjustment, Brutal Suppression and Drought. Maybe it's time to rework this cost adjustment method.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by swordshine » 11 Mar 2014, 09:51
Join Forces cards are popular in Commander games. I tried to script these cards using RepeatEach->ChooseNumber(the mana will be paid)->StoreSVar(UnlessCost: the chosen number and UnlessSwitched)->Join Forces effect.
Sample:
Sample:
- Code: Select all
Name:Minds Aglow
ManaCost:U
Types:Sorcery
A:SP$ RepeatEach | Cost$ U | RepeatPlayers$ Player | StartingWithActivator$ True | RepeatSubAbility$ DBPay | SubAbility$ DBDraw | StackDescription$ SpellDescription | SpellDescription$ Join forces - Starting with you, each player may pay any amount of mana. Each player draws X cards, where X is the total amount of mana paid this way.
SVar:DBPay:DB$ ChooseNumber | Defined$ Player.IsRemembered | ChooseAnyNumber$ True | SubAbility$ DBStore
SVar:DBStore:DB$ StoreSVar | SVar$ JoinForcesAmount | Type$ CountSVar | Expression$ JoinForcesAmount/Plus.X | UnlessCost$ X | UnlessPayer$ Player.IsRemembered | UnlessSwitched$ True | UnlessAI$ OnlyOwn | References$ X,JoinForcesAmount
SVar:DBDraw:DB$ Draw | Defined$ Each | NumCards$ JoinForcesAmount | SubAbility$ DBReset | References$ JoinForcesAmount | StackDescription$ None
SVar:DBReset:DB$ StoreSVar | SVar$ JoinForcesAmount | Type$ Number | Expression$ 0 | References$ JoinForcesAmount
SVar:X:Count$ChosenNumber
SVar:JoinForcesAmount:Number$0
SVar:Picture:http://www.wizards.com/global/images/magic/general/minds_aglow.jpg
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Card Development Questions
by friarsol » 11 Mar 2014, 12:22
Seems functional, but hackish. Does it work ok in practice?swordshine wrote:Join Forces cards are popular in Commander games. I tried to script these cards using RepeatEach->ChooseNumber(the mana will be paid)->StoreSVar(UnlessCost: the chosen number and UnlessSwitched)->Join Forces effect.
Sample:
Any suggestions?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Who is online
Users browsing this forum: No registered users and 39 guests