SVN Bug Reports

[friarsol]

r5369
It seems like Borderposts (and other Permanents with AltCosts) are losing the AltCost description in the CardPanel (but the Alt Cost is still available)

[Sloth]

untap 2 lands change to 3 --->YouUntapUpTo/3/Land

Name:Frantic Search
ManaCost:2 U
Types:Instant
Text:no text
A:SP$Draw | Cost$ 2 U | NumCards$ 2 | SpellDescription$ Draw two cards, then discard two cards. Untap up to three lands. | SubAbility$ SVar=DBDiscard
SVar:DBDiscard:DB$Discard | NumCards$ 2 | Mode$ TgtChoose | SubAbility$ YouUntapUpTo/3/Land
# Use old subability for untapping until AF$Untap can handle Urza block style "Free" spells
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/frantic_search.jpg
SetInfo:ULG|Common|http://magiccards.info/scans/en/ul/32.jpg
End

Fixed! Thanks jhhh.

[Jaedayr]

r5369

Code: Select all

Error - the LQ picture for fire_snake.jpg could not be found on the server

[Fnoed]

I have run a profiler on the Quest mode and the only "leakage" I can see is the card image cache getting larger. Is there a cap on how much the cache is using?

[Jaedayr]

In the newest beta, when you start a Quest in the Quest Mode, a new window appears. In the end, you've got 2 windows - one with the battle and one with the menu from which you initiated the Quest. The second window is redundant, but if you close it, the other window closes as well, forcing you to restart Forge.
Is there an easy (i.e. possible for a non-programmer) way to fix this? Don't wanna wait for the next beta, but this bug is so annoying I might have to.

r5369
I just saw this same problem. When starting a quest (i.e. Dungeon Crawling (colorless)) a second Forge application started and displayed the Quest Mode window in front of the battlefield window. Task Manager showed two Forge applications running. At the end of the quest, one of them changed to reflect my victory and one remained as it was pre-quest. However, closing one caused the other one to also close.

[Fnoed]

In the newest beta, when you start a Quest in the Quest Mode, a new window appears. In the end, you've got 2 windows - one with the battle and one with the menu from which you initiated the Quest. The second window is redundant, but if you close it, the other window closes as well, forcing you to restart Forge.
Is there an easy (i.e. possible for a non-programmer) way to fix this? Don't wanna wait for the next beta, but this bug is so annoying I might have to.

r5369
I just saw this same problem. When starting a quest (i.e. Dungeon Crawling (colorless)) a second Forge application started and displayed the Quest Mode window in front of the battlefield window. Task Manager showed two Forge applications running. At the end of the quest, one of them changed to reflect my victory and one remained as it was pre-quest. However, closing one caused the other one to also close.

Is this the new UI? If so, which window did you close that triggered the close of the other?

[Jaedayr]

No, this is the old UI. Sorry for not making that clear. I just recreated it again. The new Forge started when I entered the battlefield, but instead of showing the normal screen with the woodland background it shows the Quest Mode window where you choose opponent, enter deck builder, etc. I closed the newly opened Quest Mode window while still on the battlefield and not only did the new window close but the battlefield and rest of the application did as well.

[Fnoed]

Quest mode window bug fixed in r5379.

[Chris H.]

r5369

Code: Select all

Error - the LQ picture for fire_snake.jpg could not be found on the server

`
Fixed.

[Jaedayr]

r5412

This may be helpful or it may be useless, hopefully more of the former than the latter.

More observations on my java heap space error. I kept Task Manager up while I started Forge and played a quest match (using the new UI), went into the Deck Editor and then into the Card Shop. Available physical memory stayed in the 80m area and actually went up to around 100m as I started the second match. I got the lag but the available memory remained in the same range throughout the match. When it ended and I went back to the card editor the memory stayed the same but it took around ten seconds of 100pct CPU activity between the time I exited and the quest UI reappeared. Going from there into the deck editor the second time took a similar time and CPU usage.

When I tried to exit the deck editor I got two minutes of 100pct CPU and then the heap error. During this time the available memory stayed in the same range as earlier, and Forge as a process was not present in Task Manager. Javaw.exe was the CPU hog and only after the Forge Error window popped up did Forge reappear in Task Manager. I haven't debugged any Java, but I have debugged more mainframe software than I care to remember and my uninformed speculation is that there is a problem either shutting down the card editor portion or starting back up the quest screen.

Is there anything else I can run/debug to provide more info? I like the new UI but I just can't use it right now.

[Fnoed]

100M seems to be on the lowish side. What is the maximum heap size allocated to the JVM? What happens if you invoke the build/jar with

Code: Select all

java -Xms1000m -Xmx1000m

?
For comparison, I get 300M+ usage after playing forge for a while.

[Jaedayr]

I am using Eclipse/Subversion to grab the latest code and then I run Forge from Eclipse (Run Gui_NewGame). Where can I see maximum heap size and how can I use those parms?

[Jaedayr]

r5412

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


AbilityFactory : getAbility -- abString too short in Defense of the Heart


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: AbilityFactory : getAbility -- abString too short in Defense of the Heart
   at forge.AbilityFactory.getAbility(AbilityFactory.java:93)
   at forge.TriggerHandler.runSingleTrigger(TriggerHandler.java:199)
   at forge.TriggerHandler.runTrigger(TriggerHandler.java:158)
   at forge.PhaseUtil.handleUpkeep(PhaseUtil.java:316)
   at forge.Phase.handleBeginPhase(Phase.java:160)
   at forge.InputControl.updateInput(InputControl.java:91)
   at forge.GuiInput.update(GuiInput.java:19)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.Phase.nextPhase(Phase.java:368)
   at forge.Phase.nextPhase(Phase.java:371)
   at forge.Phase.nextPhase(Phase.java:371)
   at forge.GuiDisplay4$24.actionPerformed(GuiDisplay4.java:769)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[Fnoed]

I am using Eclipse/Subversion to grab the latest code and then I run Forge from Eclipse (Run Gui_NewGame). Where can I see maximum heap size and how can I use those parms?

Ah. That would explain the slowdown you are seeing. IIRC the default VM heap size is quite small, (128m) the cpu spike you are seeing is most likely the garbage collector trying to deallocate some memory.
I don't use Eclipse so the best I can do is point you to a website that seems to describe how to increase the heap size for apps launched in Eclipse:
http://taypworm.com/node/82

[friarsol]

Ah. That would explain the slowdown you are seeing. IIRC the default VM heap size is quite small, (128m) the cpu spike you are seeing is most likely the garbage collector trying to deallocate some memory.
I don't use Eclipse so the best I can do is point you to a website that seems to describe how to increase the heap size for apps launched in Eclipse:
http://taypworm.com/node/82

I can access that menu in my version of Eclipse in Run->Run Configurations