It is currently 09 Sep 2025, 19:58
   
Text Size

Card Contributions

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Card Contributions

Postby Zirbert » 14 Feb 2011, 03:33

friarsol wrote:One thing that Zirbert didn't specifically mention was it was oversaturated. I could buy a booster pack of FE for a buck. That and the fact that each good common appeared 4 a sheet. Homelands was far worse as far as sets go.
Quite right. I meant to cover that in point 3 and forgot all about it.

Some "inside baseball" game industry info about Fallen Empires - until around 1998, one of Canada's biggest gaming wholesalers had a standing offer: if you would take a box of FE for $50 (well below the normal wholesale price for a box of Magic), your entire order shipped free. Since shipping could easily run $30-50 per order, it was worth taking the box of FE even if you essentially gave it away. We went through a LOT of FE packs at $1 each because of taking repeated advantage of that offer.
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby Zirbert » 15 Feb 2011, 01:38

Just to call dibs / hopefully avoid duplication of effort -

I noticed that there are 12 creatures in Gatherer with the recently keyworded Bloodthirst ability, but only 2 of them are in Forge so far. I'm going to try coding up as many of the others as I can, and I'll post a zip file here ASAP.
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby Zirbert » 15 Feb 2011, 03:43

Here's the Bloodthirsty Bunch, all tested and seem to work fine:

Battering Wurm
Ghor-Clan Savage
Gristleback
Rabble-Rouser
Scab-Clan Mauler
Skarrgan Pit-Skulk
Skarrgan Skybreaker
Bonus: Bloodthirsty Ogre (nope, this one doesn't have Bloodthirst, but he came up when I did my Gatherer search, and I had him almost completely coded before I realized he doesn't use the keyword. Give me a break, he's still on theme!)

I couldn't do these three - they'll have to wait for someone smarter than me (or some more keyword coding! :-) ):

Burning-Tree Bloodscale (Neither of the activated abilities seem to be keyworded)
Petrified Wood-Kin (I don't know if Bloodthirst can be calculated, and Protection from Instants isn't keyworded)
Skarrgan Firebird (I don't know how to implement "Activate this ability only if an opponent was dealt damage this turn.")
Attachments
Bloodthirsty Bunch.zip
(3.17 KiB) Downloaded 245 times
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby Hellfish » 15 Feb 2011, 10:32

Adding the bloodthirsty bunch...

EDIT:Well, turns out slapshot already added your Battering Wurm, but now the rest are done also!Thanks!
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Card Contributions

Postby jeffwadsworth » 15 Feb 2011, 16:04

@Hellfish, did you see that issue concerning "AttackerUnblocked" trigger in SVN bug reports? I was testing Goblin Vandal and noticed it didn't trigger.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Card Contributions

Postby Hellfish » 15 Feb 2011, 20:11

No, must've missed that.. I'll take a look at it!
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Card Contributions

Postby Hellfish » 16 Feb 2011, 12:30

Fixed,there was an error in the Trigger_AttackerUnblocked class.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Card Contributions

Postby ZzzzSleep » 17 Feb 2011, 02:36

Sorry, I don't have the set info or pictures included here, but here are a couple of cards from "The Dark"

Name:Goblin Wizard
ManaCost:2 R R
Types:Creature Goblin Wizard
Text:no text
PT:1/1
A:AB$ChangeZone | Cost$ T | Origin$ Hand | Destination$ Battlefield | ChangeType$ Permanent.Goblin | ChangeNum$ 1 | SpellDescription$ You may put a Goblin permanent card from your hand onto the battlefield.
A:AB$Pump | Cost$ R | ValidTgts$ Permanent.Goblin | TgtPrompt$ Select target goblin | KW$ Protection from red | SpellDescription$ Target Goblin gains protection from red until end of turn.
SVar:Rarity:Rare
End
Name:Morale
ManaCost:1 W W
Types:Instant
Text:no text
A:SP$PumpAll | Cost$ 1 W W | ValidCards$ Creature.attacking | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Attacking creatures get +1/+1 until end of turn
SVar:RemAIDeck:True
SVar:Rarity:Common
End
Name:Orc General
ManaCost:2 R
Types:Creature Orc Warrior
Text:no text
PT:2/2
A:AB$ PumpAll | Cost$ T Sac<1/Goblin> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
A:AB$ PumpAll | Cost$ T Sac<1/Orc> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
End
Is there a neater way of doing Orc General? I wasn't sure how to put a cost of sacrifice an orc or a goblin.
ZzzzSleep
 
Posts: 182
Joined: 29 Oct 2010, 02:19
Has thanked: 18 times
Been thanked: 18 times

Re: Card Contributions

Postby slapshot5 » 17 Feb 2011, 03:15

ZzzzSleep wrote:Sorry, I don't have the set info or pictures included here, but here are a couple of cards from "The Dark"

Name:Orc General
ManaCost:2 R
Types:Creature Orc Warrior
Text:no text
PT:2/2
A:AB$ PumpAll | Cost$ T Sac<1/Goblin> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
A:AB$ PumpAll | Cost$ T Sac<1/Orc> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
End
Is there a neater way of doing Orc General? I wasn't sure how to put a cost of sacrifice an orc or a goblin.
Added Goblin Wizard (though, it's protection from white, not red) and Morale.

Not positive about Orc General. You could try:
Code: Select all
A:AB$ PumpAll | Cost$ T Sac<1/Orc,Goblin> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
The prompt may not be perfect, but there are a few that aren't, and it's a problem to tackle in the future.

Let me know what happens, and I'll add it. Love the old cards.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby Zirbert » 17 Feb 2011, 04:23

Remember that Orc General needs the "other" designation for the sacced creature, too. He can't sacrifice himself for his ability - he isn't jumping an a grenade for the team.

Glad to see more Dark cards, even though I had Goblin Wizard near the top of my own list of cards to code up in the near future - I'm always glad to be beaten to the finish line, because in the end it just means more cards for everybody!

(I only see two cards left from Arabian Nights that look like they *might* be scriptable - if I'm right, they'll be posted here ASAP....)

EDIT - Nope, no scriptable cards left in Arabian Nights, as far as I can see. If anyone can prove me wrong, please do! I thought I might be able to do Ghazban Ogre, but every card I can find that compares player life totals is hardcoded. I also thought that Jihad might be doable, but "choose a color" also seems to require hardcoding. I'll have to content myself with playing with the new "exile from graveyard as a cost" function...

-Zirbert
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby slapshot5 » 17 Feb 2011, 05:04

I was thinking, the cost may require a semicolon instead of a comma:

Code: Select all
T Sac<1/Orc;Goblin>
-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby friarsol » 17 Feb 2011, 05:11

Yea semicolons for cost since it was required for the Legendary Future Sight Creatures which have commas in the name.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby ZzzzSleep » 17 Feb 2011, 06:32

Improved Orc General.
Name:Orc General
ManaCost:2 R
Types:Creature Orc Warrior
Text:no text
PT:2/2
A:AB$ PumpAll | Cost$ T Sac<1/Goblin;Orc.Other> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
End
The prompt is ugly, but it's only one ability now.
Thanks folks!
ZzzzSleep
 
Posts: 182
Joined: 29 Oct 2010, 02:19
Has thanked: 18 times
Been thanked: 18 times

Re: Card Contributions

Postby Zirbert » 17 Feb 2011, 11:26

ZzzzSleep wrote:Improved Orc General.
Name:Orc General
ManaCost:2 R
Types:Creature Orc Warrior
Text:no text
PT:2/2
A:AB$ PumpAll | Cost$ T Sac<1/Goblin;Orc.Other> | ValidCards$ Creature.Orc+Other | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Other Orc creatures get +1/+1 until end of turn.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
End
The prompt is ugly, but it's only one ability now.
Thanks folks!
He's going to need the .Other parameter on the Goblin type as well, in case he becomes a Goblin through strange and nefarious means (think Conspiracy).
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby Chris H. » 17 Feb 2011, 12:44

. Goblin Wizard, Morale and Orc General are now in the SVN. Thank you.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 272 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 272 users online :: 0 registered, 0 hidden and 272 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 272 guests

Login Form