Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by JuzamLover » 16 Jun 2013, 15:29
Description: Playing Forge on Ubuntu-Wine. Since various previous versions, when I launch Forge it begins loading and when it reaches "Opening Main Window" the crash appears:
EDIT: Done... Removed Gauntlet saved data and it worked!!
- ConversionException | Open
EDIT: Done... Removed Gauntlet saved data and it worked!!
Last edited by JuzamLover on 17 Jun 2013, 19:04, edited 1 time in total.
Sengir Clan
The night is ours
The night is ours -
JuzamLover - Posts: 4
- Joined: 14 Mar 2011, 04:44
- Location: Madrid
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by SirFunchalot » 17 Jun 2013, 14:59
Opponent controls no creatures.
My field is an Olivia Voldaren with 1 +1/+1 counter and an Aetherling that is controlled by me via Olivia from my opponent. They activate Supreme Verdict and Aetherling is not destroyed yet goes to the opponent's side of the field. This should not happen as Aetherling's blink effect was not activated and it is still a creature on the battlefield during the resolution of Supreme Verdict and thusly should die.
My field is an Olivia Voldaren with 1 +1/+1 counter and an Aetherling that is controlled by me via Olivia from my opponent. They activate Supreme Verdict and Aetherling is not destroyed yet goes to the opponent's side of the field. This should not happen as Aetherling's blink effect was not activated and it is still a creature on the battlefield during the resolution of Supreme Verdict and thusly should die.
- SirFunchalot
- Posts: 15
- Joined: 23 Apr 2012, 02:50
- Has thanked: 3 times
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Sloth » 17 Jun 2013, 15:40
Fixed! Thanks xbon.xbon wrote:Description: Attacked with Elvish Eulogist opp had untapped Bog Rats
- NullPointerException | Open
Fixed! Thanks jsv.jsv wrote:The Infestation preconstructed deck has wrong set info (AVR in the file, should be 7ED).
Fixed! Thanks SirFunchalot.SirFunchalot wrote:Opponent controls no creatures.
My field is an Olivia Voldaren with 1 +1/+1 counter and an Aetherling that is controlled by me via Olivia from my opponent. They activate Supreme Verdict and Aetherling is not destroyed yet goes to the opponent's side of the field. This should not happen as Aetherling's blink effect was not activated and it is still a creature on the battlefield during the resolution of Supreme Verdict and thusly should die.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by friarsol » 18 Jun 2013, 02:44
Ok, I was looking through some of the AI Combat functions and noticed this, which I believe is an issue:
AiAttackController.java ll 486
this.random.setSeed(game.getPhaseHandler().getTurn() + this.randomInt);
If I'm reading this correctly it's overriding the random seed that's used everywhere in our software? (Including shuffling?) It looks like the intention is to make the attacker declarations consistent inside each turn for the AI. Can anyone confirm?
AiAttackController.java ll 486
this.random.setSeed(game.getPhaseHandler().getTurn() + this.randomInt);
If I'm reading this correctly it's overriding the random seed that's used everywhere in our software? (Including shuffling?) It looks like the intention is to make the attacker declarations consistent inside each turn for the AI. Can anyone confirm?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 18 Jun 2013, 04:42
I confirm that this code is ugly and must not alter the seed of gloabally used Random.
If the class need same results each time, let it hold an own instance of Random.
If the class need same results each time, let it hold an own instance of Random.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by jsv » 18 Jun 2013, 11:31
It seems that a wrong view is being accessed. This change:jsv wrote:I have several gauntlets in progress. No matter which one I select, when I press "Start" it's always the first one in the list that gets loaded.
- Code: Select all
--- a/src/main/java/forge/gui/home/gauntlet/CSubmenuGauntletLoad.java
+++ b/src/main/java/forge/gui/home/gauntlet/CSubmenuGauntletLoad.java
@@ -96,7 +96,7 @@ public enum CSubmenuGauntletLoad implements ICDoc {
private void startGame() {
FModel.SINGLETON_INSTANCE.setGauntletData(
- GauntletIO.loadGauntlet(VSubmenuGauntletQuick.SINGLETON_INSTANCE.getGauntletLister().getSelectedGauntletFile()));
+ GauntletIO.loadGauntlet(view.getGauntletLister().getSelectedGauntletFile()));
// Start game
SwingUtilities.invokeLater(new Runnable() {
definitely solves my problem... but it's hard for me to say what was the intention behind the original code.
Re: Bug Reports (snapshot builds)
by Max mtg » 18 Jun 2013, 11:38
@jsv, I guess the intention behind original code was to copy-paste as much as possible instead of thinking.
I've applied your patch with revision 22143. Thank you!
I've applied your patch with revision 22143. Thank you!
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by tafkad » 18 Jun 2013, 17:44
Strange bug here that freezes the game -
I went to use Liliana of the Dark Realms 2nd ability to give my Phyrexian Crusader +X/+X for a death blow but forgot the it has the Sword of Feast and Famine equipped (pro Black) so it gave me the usual Shroud Restriction? error but when I went to change to a different target (since it did not give a cancel option) I get a non valid target error on every other creature on both sides in play with no cancel option again and the game is locked - See picture for details.
Also of note minor error in the Duel description said the elf deck is Mono B Forest (see other photo)
Regards
I went to use Liliana of the Dark Realms 2nd ability to give my Phyrexian Crusader +X/+X for a death blow but forgot the it has the Sword of Feast and Famine equipped (pro Black) so it gave me the usual Shroud Restriction? error but when I went to change to a different target (since it did not give a cancel option) I get a non valid target error on every other creature on both sides in play with no cancel option again and the game is locked - See picture for details.
Also of note minor error in the Duel description said the elf deck is Mono B Forest (see other photo)
Regards
- Attachments
-
-
Re: Bug Reports (snapshot builds)
by xbon » 18 Jun 2013, 18:30
Description: Attacked with Mons's Goblin Raiders
- ConcurrentModificationException | Open
Re: Bug Reports (snapshot builds)
by timmermac » 19 Jun 2013, 12:24
Maybe a dumb question, but were those slivers unblocked?xbon wrote:Description: Attacked with Mons's Goblin RaidersAlso, Frenzy Sliver isn't working properly, from what I see, Neither my Metallic Sliver, nor my opponents Frenzy Sliver had Frenzy.
- ConcurrentModificationException | Open
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Who is online
Users browsing this forum: No registered users and 23 guests