Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by jsv » 23 Jun 2013, 06:13
R22245. AI casts Fireball on me and my 3 creatures, not doing enough damage to kill anything. There are multiple
- Code: Select all
SVar 'IncreaseCost' not found in ability, fallback to Card (Fireball). Ability is (Fireball deals X damage divided evenly, rounded down, among any number of target creatures and/or players.)
Re: Bug Reports (snapshot builds)
by Sloth » 23 Jun 2013, 09:37
Fixed! Thanks sol.friarsol wrote:r22244
Testing Shelkin Brownie and got this error:
- UnsupportedOperationException | Open
Fixed! Thanks xbon. [Note: Modular was broken]xbon wrote:Description: opponent tried to resolve Murder Investigation's effect
- NullPointerException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by xbon » 23 Jun 2013, 23:08
r22258
Nettling Imp effect continues to the next turn as well (on end step of non-active player turn, the target from previous turn is destroyed)
Nettling Imp effect continues to the next turn as well (on end step of non-active player turn, the target from previous turn is destroyed)
Re: Bug Reports (snapshot builds)
by jsv » 24 Jun 2013, 08:22
Something like this:jsv wrote:AI uses Master of the Wild Hunt to attack my Acidic Slime with his only wolf token. As the Slime has deathtouch, the token dies immediately after I allocate the first point of damage. Still, Forge waits for me to distribute remaining points, but there are no valid targets.
- Code: Select all
--- src/main/java/forge/card/cardfactory/CardFactoryCreatures.java (revision 22260)
+++ src/main/java/forge/card/cardfactory/CardFactoryCreatures.java (working copy)
@@ -193,10 +193,19 @@
}
if (target.getController().isHuman()) { // Human choose spread damage
+ final Predicate<Card> stillInPlay = new Predicate<Card>() {
+ @Override
+ public boolean apply(final Card c){
+ return c.isInPlay();
+ }
+ };
final int netAttack = target.getNetAttack();
+
for (int x = 0; x < netAttack; x++) {
+ if (!Iterables.any(wolves, stillInPlay)) break;
InputSelectCards inp = new InputSelectCardsFromList(1,1,wolves);
- inp.setMessage("Select target wolf to damage for " + getSourceCard());
+ inp.setMessage(String.format("Select target wolf to damage for %s (%d points left)",
+ getSourceCard(), netAttack - x));
Singletons.getControl().getInputQueue().setInputAndWait(inp);
inp.getSelected().get(0).addDamage(1, target);
}
Re: Bug Reports (snapshot builds)
by Sloth » 24 Jun 2013, 08:53
This is your third reasonable patch after you applied for commit rights jsv. If no one objects you will be granted commit rights tomorrow.jsv wrote:Something like this:jsv wrote:AI uses Master of the Wild Hunt to attack my Acidic Slime with his only wolf token. As the Slime has deathtouch, the token dies immediately after I allocate the first point of damage. Still, Forge waits for me to distribute remaining points, but there are no valid targets.prevents game from getting locked... but it would be better to get a damage allocation screen here. Ideally, nothing should die before all of the damage is allocated.
- | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by swordshine » 24 Jun 2013, 15:18
When I cast Control Magic,
Game-0 > java.lang.NullPointerException
at forge.game.GameAction.controllerChangeZoneCorrection(GameAction.java:442)
at forge.game.GameAction.checkStateEffects(GameAction.java:881)
at forge.game.zone.MagicStack.finishResolving(MagicStack.java:596)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:534)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:877)
at forge.game.GameAction.startGame(GameAction.java:1467)
at forge.game.Match$1.run(Match.java:105)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:722)
Game-0 > java.lang.NullPointerException
at forge.game.GameAction.controllerChangeZoneCorrection(GameAction.java:442)
at forge.game.GameAction.checkStateEffects(GameAction.java:881)
at forge.game.zone.MagicStack.finishResolving(MagicStack.java:596)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:534)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:877)
at forge.game.GameAction.startGame(GameAction.java:1467)
at forge.game.Match$1.run(Match.java:105)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:722)
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by swordshine » 24 Jun 2013, 15:28
When Cabal Therapy chooses a random card:
Description: [describe what you were doing when the crash occurred]
Description: [describe what you were doing when the crash occurred]
- IllegalStateException | Open
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by swordshine » 24 Jun 2013, 15:35
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Max mtg » 24 Jun 2013, 16:13
@swordshine, The first two fixed, the last one is strange... still thinking on how it could get updated while the game is in Main2
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by jsv » 25 Jun 2013, 07:39
Description: Quest game against Darth Vader (hard), turn 1. I've played forest, AI played plains and then an exception was triggered:
- IllegalArgumentException | Open
Re: Bug Reports (snapshot builds)
by Sloth » 25 Jun 2013, 08:06
Fixed! Thanks xbon.xbon wrote:Nettling Imp effect continues to the next turn as well (on end step of non-active player turn, the target from previous turn is destroyed)
Fixed! Thanks jsv. (and commit rights should have been granted)jsv wrote:Description: Quest game against Darth Vader (hard), turn 1. I've played forest, AI played plains and then an exception was triggered:
- IllegalArgumentException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by jsv » 26 Jun 2013, 11:40
Description: AI (The King's Contest quest challenge) activates Captain Sisay.
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by tafkad » 26 Jun 2013, 12:38
1.4.1 r22055
Trygon Predator does not trigger to destroy artifacts (not sure on enchantments most likely same)
Also Gaea's Cradle does not untap like other lands when you cancel a spell
Umezawa's Jitte does not let you cancel if you click on it during an instants phase - that one is very annoying
Trygon Predator does not trigger to destroy artifacts (not sure on enchantments most likely same)
Also Gaea's Cradle does not untap like other lands when you cancel a spell
Umezawa's Jitte does not let you cancel if you click on it during an instants phase - that one is very annoying
- Attachments
-
Who is online
Users browsing this forum: Google [Bot] and 15 guests