Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Max mtg » 07 Jul 2013, 22:59
r22486 - added game loop exit for when check for SBA leads to game loss (rules 704.5a-c)friarsol wrote:r22480
Draws don't seem to resolve properly, and don't error.
I thought I noticed another issue in the code where Game Draws weren't ignored during the games played to see if a match is over, but with this issue, I can't actually test that out.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Bundy » 08 Jul 2013, 09:23
Forge 1.4.3 - SNAPSHOT-r22476
I enchant Palaside Giant with Indestructibility. A few turns later i cast Terminus. Indestructibility stays on the battlefield still enchanting the giant on the bottom of my library.
Just to see what would happen i put the giant back into my hand with the dev panel. When i played it again Indestructibility was attached to it.
I enchant Palaside Giant with Indestructibility. A few turns later i cast Terminus. Indestructibility stays on the battlefield still enchanting the giant on the bottom of my library.
Just to see what would happen i put the giant back into my hand with the dev panel. When i played it again Indestructibility was attached to it.
Last edited by Bundy on 08 Jul 2013, 15:41, edited 1 time in total.
- Bundy
- Posts: 348
- Joined: 17 Dec 2010, 17:32
- Location: The netherlands
- Has thanked: 23 times
- Been thanked: 3 times
Re: Bug Reports (snapshot builds)
by jsv » 08 Jul 2013, 10:30
r22489. When a creature with "can block any number of creatures" (Guardian of the Gateless, Avatar of Hope) blocks, you are prompted to select damage allocation order as many times as there are attackers. Then you are asked to allocate damage as many times.
And this still happens from time to time when winning a quest match (after pressing the "Great!" button):
And this still happens from time to time when winning a quest match (after pressing the "Great!" button):
- UncheckedExecutionException | Open
Re: Bug Reports (snapshot builds)
by swordshine » 08 Jul 2013, 14:51
Effects in the command zone don't disappear at the end of turn. I've tested Zameck Guildmage.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Max mtg » 08 Jul 2013, 18:46
Ai plays Tormentor Exarch with no other creatures on board on its side:
Repro: give AI enough mana, add Tormentor Exarch to its hand.
- NullPointerException | Open
Repro: give AI enough mana, add Tormentor Exarch to its hand.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Sloth » 08 Jul 2013, 20:53
Fixed! Thanks Bundy.Bundy wrote:Forge 1.4.3 - SNAPSHOT-r22476
I enchant Palaside Giant with Indestructibility. A few turns later i cast Terminus. Indestructibility stays on the battlefield still enchanting the giant on the bottom of my library.
Just to see what would happen i put the giant back into my hand with the dev panel. When i played it again Indestructibility was attached to it.
swordshine wrote:I cast Cloudshift on a token, that token can come back from the Exile zone.
Fixed! Thanks swordshine.swordshine wrote:Effects in the command zone don't disappear at the end of turn. I've tested Zameck Guildmage.
Fixed! Thanks Max.Max mtg wrote:Ai plays Tormentor Exarch with no other creatures on board on its side:Looks like CharmAi.chooseOptionsAi has returned null
- NullPointerException | Open
Repro: give AI enough mana, add Tormentor Exarch to its hand.
There must have been a trigger causing a discard. What was it?xbon wrote:Description: Opponent attacked with 3 creatures, would've finished the game.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by swordshine » 09 Jul 2013, 00:24
r22510 "moveToLibrary now redirects to changeZone." I think Personal Tutor, Lim-Dul's Vault (ChangeZone | Origin$ Library | Destination$ Library) are broken again.
Here's my fix.
Here's my fix.
- Code: Select all
### Eclipse Workspace Patch 1.0
#P trunk
Index: src/main/java/forge/game/GameAction.java
===================================================================
--- src/main/java/forge/game/GameAction.java (revision 22514)
+++ src/main/java/forge/game/GameAction.java (working copy)
@@ -211,10 +211,6 @@
if (suppress) {
game.getTriggerHandler().suppressMode(TriggerType.ChangesZone);
}
-
- // "enter the battlefield as a copy" - apply code here
- // but how to query for input here and continue later while the callers assume synchronous result?
- zoneTo.add(copied, position);
if (zoneFrom != null) {
if (fromBattlefield && c.isCreature() && game.getCombat() != null) {
@@ -223,9 +219,16 @@
game.getCombat().removeFromCombat(c);
}
+ if (zoneFrom.is(ZoneType.Library) && zoneFrom == zoneTo && position.equals(zoneFrom.size()) && position != 0) {
+ position--;
+ }
zoneFrom.remove(c);
}
-
+
+ // "enter the battlefield as a copy" - apply code here
+ // but how to query for input here and continue later while the callers assume synchronous result?
+ zoneTo.add(copied, position);
+
// Need to apply any static effects to produce correct triggers
checkStaticAbilities();
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by xbon » 09 Jul 2013, 02:16
There must have been a trigger causing a discard. What was it?[/quote]xbon wrote:Description: Opponent attacked with 3 creatures, would've finished the game.
Sorry; I'll read through the error next time so I can know what to look for, I accidently hit the exit instead of close so i couldn't provide specifics.
Re: Bug Reports (snapshot builds)
by friarsol » 09 Jul 2013, 03:45
r22515
Are some triggers broken for anyone else? When I cast Inner-Flame Acolyte without Evoke, I target the Acolyte as it etbs but then as the trigger finishes resolving, it asks me to target again (for the same ETB ability?). This trigger never is able to leave the stack and makes the game unable to be finished.
This was working yesterday around 22488
Are some triggers broken for anyone else? When I cast Inner-Flame Acolyte without Evoke, I target the Acolyte as it etbs but then as the trigger finishes resolving, it asks me to target again (for the same ETB ability?). This trigger never is able to leave the stack and makes the game unable to be finished.
This was working yesterday around 22488
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by swordshine » 09 Jul 2013, 04:55
I think this is caused by r22513 deleting "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, true);". The default in PlayerControllerHuman is "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, false);".friarsol wrote:r22515
Are some triggers broken for anyone else? When I cast Inner-Flame Acolyte without Evoke, I target the Acolyte as it etbs but then as the trigger finishes resolving, it asks me to target again (for the same ETB ability?). This trigger never is able to leave the stack and makes the game unable to be finished.
This was working yesterday around 22488
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by jsv » 09 Jul 2013, 05:32
My conclusion as well (even if I'm a bit slow at coming to itswordshine wrote:I think this is caused by r22513 deleting "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, true);". The default in PlayerControllerHuman is "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, false);".
).Re: Bug Reports (snapshot builds)
by Max mtg » 09 Jul 2013, 05:59
Yes, that's my mistake.jsv wrote:My conclusion as well (even if I'm a bit slow at coming to itswordshine wrote:I think this is caused by r22513 deleting "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, true);". The default in PlayerControllerHuman is "HumanPlay.playSpellAbilityNoStack(getActivatingPlayer(), sa, false);".
Please see if 22518 fixes the problem.
I have added doTrigger(true, aiPlayer) to a method from PlayerControllerAI class. The returned result is not checked.
I expect tihs way AI will be able to set up ability targets when this is allowed.
As for HumanPlayer implementation, that's quite simple: the parameter is passed directly to method in HumanPlaySpellAbility
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Sloth » 09 Jul 2013, 06:29
Yes, that seems necessary. I didn't realize that changeZone had another order than moveToLibrary. Thanks swordshine.swordshine wrote:r22510 "moveToLibrary now redirects to changeZone." I think Personal Tutor, Lim-Dul's Vault (ChangeZone | Origin$ Library | Destination$ Library) are broken again.
Here's my fix.When searching a card in the library and put it on the top, the previous code will add the card on the top first and then remove it. Please review.
- Code: Select all
### Eclipse Workspace Patch 1.0
#P trunk
Index: src/main/java/forge/game/GameAction.java
===================================================================
--- src/main/java/forge/game/GameAction.java (revision 22514)
+++ src/main/java/forge/game/GameAction.java (working copy)
@@ -211,10 +211,6 @@
if (suppress) {
game.getTriggerHandler().suppressMode(TriggerType.ChangesZone);
}
-
- // "enter the battlefield as a copy" - apply code here
- // but how to query for input here and continue later while the callers assume synchronous result?
- zoneTo.add(copied, position);
if (zoneFrom != null) {
if (fromBattlefield && c.isCreature() && game.getCombat() != null) {
@@ -223,9 +219,16 @@
game.getCombat().removeFromCombat(c);
}
+ if (zoneFrom.is(ZoneType.Library) && zoneFrom == zoneTo && position.equals(zoneFrom.size()) && position != 0) {
+ position--;
+ }
zoneFrom.remove(c);
}
-
+
+ // "enter the battlefield as a copy" - apply code here
+ // but how to query for input here and continue later while the callers assume synchronous result?
+ zoneTo.add(copied, position);
+
// Need to apply any static effects to produce correct triggers
checkStaticAbilities();
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by Bundy » 09 Jul 2013, 21:53
Forge 1.4.3 - SNAPSHOT-r22500
I use Kiki-Jiki, Mirror Breaker to copy Meadowboon. When the token is sacrificed at the end of the turn, the ability of Meadowboon triggers twice.
When Meadowboon gets sacrificed for the evoke cost, when it dies or returns to my hand it only triggers once like it should.
I use Kiki-Jiki, Mirror Breaker to copy Meadowboon. When the token is sacrificed at the end of the turn, the ability of Meadowboon triggers twice.
When Meadowboon gets sacrificed for the evoke cost, when it dies or returns to my hand it only triggers once like it should.
- Bundy
- Posts: 348
- Joined: 17 Dec 2010, 17:32
- Location: The netherlands
- Has thanked: 23 times
- Been thanked: 3 times
Who is online
Users browsing this forum: No registered users and 20 guests