Bug Reports (snapshot builds)

[friarsol]

I think I just repro'd the issue of quest matches not loading all the cards. I'm not able to reproduce 100% of the time, but I got a crash and then didn't move onto a proper quest in this situation:

The problem area is in PlayArea.java in wrap() ll 343-350ish

Code: Select all

rows.add(insertIndex == -1 ? rows.size() : insertIndex, currentRow);


These were the values of the variables when I got an ArrayIndexOutOfBounds Exception, which is failed to be handled, and then (I believe) nothing is drawn

rows => ArrayList, size of 1. First Element is null.
current Row => [[Plant Wall]]
insertIndex => 0

Hopefully this will provide some extra information, and we can finally fix this strange issue.

[Max mtg]

I have commited a change that turns phaseType into an enum instead of strings. This might break something. Please do not kill me for that.

[Sloth]

I have commited a change that turns phaseType into an enum instead of strings. This might break something. Please do not kill me for that.

I think this has changed the displaying of phases (i.e. "COMBAT_DECLARE_BLOCKERS" instead of "Declare Blockers"). Was that necessary?

[Max mtg]

I think this has changed the displaying of phases (i.e. "COMBAT_DECLARE_BLOCKERS" instead of "Declare Blockers"). Was that necessary?

It's not really a problem.
Do you think that strings were better?

[friarsol]

I think this has changed the displaying of phases (i.e. "COMBAT_DECLARE_BLOCKERS" instead of "Declare Blockers"). Was that necessary?

It's not really a problem.
Do you think that strings were better?

I think displaying of Strings are better without all CAPS and Underscores for sure.

[Max mtg]

I think displaying of Strings are better without all CAPS and Underscores for sure.

Strings that were compared each time you needed to check what phase was at that moment were not good at all. Enum members are pointers that is number, much faster to compare, and also you can switch over them. This is about quality of code. Triggers need strictly typed parameters instead of maps of string to object, abilities would benefit as well.

I do some unobviuos things, but each time they lead to a greater good. The last thing being pets moved to data files.

The change you've noticed is a minor side-effect. Can you point the line of code where that caps are displayed to UI?

[Sloth]

Can you point the line of code where that caps are displayed to UI?

This line in InputPassPriority:

Code: Select all

sb.append("Phase: ").append(phase).append("\n");

[Milod]

when phantasmal image(copy fiend hunter) leaves the battelfield it doesent return the exiled creature witch i used with fiend hunters ability or do i mis somehting here?

[friarsol]

Silent Assassin description is weird. I haven't looked at the script, but it seems like it's almost listed twice.

[friarsol]

Playing the obnoxious R2D2 deck that bounces all your stuff. When the AI cast a Black Vise, I wasn't chosen as a target. Making the card pretty worthless.

[Max mtg]

This line in InputPassPriority:

Code: Select all

sb.append("Phase: ").append(phase).append("\n");

This will do the correct output:

Code: Select all

sb.append("Phase: ").append(phase.Name).append("\n");

r15054

[Milod]

when i use corrupted conscious on ai creature with sword of war and peace on it it only steals the creature and is it possible to make ai respond to stealing and re-enquip it to one of his other creatures?

[Sloth]

Issue:
I played several games with Human = Venser Duel Deck, AI = Koth Duel Deck.
Whenever AI plays Koth of the Hammer, when the spell is about to resolve, the game crashes providing following Crash Report.
This crash does only occur with Koth of the Hammer on AI's side.

Fixed! Thanks Buhmann.

Silent Assassin description is weird. I haven't looked at the script, but it seems like it's almost listed twice.
Playing the obnoxious R2D2 deck that bounces all your stuff. When the AI cast a Black Vise, I wasn't chosen as a target. Making the card pretty worthless.

Both fixed! Thanks sol.

[jwallstone]

 Shelter has the wrong casting cost: It should be 1W instead of W

[Chris H.]

 Shelter has the wrong casting cost: It should be 1W instead of W

`
Fixed, thank you jwallstone.