Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by swordshine » 16 Sep 2013, 06:55
Thanks, but if we don't have a edition file during the spoiler season, we still cannot script such cards.Max mtg wrote:I hope 23221 solves the problem for you.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Max mtg » 16 Sep 2013, 22:40
swordshine, test the same scenario with r23239 to make sure this would work in future without edition definition file.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 17 Sep 2013, 13:53
Still trying to get back into Forge after a long break...
most of the stuff works just great, and it's nice to see nifty improvements here and there. And of course even more classic old cards...
However, playtesting the current SVN with an old Quest save, I couldn't help noticing that the edition unlocking code is a total mess now. More specifically, I'm referring to getUnlockableEditions() in QuestUtilUnlockSets.java. In my old Quest game, with stone age sets, I'm given the choice to unlock Unlimited or Ice Age...or M14 or Modern Masters? Uhh, M14 and Modern Masters are a bit distant from the era I'm playing.
It seems that CardEdition hasn't got the 'index' parameter any longer? Sadly, sorting by date seems almost completely useless, as shown in the example above.
I could try and see if I can come up with a better sorting algorithm but I've been out of the loop so long that perhaps I better not...at least not until I've caught up and got a better grasp on how the current Forge works. But this really needs to be fixed. It pretty much ruins the whole unlocking idea if the offered sets are completely disjointed.
most of the stuff works just great, and it's nice to see nifty improvements here and there. And of course even more classic old cards...
However, playtesting the current SVN with an old Quest save, I couldn't help noticing that the edition unlocking code is a total mess now. More specifically, I'm referring to getUnlockableEditions() in QuestUtilUnlockSets.java. In my old Quest game, with stone age sets, I'm given the choice to unlock Unlimited or Ice Age...or M14 or Modern Masters? Uhh, M14 and Modern Masters are a bit distant from the era I'm playing.
It seems that CardEdition hasn't got the 'index' parameter any longer? Sadly, sorting by date seems almost completely useless, as shown in the example above.
I could try and see if I can come up with a better sorting algorithm but I've been out of the loop so long that perhaps I better not...at least not until I've caught up and got a better grasp on how the current Forge works. But this really needs to be fixed. It pretty much ruins the whole unlocking idea if the offered sets are completely disjointed.
Re: Bug Reports (snapshot builds)
by RumbleBBU » 18 Sep 2013, 09:17
I think I've isolated at least a part of the problem.RumbleBBU wrote:But this really needs to be fixed. It pretty much ruins the whole unlocking idea if the offered sets are completely disjointed.
When the distance in Time is greater than Integer.MAX_VALUE (2147483647), Integer.MAX_VALUE is used instead. The problem is that, except for very nearby sets, the distance will always be 2147483647, which makes comparisons pointless.
Since we do not need second-level precision here, a division by, say, 10000 could help? Trying that now.
...lo and behold, that solved the problem nicely! The unlockable sets list makes sense again.
Now, let's see if I still have my commit privs....
Re: Bug Reports (snapshot builds)
by friarsol » 18 Sep 2013, 12:23
What is distance being calculated by? Seconds? Wouldn't days make more sense? 60*60*24=86400RumbleBBU wrote:nearby sets, the distance will always be 2147483647, which makes comparisons pointless.
Since we do not need second-level precision here, a division by, say, 10000 could help? Trying that now.
...lo and behold, that solved the problem nicely! The unlockable sets list makes sense again.
Now, let's see if I still have my commit privs....
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Marek14 » 18 Sep 2013, 12:45
That's not even seconds - 2147483647 seconds would be about 68 years. It must be some smaller unit.
Re: Bug Reports (snapshot builds)
by RumbleBBU » 18 Sep 2013, 13:20
It's milliseconds, actually. Way too much granularity IMO for this purpose. 
Heck, getYear() would have been enough granularity for me, but the method seems deprecated.
Heck, getYear() would have been enough granularity for me, but the method seems deprecated.
Re: Bug Reports (snapshot builds)
by Max mtg » 18 Sep 2013, 13:42
That is milliseconds.
The really bugged line about the former code revision was
The really bugged line about the former code revision was
- Code: Select all
long distance = Integer.MAX_VALUE;
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Tets » 19 Sep 2013, 01:33
Description: When you attack with High Priest of Penance (alone or with other creatures), and the enemy has creatures to block, the game crashes most times before blockers are declared. Happend with java 1.7.0_25 and 1.7.0_40
- NullPointerException | Open
- Tets
- Posts: 5
- Joined: 19 Sep 2013, 01:24
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by friarsol » 20 Sep 2013, 03:53
r23269
Playing Theros Sealed duel. AI cast Minotaur Skullcleaver and with it's ETB on the stack, I get this error.
Looks like the only Enchantment in AIs hand is Purphoros's Emissary
Playing Theros Sealed duel. AI cast Minotaur Skullcleaver and with it's ETB on the stack, I get this error.
Looks like the only Enchantment in AIs hand is Purphoros's Emissary
- NullPointerException | Open
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by moomarc » 20 Sep 2013, 06:41
I got the same crash as Sol in the AI's main 1 when he had Heliod's Emissary in hand.
EDIT: Fixed!... but Sloth beat me to committing
EDIT: Fixed!... but Sloth beat me to committing
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Bug Reports (snapshot builds)
by friarsol » 21 Sep 2013, 13:02
You need to give more information than this. What cards were on the battlefield?twinfacer wrote:Description: At first main phase of AI. Both players uses custom decks.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Who is online
Users browsing this forum: No registered users and 40 guests