It is currently 25 Nov 2025, 09:05
   
Text Size

Card Contributions

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Re: Card Contributions

Postby friarsol » 21 Feb 2011, 16:03

jhhh,
Please be careful scripting cards.

Is there a reason why your Meditate is backwards?

Also, your Pallimud is incorrect. (It's all Lands, not just Forests) Detonate is also incorrect, it can't target Enchantments. And Sarcomancy is missing it's first TriggerDescription.

Getting the scriptable cards done is a good thing, but as I've said in this thread before, the developers shouldn't need to spend a huge amount of time editting and testing these scripted cards. They need to be tested and proofread. It's not a big deal adding a missing SVar, but rewriting half the cards that comes in is a waste of time. So please slow down a notch, and make sure what the Oracle text and the scripted card match.

Thanks
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby jhhh » 21 Feb 2011, 16:24

thanks for this corrections
errors are already correc
Code: Select all
Name:Field of Souls
ManaCost:2 W W
Types:Enchantment
Text:no text
T:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Creature.nonToken+YouOwn | Execute$ TrigToken | TriggerZones$ Battlefield | TriggerDescription$ Whenever a nontoken creature is put into your graveyard from the battlefield, put a 1/1 white Spirit creature token with flying onto the battlefield.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Spirit | TokenTypes$ Creature,Spirit | TokenOwner$ Controller | TokenColors$ White | TokenPower$ 1 | TokenToughness$ 1 | TokenKeywords$ Flying
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/tp/230.jpg
End
Name:Dregs of Sorrow
ManaCost:X 4 B
Types:Sorcery
Text:no text
A:SP$Destroy | Cost$ X 4 B | TargetMin$ X | TargetMax$ X | ValidTgts$ Creature.nonBlack | TgtPrompt$ Select target nonblack creature | SubAbility$SVar=DBDraw | SpellDescription$ Destroy X target nonblack creatures. Draw X cards.
SVar:DBDraw:DB$Draw | Defined$ You | NumCards$ X
# It may seem wrong to not use X in the target, but since the Targets are what defines X, it's redundant (and not supported by the code)
SVar:X:Targeted$Amount
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/7e/129.jpg
End
jhhh
 
Posts: 58
Joined: 15 Oct 2010, 23:40
Has thanked: 0 time
Been thanked: 0 time

Re: Card Contributions

Postby lazylockie » 21 Feb 2011, 23:30

Those are the cards I've scripted, yet I haven't tested them all, so I won't upload them yet. I'm posting them so people won't code them again:

Angelic Favor
Arrow Volley Trap
Ballista Squad
Cackling Witch
Ceremonial Guard
Charmed Griffin
Cho-Arrim Bruiser
Customs Depot
Dark Triumph
Deepwood Ghoul
Downhill Charge
Enslaved Horror
Extortion
Ferocity
Foil
Forced March
Glory of Warfare
Lacerny
Lava Runner
Liability
Mischievous Poltergeist
Mogg Alarm
Monkey Cage
Numai Outcast
Pangosaur
Pretender's Claim
Puffer Extract
Putrefaction
Ramosian Rally
Roil Elemental
Rouse
Saprazzan Bailiff
Scandalmonger
Security Detail
Silverglade Elemental
Silverglade Pathfinder
Snake Pit
Snapback
Snuff Out
Soul Spike
Squallmonger
Sunscour
Task Force
Warmonger
Warpath
Worry Beads

NOTE:I must say that the MOST boring part of coding those cards is the testing part.
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: Card Contributions

Postby ZzzzSleep » 22 Feb 2011, 03:06

Red mana creatures time!
Code: Select all
Name:Orcish Lumberjack
ManaCost:R
Types:Creature Orc
Text:no text
PT:1/1
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R R R | SpellDescription$ Add R R R to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R R G | SpellDescription$ Add R R G to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R G G | SpellDescription$ Add R G G to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ G G G | SpellDescription$ Add G G G to your mana pool.
SVar:Rarity:Common
End

Name:Goblin Clearcutter
ManaCost:3 R
Types:Creature Goblin
Text:no text
PT:3/3
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R R R | SpellDescription$ Add R R R to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R R G | SpellDescription$ Add R R G to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ R G G | SpellDescription$ Add R G G to your mana pool.
A:AB$ Mana | Cost$ Sac<1/Forest> T | Produced$ G G G | SpellDescription$ Add G G G to your mana pool.
SVar:Rarity:Uncommon
End

Name:Krark-Clan Stoker
ManaCost:2 R
Types:Creature Goblin Shaman
Text:no text
PT:2/2
A:AB$ Mana | Cost$ Sac<1/Artifact> T | Produced$ R | Amount$ 2 | SpellDescription$ Add R R to your mana pool.
SVar:Rarity:Common
End
These have all been tested, and just need the picture and set info.
ZzzzSleep
 
Posts: 182
Joined: 29 Oct 2010, 02:19
Has thanked: 18 times
Been thanked: 18 times

Re: Card Contributions

Postby lazylockie » 22 Feb 2011, 03:32

All of them tested, checked for CR/LF and also checked for RemAIDeck.

friarsol wrote:Mercadian Masques
Code: Select all
Bargaining Table
Black Market
Blood Hound
Charisma?
Credit Voucher (This may not work, but on the other hand, it might.)
Enslaved Horror
Giant Caterpillar
Honor the Fallen
Ignoble Soldier
Ley Line
Midnight Ritual
Monkey Cage
Pious Warrior
Righteous Indignation
Saber Ants
Saprazzan Bailiff
Saprazzan Outrigger
Shoving Match
Silent Assassin?
Venomous Breath (pump Cockatrice keywords?)
Worry Beads
lazylockie wrote:Those are the cards I've scripted, yet I haven't tested them all, so I won't upload them yet. I'm posting them so people won't code them again:

Angelic Favor
Arrow Volley Trap
Ballista Squad
Cackling Witch
Ceremonial Guard
Charmed Griffin
Cho-Arrim Bruiser
Customs Depot
Dark Triumph
Deepwood Ghoul
Downhill Charge
Enslaved Horror
Extortion
Ferocity
Forced March
Glory of Warfare
Lacerny
Lava Runner
Liability
Mischievous Poltergeist
Mogg Alarm
Monkey Cage
Numai Outcast
Pangosaur
Pretender's Claim
Puffer Extract
Putrefaction
Ramosian Rally
Roil Elemental
Rouse
Saprazzan Bailiff
Scandalmonger
Security Detail
Silverglade Elemental
Silverglade Pathfinder
Snake Pit
Snapback
Snuff Out
Soul Spike
Squallmonger
Sunscour
Task Force
Warmonger
Warpath

NOTE:I must say that the MOST boring part of coding those cards is the testing part.
Attachments
MMQ+free-stuff.zip
(18.94 KiB) Downloaded 398 times
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: Card Contributions

Postby Zirbert » 22 Feb 2011, 04:21

Lazylockie, I'm convinced that you're an unsleeping machine sent from the future to code Forge cards. And I for one welcome our card-scripting overlords!

You're right, testing is a drag. But, necessary. I find a bug - usually due to a typo or failure to overwrite something I copied from a source/basis card - in about a quarter of my scripted cards on the first pass. The best thing I did testingwise was to build a deck full of nothing but lands and walls. When I'm testing, I always give that deck to the AI on the first couple of passes while I test all the abilities on my new cards.

-Zirbert
Zirbert
 
Posts: 512
Joined: 13 Oct 2010, 16:04
Has thanked: 104 times
Been thanked: 19 times

Re: Card Contributions

Postby slapshot5 » 22 Feb 2011, 04:48

lazylockie wrote:All of them tested, checked for CR/LF and also checked for RemAIDeck.

friarsol wrote:Mercadian Masques
Code: Select all
Bargaining Table
Black Market
Blood Hound
Charisma?
Credit Voucher (This may not work, but on the other hand, it might.)
Enslaved Horror
Giant Caterpillar
Honor the Fallen
Ignoble Soldier
Ley Line
Midnight Ritual
Monkey Cage
Pious Warrior
Righteous Indignation
Saber Ants
Saprazzan Bailiff
Saprazzan Outrigger
Shoving Match
Silent Assassin?
Venomous Breath (pump Cockatrice keywords?)
Worry Beads
lazylockie wrote:Those are the cards I've scripted, yet I haven't tested them all, so I won't upload them yet. I'm posting them so people won't code them again:

Angelic Favor
Arrow Volley Trap
Ballista Squad
Cackling Witch
Ceremonial Guard
Charmed Griffin
Cho-Arrim Bruiser
Customs Depot
Dark Triumph
Deepwood Ghoul
Downhill Charge
Enslaved Horror
Extortion
Ferocity
Forced March
Glory of Warfare
Lacerny
Lava Runner
Liability
Mischievous Poltergeist
Mogg Alarm
Monkey Cage
Numai Outcast
Pangosaur
Pretender's Claim
Puffer Extract
Putrefaction
Ramosian Rally
Roil Elemental
Rouse
Saprazzan Bailiff
Scandalmonger
Security Detail
Silverglade Elemental
Silverglade Pathfinder
Snake Pit
Snapback
Snuff Out
Soul Spike
Squallmonger
Sunscour
Task Force
Warmonger
Warpath

NOTE:I must say that the MOST boring part of coding those cards is the testing part.
These are all added with some minor tweaks.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby ZzzzSleep » 22 Feb 2011, 04:49

ZzzzSleep wrote:Red mana creatures time!
Name:Orcish Lumberjack
Name:Goblin Clearcutter
Name:Krark-Clan Stoker

These have all been tested, and just need the picture and set info.
Should these have SVar:RemAIDeck:True, since the AI doesn't use their mana abilities?
ZzzzSleep
 
Posts: 182
Joined: 29 Oct 2010, 02:19
Has thanked: 18 times
Been thanked: 18 times

Re: Card Contributions

Postby slapshot5 » 22 Feb 2011, 05:40

ZzzzSleep wrote:
ZzzzSleep wrote:Red mana creatures time!
Name:Orcish Lumberjack
Name:Goblin Clearcutter
Name:Krark-Clan Stoker

These have all been tested, and just need the picture and set info.
Should these have SVar:RemAIDeck:True, since the AI doesn't use their mana abilities?
Yep. Added and Added.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby slapshot5 » 22 Feb 2011, 05:59

jhhh wrote:thanks for this corrections
errors are already correc
Code: Select all
Name:Field of Souls
ManaCost:2 W W
Types:Enchantment
Text:no text
T:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Creature.nonToken+YouOwn | Execute$ TrigToken | TriggerZones$ Battlefield | TriggerDescription$ Whenever a nontoken creature is put into your graveyard from the battlefield, put a 1/1 white Spirit creature token with flying onto the battlefield.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Spirit | TokenTypes$ Creature,Spirit | TokenOwner$ Controller | TokenColors$ White | TokenPower$ 1 | TokenToughness$ 1 | TokenKeywords$ Flying
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/tp/230.jpg
End
Name:Dregs of Sorrow
ManaCost:X 4 B
Types:Sorcery
Text:no text
A:SP$Destroy | Cost$ X 4 B | TargetMin$ X | TargetMax$ X | ValidTgts$ Creature.nonBlack | TgtPrompt$ Select target nonblack creature | SubAbility$SVar=DBDraw | SpellDescription$ Destroy X target nonblack creatures. Draw X cards.
SVar:DBDraw:DB$Draw | Defined$ You | NumCards$ X
# It may seem wrong to not use X in the target, but since the Targets are what defines X, it's redundant (and not supported by the code)
SVar:X:Targeted$Amount
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/7e/129.jpg
End
I'll submit Field of Souls , but Dregs of Sorrow did not work for me (didn't prompt for targets, and destroyed 0 creatures and drew 0 cards).

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby slapshot5 » 22 Feb 2011, 06:02

lazylockie wrote:All of them tested, checked for CR/LF and also checked for RemAIDeck.

friarsol wrote:Mercadian Masques
Code: Select all
Bargaining Table
Black Market
Blood Hound
Charisma?
Credit Voucher (This may not work, but on the other hand, it might.)
Enslaved Horror
Giant Caterpillar
Honor the Fallen
Ignoble Soldier
Ley Line
Midnight Ritual
Monkey Cage
Pious Warrior
Righteous Indignation
Saber Ants
Saprazzan Bailiff
Saprazzan Outrigger
Shoving Match
Silent Assassin?
Venomous Breath (pump Cockatrice keywords?)
Worry Beads
lazylockie wrote:Those are the cards I've scripted, yet I haven't tested them all, so I won't upload them yet. I'm posting them so people won't code them again:

Angelic Favor
Arrow Volley Trap
Ballista Squad
Cackling Witch
Ceremonial Guard
Charmed Griffin
Cho-Arrim Bruiser
Customs Depot
Dark Triumph
Deepwood Ghoul
Downhill Charge
Enslaved Horror
Extortion
Ferocity
Forced March
Glory of Warfare
Lacerny
Lava Runner
Liability
Mischievous Poltergeist
Mogg Alarm
Monkey Cage
Numai Outcast
Pangosaur
Pretender's Claim
Puffer Extract
Putrefaction
Ramosian Rally
Roil Elemental
Rouse
Saprazzan Bailiff
Scandalmonger
Security Detail
Silverglade Elemental
Silverglade Pathfinder
Snake Pit
Snapback
Snuff Out
Soul Spike
Squallmonger
Sunscour
Task Force
Warmonger
Warpath

NOTE:I must say that the MOST boring part of coding those cards is the testing part.
I still had problems with newlines for Glory of Warfare, Silverglade Elemental, and Snuff Out.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby jhhh » 22 Feb 2011, 13:00

Name:Segmented Wurm
ManaCost:3 R G
Types:Creature Wurm
Text:no text
PT:5/5
T:Mode$ SpellAbilityCast | TargetsValid$ Card.Self | TriggerZones$ Battlefield | Execute$ TrigCounter | TriggerDescription$ Whenever CARDNAME becomes the target of a spell or ability, put a -1/-1 counter on it.
SVar:TrigCounter:AB$PutCounter | Cost$ 0 | Defined$ Self | CounterType$ M1M1 | CounterNum$ 1
SVar:Rarity:Uncommon
SVar:Picture:http://magiccards.info/scans/en/bd/68.jpg
End
Name:Skyshroud Ranger
ManaCost:G
Types:Creature Elf
Text:no text
PT:1/1
A:AB$ChangeZone | Cost$ T | Origin$ Hand | Destination$ Battlefield | ChangeType$ Land | ChangeNum$ 1| SorcerySpeed$ True | Optional$ True | SpellDescription$ You may put a land card from your hand onto the battlefield.
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/10e/297.jpg
End
jhhh
 
Posts: 58
Joined: 15 Oct 2010, 23:40
Has thanked: 0 time
Been thanked: 0 time

Re: Card Contributions

Postby lazylockie » 22 Feb 2011, 13:54

Zirbert wrote:Lazylockie, I'm convinced that you're an unsleeping machine sent from the future to code Forge cards. And I for one welcome our card-scripting overlords!

You're right, testing is a drag. But, necessary. I find a bug - usually due to a typo or failure to overwrite something I copied from a source/basis card - in about a quarter of my scripted cards on the first pass. The best thing I did testingwise was to build a deck full of nothing but lands and walls. When I'm testing, I always give that deck to the AI on the first couple of passes while I test all the abilities on my new cards.

-Zirbert
Haha thanks Zirbert! Most of those cards show up like a chain: Suddenly I realized Ramosian Rally was scriptable then I searched on magiccards for all similar cards (cards with "rather than pay").

Right now I'm testing giving both me and AI a deck with the card I'm testing and other cards that will help the "environment". Say I wanna test Angelic Favor, I put 4 Memnite 1 Plains and 1 Angelic Favor. Although your Land+Wall deck is actually interesting to test other stuff I have in mind!
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: Card Contributions

Postby friarsol » 22 Feb 2011, 14:35

slapshot5 wrote:
jhhh wrote:
Code: Select all
Name:Dregs of Sorrow
ManaCost:X 4 B
Types:Sorcery
Text:no text
A:SP$Destroy | Cost$ X 4 B | TargetMin$ X | TargetMax$ X | ValidTgts$ Creature.nonBlack | TgtPrompt$ Select target nonblack creature | SubAbility$SVar=DBDraw | SpellDescription$ Destroy X target nonblack creatures. Draw X cards.
SVar:DBDraw:DB$Draw | Defined$ You | NumCards$ X
# It may seem wrong to not use X in the target, but since the Targets are what defines X, it's redundant (and not supported by the code)
SVar:X:Targeted$Amount
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/7e/129.jpg
End
I'll submit Field of Souls , but Dregs of Sorrow did not work for me (didn't prompt for targets, and destroyed 0 creatures and drew 0 cards).
Dregs of Sorrow is incorrect. Take a look at Volcanic Eruption on how the setting of Target variables works for this case.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby slapshot5 » 22 Feb 2011, 15:58

jhhh wrote:
Code: Select all
Name:Meditate
ManaCost:2 U
Types:Instant
Text:no text
A:SP$AddTurn | Cost$ 2 U | Defined$ Opponent  | NumTurns$ 1 | SpellDescription$ Draw four cards. You skip your next turn. | SubAbility$ SVar=DBDraw
SVar:DBDraw:DB$Draw | NumCards$ 4 | Defined$ You
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/tp/76.jpg
End

Name:Flooded Shoreline
ManaCost:U U
Types:Enchantment
Text:no text
A:AB$ChangeZone | Cost$ U U Return<2/Island> | ValidTgts$ Creature | TgtPrompt$ Select target creauture | Origin$ Battlefield | Destination$ Hand | SpellDescription$ Return target creature to its owner's hand.
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/vi/32.jpg
End
Name:Pallimud
ManaCost:2 R
Types:Creature  Beast
Text:As Pallimud enters the battlefield, choose an opponent.
PT:*/3
K:stSetPT:Count$Valid Land.tapped+YouDontCtrl:3:Pallimud's power is equal to the number of tapped lands the chosen player controls.
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/tp/195.jpg
End
Name:Worthy Cause
ManaCost:W
Types:Instant
Text:no text
A:SP$GainLife | Cost$ W Sac<1/Creature> | LifeAmount$ X | SpellDescription$ You gain life equal to the sacrificed creature's toughness.
SVar:X:Sacrificed$CardToughness
SVar:Buyback:2
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/tp/265.jpg
End
Name:Detonate
ManaCost:X R
Types:Sorcery
Text:no text
A:SP$Destroy | Cost$ X R | ValidTgts$ Artifact | TgtPrompt$ Select target artifact| ValidTgts$ Artifact | SubAbility$ DamageTgtCtrlr/X | NoRegen$ True | SpellDescription$ Destroy target artifact with converted mana cost X. It can't be regenerated. CARDNAME deals X damage to that artifact's controller.
SVar:X:Targeted$CardManaCost
SVar:Rarity:Uncommon
SVar:Picture:http://magiccards.info/scans/en/mi/88.jpg
End
Name:Sarcomancy
ManaCost:B
Types:Enchantment
Text:no text
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigToken | TriggerDescription$ At the beginning of your upkeep, if there are no Zombies on the battlefield, Sarcomancy deals 1 damage to you.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Zombie | TokenTypes$ Creature,Zombie | TokenOwner$ Controller | TokenColors$ Black | TokenPower$ 2 | TokenToughness$ 2
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | IsPresent$ Card.Zombie | PresentCompare$ LE0 |TriggerZones$ Battlefield | Execute$ TrigDamage | TriggerDescription$ At the beginning of your upkeep, if there are no Zombies on the battlefield, Sarcomancy deals 1 damage to you.
SVar:TrigDamage:AB$DealDamage | Cost$ R |  Defined$ You | NumDmg$ 1
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/tp/48.jpg
End
Name:Telethopter
ManaCost:4
Types:Artifact Creature  Thopter
Text:no text
PT:3/1
A:AB$Pump | Cost$ Cost$ tapXType<1/Creature> | KW$ Flying | SpellDescription$ CARDNAME gains flying until end of turn.
SVar:Rarity:Common
SVar:Picture:http://magiccards.info/scans/en/tp/301.jpg
End
Meditate and Flooded Shoreline are now tweaked and added.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 25 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 25 users online :: 0 registered, 0 hidden and 25 guests (based on users active over the past 10 minutes)
Most users ever online was 9824 on 10 Nov 2025, 04:33

Users browsing this forum: No registered users and 25 guests

Login Form