General UI support

[Chris H.]

While play testing today's snapshot build I noticed an interesting icon displayed for one of the quest opponents:
 

[friarsol]

While play testing today's snapshot build I noticed an interesting icon displayed for one of the quest opponents:
 

That's the icon that shows up if you don't have the actual Icon. My screen was full of them when main.properties was switched.

[Chris H.]

While play testing today's snapshot build I noticed an interesting icon displayed for one of the quest opponents:
 

That's the icon that shows up if you don't have the actual Icon. My screen was full of them when main.properties was switched.

 
Yeah, on closer examination the Cave Troll 3 deck is setting the icon to "Cave Troll.jpg".

The questAIicons.txt file does not have an entry for this icon.

There is an entry for a "Bridge Troll.jpg" though and it looks like there is a Bridge Troll.jpg file.

There is a Bridge Troll 3 deck and it looks similar to the Cave Troll 3 deck. There appears to be a few minor differences between these two decks.

Bridge Troll 3 | Open

[duel]
[metadata]
Name=Bridge Troll 3
Title=Bridge Troll
Difficulty=hard
Description=Mono B Quest for the Nihil Stone deck with The Rack and Bottomless Pit
Icon=Bridge Troll.jpg
Deck Type=constructed
[main]
2 Go for the Throat|MBS
1 Chainer's Edict|TOR
3 Null Brooch|EXO
3 Ravenous Rats|10E
2 Executioner's Capsule|ALA
4 Quicksand|WWK
1 Liliana Vess|M11
3 The Rack|TSB
1 Stupor|TSB
3 Will-o'-the-Wisp
1 Disfigure|ZEN
1 Doom Blade|M11
4 Ensnaring Bridge|8ED
19 Swamp|MBS
4 Bottomless Pit|STH
1 Hymn to Tourach|FEM
2 Inquisition of Kozilek|ROE
1 Grasp of Darkness|SOM
1 Guiltfeeder|JUD
3 Quest for the Nihil Stone|WWK
[sideboard]

 

Cave Troll 3 | Open

[duel]
[metadata]
Name=Cave Troll 3
Title=Cave Troll
Difficulty=hard
Description=Mono B Quest for the Nihil Stone deck with The Rack, Bottomless Pit and Nyxathid
Icon=Cave Troll.jpg
Deck Type=constructed
[main]
2 Chainer's Edict|TOR
2 Go for the Throat|MBS
3 Ravenous Rats|10E
3 Null Brooch|EXO
4 Nyxathid|CFX
2 Executioner's Capsule|ALA
4 Quicksand|WWK
1 Liliana Vess|M11
3 The Rack|TSB
3 Guul Draz Specter|ZEN
19 Swamp|MBS
3 Bottomless Pit|STH
2 Hymn to Tourach|FEM
2 Inquisition of Kozilek|ROE
2 Grasp of Darkness|SOM
2 Cunning Lethemancer|ALA
3 Quest for the Nihil Stone|WWK
[sideboard]

[Doublestrike]

While play testing today's snapshot build I noticed an interesting icon displayed for one of the quest opponents:
 

The sprite updates I made for the deck editor (accidentally) sliced out the "unknown" icon, which is usually at those coordinates. On the list. (I sound like a broken record)

[Doublestrike]

The card shop table which displays the card catalog does not provide the card/pack names. Instead, I see the numbers "1" or "5" or "10".

That's the rendering bug I was talking about. A JTable has two sets of column indexes; the view and the model. They can get out of sync pretty easily and so the renderer for column 2 in the model will render column 2 in the view, which may not be the same. :/ Not too hard to fix though.

EDIT: Looks like friarsol is having this same issue too. I think this fixes it, but I don't want to break something you're still working on Doublestrike.

BTW Durandal (and anyone else) I'm not (and won't be) working on anything huge for a while. Feel free to tinker with anything in the UI, it's fair game and needs a lot of small tweaks. Nothing big in the pipes.

[Corwin72]

forge-1.2.8-20120523.105502-18
If I start a new quest.
then go to the store and sell a card and then try to close the store screen I get this crash:

Code: Select all

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
   http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

null


Version:
Forge version 1.2.8-SNAPSHOT-r15616

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.7.0_04 Vendor: Oracle Corporation

Detailed error trace:
java.lang.NullPointerException
   at forge.gui.deckeditor.SEditorIO.confirmSaveChanges(SEditorIO.java:148)
   at forge.gui.deckeditor.controllers.CEditorQuestCardShop.exit(CEditorQuestCardShop.java:360)
   at forge.control.FControl$4.windowClosing(FControl.java:128)
   at java.awt.Window.processWindowEvent(Unknown Source)
   at javax.swing.JFrame.processWindowEvent(Unknown Source)
   at java.awt.Window.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[ArsenalNut]

There is bug where the deck editor panel is left up when a constructed match is started after the deck editor has been opened twice. Here's the sequence to reproduces the bug.
1) Open deck editor
2) Close deck editor by clicking X
3) Start a constructed game
4) Quit out of constructed game
5) repeat 1 and 2
6) Start another constructed game. The deck editor is left up in front of the game panels.

[Doublestrike]

Thanks ArsenalNut - should be fixed.

The wrong-coordinate-icon thing discussed a few posts up is also fixed.

[Chris H.]

I updated to rev 15682 and did a simple launch and then quit the forge app. Got the following crash report:

Crash Report | Open

Code: Select all

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
   http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

null


Version:
Forge version SVN

OS: Mac OS X Version: 10.7.4 Architecture: x86_64

Java Version: 1.6.0_31 Vendor: Apple Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.gui.home.VMainMenu$2.execute(VMainMenu.java:217)
   at forge.gui.toolbox.FLabel$3.mouseClicked(FLabel.java:234)
   at java.awt.Component.processMouseEvent(Component.java:6378)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
   at java.awt.Component.processEvent(Component.java:6140)
   at java.awt.Container.processEvent(Container.java:2083)
   at java.awt.Component.dispatchEventImpl(Component.java:4737)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Component.dispatchEvent(Component.java:4565)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4289)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210)
   at java.awt.Container.dispatchEventImpl(Container.java:2127)
   at java.awt.Window.dispatchEventImpl(Window.java:2482)
   at java.awt.Component.dispatchEvent(Component.java:4565)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:684)
   at java.awt.EventQueue.access$000(EventQueue.java:85)
   at java.awt.EventQueue$1.run(EventQueue.java:643)
   at java.awt.EventQueue$1.run(EventQueue.java:641)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
   at java.awt.EventQueue$2.run(EventQueue.java:657)
   at java.awt.EventQueue$2.run(EventQueue.java:655)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:654)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


[Doublestrike]

Mmmm...can't repro that...any other details?

And maybe a way to select which columns to display, so I can hide ones that I don't want.

Just noticed this sol, this was/is actually already in place in the "preferences" tab.

[Chris H.]

Mmmm...can't repro that...any other details?

 
I ran a test where I launched, started a match and forfeited it and then exited forge and got the same error message.

I will of ahead and do a snapshot build and release. It might help to have other people try this out and see what happens on their computer.


EDIT:

It appears that only the Exit Forge button causes this crash report and the other buttons in the home view work correctly.

[Doublestrike]

OK Chris that's helpful. Unfortunately I just updated the wrong SVN client and now I have to do the one in Eclipse, and find the dependencies etc. Grrrr...sets me back.

===

When going from a Quest without a Pet, to one that has one I have to restart Forge for the Pet drop-down to appear.

Guessing this is a UI bug, not sure: If you mash the okay button repeatedly when you win in quest mode you are given the rewards multiple times.

These should be fixed now.

On the End Match screen (the one that shows booster prizes and ante) if you close via the X button instead of the Quit button the game flips out a bit and replays the end game mode.

overlay freezes with x button

@Sol - couldn't repro that quickly, but I did just fix a possibly related problem. Could you let me know if the thing you are talking about is still happening?

[Doublestrike]

It appears that only the Exit Forge button causes this crash report and the other buttons in the home view work correctly.

Fixed.

The dev mode tab is still available with all buttons functional even if dev mode isn't selected.

Fixed.

I get a crash upon exiting the shop using the new deck editor UI (which looks awesome btw)

Thanks and fixed. Turns out your fix was indeed correct. The card shop has some other big issues though

Could you please add back the name and type filters that only filter on their respective fields?

Yep - done.

When a spell or ability hits the stack during combat, the combat panel will not switch to the stack panel (if they share the same panel). This makes it easy to miss important stuff.

Also done.

[Doublestrike]

After updating card prices and pressing 'Done' the UI locks up. You can't close Forge without terminating the launch from Eclipse

Fixed.

Could you make the Log (both the in-game log and the the end-game log) easier to read by giving the messages different background colors similar to how it's
done on the stack?

Sure can, great idea. Done.

In the Message Report, perhaps in parenthesis on the Player line next to Human/Computer, could you put the current turn number?

Another great idea. Also done.

Quest mode Card Shop seems to have confusing tab data. Card Catalog should probably be more like "Card Shop" and "Current Deck" should probably be "Card Pool" or some such.

Done.

Also, it appears we've also lost the "Deck" Column in Quest mode which was extremely useful.

Not sure what you mean - this is in the card shop, and it looks like everything is hooked up correctly. I'm not sure what this column does so if it's still broken, could someone tell me what's supposed to be happening there.

[friarsol]

Also, it appears we've also lost the "Deck" Column in Quest mode which was extremely useful.

Not sure what you mean - this is in the card shop, and it looks like everything is hooked up correctly. I'm not sure what this column does so if it's still broken, could someone tell me what's supposed to be happening there.

I definitely don't see the Deck column in Quest Mode. Do you? The column informs you which cards in your card pool are actually assigned to decks. So I can quickly sort by Deck and sell cards I don't have in a deck.