Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Devilman06 » 23 Feb 2014, 16:35
- Devilman06
- Posts: 127
- Joined: 29 Jan 2010, 03:59
- Has thanked: 1 time
- Been thanked: 2 times
Re: Bug Reports (snapshot builds)
by Agetian » 23 Feb 2014, 19:43
r24954: The amount of cards playable from the exile zone (at least when dealing with cards exiled with Nightveil Specter) is not displayed correctly on the "Flashback" icon. For instance, Nightveil Specter might have exiled 2 cards over two turns but the number displayed on the play-with-flashback icon might be 0 or 1.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by xbon » 24 Feb 2014, 22:22
If remove artifacts is not selected, artifacts are removed from generated decks, and vice versa. latest snapshot.
Description: as game was ending. my life hit 0.
Description: as game was ending. my life hit 0.
- ConcurrentModificationException | Open
Re: Bug Reports (snapshot builds)
by friarsol » 27 Feb 2014, 01:16
r24995
Knollspine Invocation appears to be broken. When clicking on it nothing seems to actually happen.
Edit:
Collective Restraint gives me the above crash when attacking into it. Looks like this may be all Propaganda-like effects, since for some reason it's getting into HumanPlay.payManaCost() with a null SpellAbility which seems like it's completely incompatible with this function. I started adding null checks, but it was basically every step of the function and then got a bit further and it looks like not having an ability here causes bad things with actual payment, so maybe whoever consolidated all this can figure out how to get Propaganda stuff to work.
Knollspine Invocation appears to be broken. When clicking on it nothing seems to actually happen.
Edit:
Collective Restraint gives me the above crash when attacking into it. Looks like this may be all Propaganda-like effects, since for some reason it's getting into HumanPlay.payManaCost() with a null SpellAbility which seems like it's completely incompatible with this function. I started adding null checks, but it was basically every step of the function and then got a bit further and it looks like not having an ability here causes bad things with actual payment, so maybe whoever consolidated all this can figure out how to get Propaganda stuff to work.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by swordshine » 27 Feb 2014, 10:16
When I cast Chord of Calling while controlling no untapped creatures.
- Code: Select all
java.lang.IllegalArgumentException: Min must not be greater than Max
at forge.gui.input.InputSelectManyBase.<init>(InputSelectManyBase.java:26)
at forge.gui.input.InputSelectCardsForConvoke.<init>(InputSelectCardsForConvoke.java:29)
at forge.gui.player.PlayerControllerHuman.chooseCardsForConvoke(PlayerControllerHuman.java:1075)
at forge.game.mana.ManaCostAdjustment.adjustCostByConvoke(ManaCostAdjustment.java:138)
at forge.game.mana.ManaCostAdjustment.adjust(ManaCostAdjustment.java:51)
at forge.gui.player.HumanPlay.payManaCost(HumanPlay.java:707)
at forge.gui.player.PlayerControllerHuman.payManaCost(PlayerControllerHuman.java:1070)
at forge.game.player.PlayerController.payManaCost(PlayerController.java:226)
at forge.game.cost.CostPartMana.payAsDecided(CostPartMana.java:131)
at forge.game.cost.CostPayment.payCost(CostPayment.java:138)
at forge.gui.player.HumanPlaySpellAbility.playAbility(HumanPlaySpellAbility.java:94)
at forge.gui.player.HumanPlay.playSpellAbility(HumanPlay.java:97)
at forge.gui.player.PlayerControllerHuman.playChosenSpellAbility(PlayerControllerHuman.java:678)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:968)
at forge.game.GameAction.startGame(GameAction.java:1537)
at forge.game.Match.startGame(Match.java:80)
at forge.control.FControl$4.run(FControl.java:437)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Sloth » 27 Feb 2014, 13:08
Looks like r24885 redirected payCostDuringAbilityResolve to this payManaCost function. So Max is responsible.friarsol wrote:
Collective Restraint gives me the above crash when attacking into it. Looks like this may be all Propaganda-like effects, since for some reason it's getting into HumanPlay.payManaCost() with a null SpellAbility which seems like it's completely incompatible with this function. I started adding null checks, but it was basically every step of the function and then got a bit further and it looks like not having an ability here causes bad things with actual payment, so maybe whoever consolidated all this can figure out how to get Propaganda stuff to work.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by friarsol » 05 Mar 2014, 03:55
Ok, well, it looks like Max disappeared on us. I've committed a short term fix that passes a dummy SpellAbility in here so there aren't any failed SA checks.Sloth wrote:Looks like r24885 redirected payCostDuringAbilityResolve to this payManaCost function. So Max is responsible.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 05 Mar 2014, 17:34
Not bad, Sol.
Though I'll insert there an instance of special EmptySa class (it's nested in spellability)
Though I'll insert there an instance of special EmptySa class (it's nested in spellability)
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by swordshine » 06 Mar 2014, 00:57
Any idea to fix another related bug (Suppression Field)? http://www.slightlymagic.net/forum/viewtopic.php?f=26&t=13834&start=45#p147332Max mtg wrote:Not bad, Sol.
Though I'll insert there an instance of special EmptySa class (it's nested in spellability)
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by friarsol » 14 Mar 2014, 02:26
r25175
I noticed some weird things going on related with Morph.
Firstly, at the end of my quest match, when looking through the booster I won, all of the cards were just listed as Morph, even though they obviously weren't (especially since it wasn't inside a match.
http://imgur.com/3dbRF31
Secondly, I just stole a Morph creature from my opponent, and there's barely any space to actually flip it in the card detail panel to see what's on the other side. http://imgur.com/KMMLOut Additionally, it doesn't even list the power/toughness anywhere, which is odd.
The AIs Morph creatures display normally.
I noticed some weird things going on related with Morph.
Firstly, at the end of my quest match, when looking through the booster I won, all of the cards were just listed as Morph, even though they obviously weren't (especially since it wasn't inside a match.
http://imgur.com/3dbRF31
Secondly, I just stole a Morph creature from my opponent, and there's barely any space to actually flip it in the card detail panel to see what's on the other side. http://imgur.com/KMMLOut Additionally, it doesn't even list the power/toughness anywhere, which is odd.
The AIs Morph creatures display normally.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by swordshine » 14 Mar 2014, 04:20
@drdev, r25173 broke some effects, my Tezzeret, Agent of Bolas digged 5 cards and they showed Morph in card detail panel. We will release a new beta in a few hours, please revert it if you're not sure how to fix this bug.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by friarsol » 14 Mar 2014, 12:50
I've reverted this change, since as swordshine states, we have a release and there are plenty of reasons why users should be able to see cards (peeking, end of game, etc) that this change needs to consider.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by drdev » 14 Mar 2014, 13:32
I do apologize for this. I did test main Forge and I thought it was working fine. I just missed some of the cases mentioned.friarsol wrote:I've reverted this change, since as swordshine states, we have a release and there are plenty of reasons why users should be able to see cards (peeking, end of game, etc) that this change needs to consider.
I think the only bug in my logic was to return false if the card wasn't in a zone. I think if I had returned true there instead, the logic would work as expected. I'll revisit that fix after the release so we have time to iron out any kinks.
It sounds like the logic is flawed in other ways, as canBeShown(player) returning false shouldn't in and of itself imply a Morph creature. Cards can be face down in zones besides the Battlefield, like the Exile zone, and that doesn't mean they're morph cards. Until mobile Forge, we've just never displayed cards in zones besides the Hand and Battlefield, as other zones are shown as simple list box popups.
EDIT: I think I've fixed everything now in r25183, although I did have to use a mini-hack to handle revealed cards. I made it so FControl.mayShowCard returns true if a dialog is open, which handles all those corner cases.
Please help me test this to make sure I didn't miss any corner cases. Thanks.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by Madscorpion » 16 Mar 2014, 04:15
Description: [describe what you were doing when the crash occurred]
I was trying to make my very first EDH deck in the commander editor tab when I noticed that one of my right window was a bit out of the screen and I was wondering If I was missing any windows to be able to edit more of my commander deck and so I searched for a scroll bar at the bottom of my screen and there was nothing so I tried to stretch my window to check if the page wasn't just sized out and the window's side just stretched with the dragging and window just stretched down the middle and the side never showed. Then after stretching it a lot just to make sure it would not show its side I started to change the positions of my windows so as to make them all vertical and not stretching to the right infinitely and when I got to my last window it all crashed on me and here we are. I tried to full screen it a few times to see if it would just refresh on its own and I tried closing and opening the commander tab again.
I hope this helps because I don't think ill be able to play forge if my tab stays like this. Now I know for sure I'm missing most of my tabs because of it and cant get em back ha ha.
Really like everything else tho, seemed to work just fine!
Oh and uhm I was actualy searching for some kind of Commander zone option in the commander deck editor when I had this whole mess of a problem. I figured I couldn't play my deck because my commander was still just in my 'creature' tab in the current deck window and that I probably had to put him somewhere else and I could not find where that was..
- IllegalArgumentException | Open
I was trying to make my very first EDH deck in the commander editor tab when I noticed that one of my right window was a bit out of the screen and I was wondering If I was missing any windows to be able to edit more of my commander deck and so I searched for a scroll bar at the bottom of my screen and there was nothing so I tried to stretch my window to check if the page wasn't just sized out and the window's side just stretched with the dragging and window just stretched down the middle and the side never showed. Then after stretching it a lot just to make sure it would not show its side I started to change the positions of my windows so as to make them all vertical and not stretching to the right infinitely and when I got to my last window it all crashed on me and here we are. I tried to full screen it a few times to see if it would just refresh on its own and I tried closing and opening the commander tab again.
I hope this helps because I don't think ill be able to play forge if my tab stays like this. Now I know for sure I'm missing most of my tabs because of it and cant get em back ha ha.
Really like everything else tho, seemed to work just fine!
Oh and uhm I was actualy searching for some kind of Commander zone option in the commander deck editor when I had this whole mess of a problem. I figured I couldn't play my deck because my commander was still just in my 'creature' tab in the current deck window and that I probably had to put him somewhere else and I could not find where that was..
- Madscorpion
- Posts: 1
- Joined: 15 Mar 2014, 20:14
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by swordshine » 16 Mar 2014, 09:27
@drdev, it seems in developer mode face-down cards can be seen and those cards are not marked "face down" in the card detail panel.
I fixed an old bug about Necropotence and now I'm confused whether the exiled cards are faced-down.
I fixed an old bug about Necropotence and now I'm confused whether the exiled cards are faced-down.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Who is online
Users browsing this forum: No registered users and 52 guests