Card Development Questions

[jeffwadsworth]

Hellfish wrote:

No issue with the script, the trigger class was assuming that all SpellAbilities have Target objects. Such is not the case however. I fixed that and added the card! Thanks for the report.

Thanks. Here is another one that may be related. Using r.6282

Code: Select all

Name:Skittering Skirge
ManaCost:B B
Types:Creature Imp
Text:no text
PT:3/2
K:Flying
T:Mode$ SpellCast | ValidCard$ Card.Creature | ValidActivatingPlayer$ You | TriggerZones$ Battlefield | Execute$ TrigSacrifice | TriggerDescription$ When you cast a creature spell, sacrifice CARDNAME.
SVar:TrigSacrifice:AB$Sacrifice | Cost$ 0
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/skittering_skirge.jpg
End


This one bombs in similar fashion.

[friarsol]

This one bombs in similar fashion.

Computers aren't that violent. They usually just "crash" instead of "bomb"

[Hellfish]

I don't think Spells have Activating Players, only abilities do. Instead, use "ValidCard$ Creature.YouCtrl".

Oh, and Sol, you should've seen when my ex-laptop went

[jeffwadsworth]

I don't think Spells have Activating Players, only abilities do. Instead, use "ValidCard$ Creature.YouCtrl".

Oh, and Sol, you should've seen when my ex-laptop went

Really?

https://code.google.com/p/cardforge/sou ... ail?r=6281

*Looks at Sol*

[friarsol]

Don't blame me. Sloth started it. https://code.google.com/p/cardforge/sou ... ail?r=6051

Hellfish, why wouldn't Spells have Activating Players?

[Hellfish]

Because they're not activated, they're cast? Semantics, I know. And it does look like it is set for spells as well

I'll look into... Yeah, you know the drill


EDIT: Jeff, what creature did you play when it didn't work? It worked first try and onwards for me here.

[friarsol]

Because they're not activated, they're cast? Semantics, I know. And it does look like it is set for spells as well

I'll look into... Yeah, you know the drill

I guess we could have tried to use setController() there, but that seemed weird to me at the time I was coding it up. "ActivatingPlayer" really just means "Controller of the SA"

[Zirbert]

OK, now I'm confused, and I think I may have started the debate above over on the Bugs list. Isn't adding "+YouCtrl" the way to designate a spell that you cast? That's how it was templated on the cards I saw... or is that an old way that we're trying to move away from?

-Zirbert the n00b

[jeffwadsworth]

I am reinstalling Forge SVN from scratch because it still "crashed". I have a feeling the installation was whacked.

To answer your question Hellfish, it never got that far. I would chose the test deck and a two color deck for the AI and crash.

Ahh. I just saw a SVN fix that addressed the specific error I have been seeing after making test decks within the editor.

[friarsol]

OK, now I'm confused, and I think I may have started the debate above over on the Bugs list. Isn't adding "+YouCtrl" the way to designate a spell that you cast? That's how it was templated on the cards I saw... or is that an old way that we're trying to move away from?

The only thing about YouCtrl that worries me in this situation is:

I control Ashenmoor Liege and Task Mage Assembly. AI uses the Assembly to hit my Liege. While I may control the Assembly permanent, my opponent controls the Ability that's targeting my Liege(sa.getActivatingPlayer() in Forge speak). This should trigger Liege and make my opponent take some damage, but it wouldn't.

There aren't many of these cases, and I don't know how many of them currently are in Forge, but there is a difference.

[Zirbert]

OK, now I'm confused, and I think I may have started the debate above over on the Bugs list. Isn't adding "+YouCtrl" the way to designate a spell that you cast? That's how it was templated on the cards I saw... or is that an old way that we're trying to move away from?

The only thing about YouCtrl that worries me in this situation is:

I control Ashenmoor Liege and Task Mage Assembly. AI uses the Assembly to hit my Liege. While I may control the Assembly permanent, my opponent controls the Ability that's targeting my Liege(sa.getActivatingPlayer() in Forge speak). This should trigger Liege and make my opponent take some damage, but it wouldn't.

There aren't many of these cases, and I don't know how many of them currently are in Forge, but there is a difference.

In that case, we may have a bigger problem - I checked something in the ballpark of 85 cards that were templated "Whenever you cast a ____spell". The 6 I pointed out were the ones that *didn't* use +YouCtrl. That means we've got a whoooole bunch of cards with this problem. Roughly 85 minus 6, to be less than exact.

[friarsol]

In that case, we may have a bigger problem - I checked something in the ballpark of 85 cards that were templated "Whenever you cast a ____spell". The 6 I pointed out were the ones that *didn't* use +YouCtrl. That means we've got a whoooole bunch of cards with this problem. Roughly 85 minus 6, to be less than exact.

Casting a spell you don't control is even more of a corner case.

For you todo this you need to gain access from somewhere. Like with a Grinning Totem. I think there's only about 5-10 of these types of cards in the game, and I don't think we have any of them implemented.

So, yes, this probably should be fixed, but no. It's not a huge problem (yet).

[jeffwadsworth]

I am testing Flesh Reaver. Does anyone know if there is a "CardTotalDamage" type of stat?

[friarsol]

I am testing Flesh Reaver. Does anyone know if there is a "CardTotalDamage" type of stat?

It wouldn't need that. It just needs to grab the DamageAmount from the Trigger. Not sure if this is possible or not.

[Zirbert]

I've been trying Kookus (and there are a few similar "if you do / don't control a___" cards that could follow if this works). Can this line be tweaked to check for Keeper of Kookus during upkeep? Right now, it crashes Forge. I'm not sure about (a) using "IsNotPresent" in a trigger check; (b) whether IsNotPresent can look for a specific card name; (c) the syntax of the card name ("Keeper of Kookus" vs. "keeper_of_kookus", etc.):

Code: Select all

T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | IsNotPresent$ Permanent.Named.Keeper of Kookus | Execute$ TrigNoKeeper