Developing Bugs
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Developing Bugs
by Sloth » 26 May 2013, 08:59
Just to make sure: can you confirm that this is a bug caused by racing threads?Max mtg wrote:the first couple is bit out of scope of my current work. ATM I have no idea how to fix them.
New bug: This one always pops up when i use "Setup Game State" (doesn't cause any harm) (r21682):
- IllegalStateException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Sloth » 26 May 2013, 09:07
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 09:11
I am not sure of that. Also, I've never seen this first bug myself.
The second one is simple - it has to be run from non-edt thread.
The second one is simple - it has to be run from non-edt thread.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Sloth » 26 May 2013, 09:20
I'tested this boardstate (and hit Enter very fast):Max mtg wrote:I am not sure of that. Also, I've never seen this first bug myself.
The AI will cast Feral Hydra and pump it the next turn. One time everything worked fine and i was killed, one time i got this:
- RuntimeException | Open
- ArrayIndexOutOfBoundsException | Open
- ArrayIndexOutOfBoundsException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 10:06
With your save I achieved
- "ConcurrentModificationException" | Open
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 12:40
About that mana issue: AI is paying 
to add counter to hydra. We should make sure that AI checks if it has enough mana to pay for it
I commited r21689 but this does not seem to help
to add counter to hydra. We should make sure that AI checks if it has enough mana to pay for itI commited r21689 but this does not seem to help
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Sloth » 26 May 2013, 12:56
When the error happened the AI still had enough lands to tap.Max mtg wrote:About that mana issue: AI is paying
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 14:59
These won't help without circumstances when they happen. There are only 5 places left that use input lock:
- Karn restarts game
- InputPayMana locks while mana ab is resolved
- fillRequirements lock ui to avoid accidential updates breaking the process of target selection (Boros Battleshaper needs it)
- lock during human play SA from inputPassPriority // can remove?
- lock in cleanup phase. // this one might be removed without no consequences
- Karn restarts game
- InputPayMana locks while mana ab is resolved
- fillRequirements lock ui to avoid accidential updates breaking the process of target selection (Boros Battleshaper needs it)
- lock during human play SA from inputPassPriority // can remove?
- lock in cleanup phase. // this one might be removed without no consequences
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Sloth » 26 May 2013, 16:10
I got this error two times when i activated Feral Hydras ability (quickly after hitting Enter a lot).Max mtg wrote:These won't help without circumstances when they happen. There are only 5 places left that use input lock:
- RuntimeException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 17:02
Sloth, I caught that mana payment bug.
The debug output reads
Race condition in its best shape
The debug output reads
- Code: Select all
Game-1 > [PROD] payment *PAID* for (Feral Hydra (159))+0 3: Put a +1/+1 counter on Feral Hydra. Any player may activate this ability.:
1 : (Mox Emerald (191)) Tap: Add G to your mana pool.
1 : (Quicksand (193)) Tap: Add 1 to your mana pool.
1 : (Mox Emerald (190)) Tap: Add G to your mana pool.
Game-0 > [PROD] payment *PAID* for (Feral Hydra (159))+0 3: Put a +1/+1 counter on Feral Hydra. Any player may activate this ability.:
1 : (Mountain (186)) Tap: Add R to your mana pool.
1 : (Island (157)) Tap: Add U to your mana pool.
1 : (Swamp (172)) Tap: Add B to your mana pool.
Race condition in its best shape
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Sloth » 26 May 2013, 17:56
Good work Max!Max mtg wrote:Sloth, I caught that mana payment bug.
The debug output readsThat means that at some point AI is operating from several threads at a time!
- Code: Select all
Game-1 > [PROD] payment *PAID* for (Feral Hydra (159))+0 3: Put a +1/+1 counter on Feral Hydra. Any player may activate this ability.:
1 : (Mox Emerald (191)) Tap: Add G to your mana pool.
1 : (Quicksand (193)) Tap: Add 1 to your mana pool.
1 : (Mox Emerald (190)) Tap: Add G to your mana pool.
Game-0 > [PROD] payment *PAID* for (Feral Hydra (159))+0 3: Put a +1/+1 counter on Feral Hydra. Any player may activate this ability.:
1 : (Mountain (186)) Tap: Add R to your mana pool.
1 : (Island (157)) Tap: Add U to your mana pool.
1 : (Swamp (172)) Tap: Add B to your mana pool.
Race condition in its best shape
I've tested some games and didn't get any fatal error. Just once i got this one while just hitting Enter through the phases (r21706):
- RuntimeException | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Developing Bugs
by Max mtg » 26 May 2013, 18:13
Next candidate revision fixing this bug is 21709.
It had nothing in common with fast hitting Enter.
MagicStack was updating InputProxy, that is when AI activated hydra's ability and put it onto stack, InputProxy queued in EDT showMessage of AiInputCommon, that spawned another thread and ran AiController.onPriorityRecieved there.
Those threads certainly came to a place when they checked mana avaliability and rushed to pay the same mana to pump hydra.
Well, there's yet a next bug: hydra attacks, I block with Blood Artist and input gets locked!
It had nothing in common with fast hitting Enter.
MagicStack was updating InputProxy, that is when AI activated hydra's ability and put it onto stack, InputProxy queued in EDT showMessage of AiInputCommon, that spawned another thread and ran AiController.onPriorityRecieved there.
Those threads certainly came to a place when they checked mana avaliability and rushed to pay the same mana to pump hydra.
Well, there's yet a next bug: hydra attacks, I block with Blood Artist and input gets locked!
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Who is online
Users browsing this forum: No registered users and 37 guests