It is currently 20 Aug 2025, 07:25
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby friarsol » 18 Apr 2012, 19:59

DeadSpeak wrote:Is there a way to manually remove the flip-card bug?

- DeadSpeak
viewtopic.php?f=52&t=6333#p87105
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Milod » 19 Apr 2012, 00:36

cant play loyal cathar click on it nothing happens
Milod
 
Posts: 360
Joined: 20 Jul 2011, 08:57
Has thanked: 4 times
Been thanked: 5 times

Re: Bug Reports (snapshot builds)

Postby squee1968 » 19 Apr 2012, 00:43

Milod wrote:cant play loyal cathar click on it nothing happens
This was reported twice already. The bug happens with all transformed and flip cards. It is currently being investigated, but has not been fixed yet.
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Bug Reports (snapshot builds)

Postby Milod » 19 Apr 2012, 01:52

Emancipation Angel has no flying
Milod
 
Posts: 360
Joined: 20 Jul 2011, 08:57
Has thanked: 4 times
Been thanked: 5 times

Re: Bug Reports (snapshot builds)

Postby moomarc » 19 Apr 2012, 07:47

Milod wrote:Emancipation Angel has no flying
It does in svn, just not on the script ZzzzSleep posted in the AVR thread.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 19 Apr 2012, 15:12

Milod wrote:when i used banishing stroke on ai's oblivion ring it dident return my creature back to the field.. am i missing somthing?
Fixed! Thanks Milod. (the trigger handler didn't look for cards with triggers in the hand or library zone).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 19 Apr 2012, 15:30

Max mtg wrote:
friarsol wrote:Looks like the transformed bug was added here:

r15120 by Max, AbstractCardFactory.java l 168

Code: Select all
        CardFactoryUtil.copyCharacteristics(in, out);
        if (in.hasAlternateState()) {
            for (final CardCharactersticName state : in.getStates()) {
                in.setState(state);
                out.addAlternateState(state);
                out.setState(state);
                CardFactoryUtil.copyCharacteristics(in, out);
            }
            in.setState(curState);
            out.setState(curState);
        }
I commented out out.addAlternateState, which solved the transformed problem, but I'm not sure what the goal of this block is, so I didn't commit it.
The why I added
Code: Select all
out.addAlternateState(state);
was a warning when clone was moved to exile, out.setState(state); could not set a "Cloner" state of that card (that is the original properties of the card) - and it looks like the named state became lost. It's a pity, that it caused more severe bugs somewhere else.
I made a quick fix that only calls "out.addAlternateState(state);" if the state is "Cloner" (r15216). Are there any problems with that?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 20 Apr 2012, 03:04

r15225
Elbrus, the Binding Blade doesn't display "Equipped creature gets +1/+0." in the detail panel even though it appears in the card script under Text.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 20 Apr 2012, 04:05

It looks like the triggers setup using keyword macros in forge.card.cardfactory.CardFactoryUtil.postFactoryKeywords are not working. I found this when working on Soulbond. If I setup the triggers based on the keyword in postFactoryKeywords, ETB triggers never occur. If I put the same trigger directly in the card script, the ETB triggers fire. I also tested the same thing with Provoke and found the same results.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 20 Apr 2012, 06:56

ArsenalNut wrote:It looks like the triggers setup using keyword macros in forge.card.cardfactory.CardFactoryUtil.postFactoryKeywords are not working. I found this when working on Soulbond. If I setup the triggers based on the keyword in postFactoryKeywords, ETB triggers never occur. If I put the same trigger directly in the card script, the ETB triggers fire. I also tested the same thing with Provoke and found the same results.
Oh dear, it seems like copyCard messes up the cards again (they work when put onto the battlefield directly, but fail when they have been drawn before).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 20 Apr 2012, 15:07

ArsenalNut wrote:It looks like the triggers setup using keyword macros in forge.card.cardfactory.CardFactoryUtil.postFactoryKeywords are not working. I found this when working on Soulbond. If I setup the triggers based on the keyword in postFactoryKeywords, ETB triggers never occur. If I put the same trigger directly in the card script, the ETB triggers fire. I also tested the same thing with Provoke and found the same results.
Fixed! It was just a tiny boolean variable that was wrong.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 21 Apr 2012, 20:58

Forger wrote:Forge version 1.2.7-SNAPSHOT-r15148

Bloodline Keeper (cant be cast) and Sylvan Library (doesnt trigger) arent working anymore. I imagine more cards are affected.

They did in r15022.
Both are fixed! Thanks Forger.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 22 Apr 2012, 06:46

There appears to be an issue with some of the "leaves play" triggers. I had Myr Retriever, Solemn Simulacrum, and Floating-Dream Zubera, all put two instances of their leave play trigger on the stack. Solemn Simulacrum was intermittent but Myr Retriever and Floating Dream Zubera were consistently putting two triggers on the stack. The Solemn Simulacrums were my creatures and the other two were played by the AI. I also had an Oblivion Ring double trigger when returned to play by a Sun Titan.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 22 Apr 2012, 09:38

ArsenalNut wrote:There appears to be an issue with some of the "leaves play" triggers. I had Myr Retriever, Solemn Simulacrum, and Floating-Dream Zubera, all put two instances of their leave play trigger on the stack. Solemn Simulacrum was intermittent but Myr Retriever and Floating Dream Zubera were consistently putting two triggers on the stack. The Solemn Simulacrums were my creatures and the other two were played by the AI. I also had an Oblivion Ring double trigger when returned to play by a Sun Titan.
Fixed! Thanks ArsenalNut.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Doublestrike » 23 Apr 2012, 04:08

Had a lunch-break look at the quest mode no-cards-on-challenge thing, and that should be fixed.

It looked like that code has existed for a long time (it's in the Arcane package!) so I'm not sure why this bug hadn't shown up before. Anyway, a list just needed an iterator.

It affected the player field area, so if there is any weirdness happening there in the next 24-48 hours, r15266 may be the reason. But I played a game or two and everything looked copacetic.
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 7 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 7 guests

Login Form