myk's code contributions
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: myk's code contributions
by myk » 17 Mar 2013, 23:48
It was. It puts all the written data in one place. This is consistent with what NetBeans and other programs that separate user data from program data do.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: myk's code contributions
by Xitax » 18 Mar 2013, 00:45
Very difficult, especially for some older sets, but I can try. My standard is something I can edit (Photoshop) to full clarity and has to be larger than 350 pixels tall. If any of you have pictures of boosters stashed away someplace or know of a some hidden place to find them on the 'net I'd appreciate it!myk wrote:@Max: good point. @Xitax, do you think you could get a hold of the complete set of pics?
By the way, is there a place where I can look to see how many booster variants there were per set?
The pic[2] in this folder were ones that I did not use, but that I liked enough just in case I wanted to change them out.
Re: myk's code contributions
by friarsol » 18 Mar 2013, 00:55
http://wiki.mtgsalvation.com/article/Booster_packXitax wrote:By the way, is there a place where I can look to see how many booster variants there were per set?
Scroll down to Artwork
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: myk's code contributions
by Chris H. » 18 Mar 2013, 02:32
I updated to SVN rev 20447 and did a local build. I imported the data from an earlier snapshot build and discovered that there was still 99 cards to download. The list is pasted below.Abbey Matron1.full.jpg
10 new cards were added by Swordshine since my snapshot which provided the source for the import data. A lot of the cards below are followed by the number one and I have reason to believe that these same cards pics are located in the source pics dir and yet they were not transferred.
And I do want to thank everyone for their efforts and this issue appears to be getting better in that it decreased from about 300 pics to download to only 89 (+ the 10 new cards that were added today).
10 new cards were added by Swordshine since my snapshot which provided the source for the import data. A lot of the cards below are followed by the number one and I have reason to believe that these same cards pics are located in the source pics dir and yet they were not transferred.
- | Open
And I do want to thank everyone for their efforts and this issue appears to be getting better in that it decreased from about 300 pics to download to only 89 (+ the 10 new cards that were added today).
Last edited by moomarc on 18 Mar 2013, 07:11, edited 1 time in total.
Reason: Fixed "Sunshine's" name ;)
Reason: Fixed "Sunshine's" name ;)
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: myk's code contributions
by Max mtg » 18 Mar 2013, 05:07
@Chris, in my opinion,these 89 cards to be downloaded are correct.
A '1' should have been added to all cards avaliable in several printings in any set.
A '1' should have been added to all cards avaliable in several printings in any set.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by myk » 18 Mar 2013, 05:38
I think what Chris means is that the pictures are no longer getting migrated correctly. I'll see if I can redo my testing from last week and figure out what has gone wrong. : /
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: myk's code contributions
by moomarc » 18 Mar 2013, 06:03
Those transferred fine for me this morning when I finally updated. Although I used the Import from local folder option in downloaders.
EDIT: The only thing that didn't transfer properly were the Archenemy schemes, (possibly because they were named with the 'clean name' like ignite_the_cloneforge.jpg?)
EDIT: The only thing that didn't transfer properly were the Archenemy schemes, (possibly because they were named with the 'clean name' like ignite_the_cloneforge.jpg?)
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: myk's code contributions
by myk » 18 Mar 2013, 07:31
The core migration code has been modified, the filename generation code it depends on has been modified, the art indices now have a different base (which is why your files are not getting imported, Chris. the code is now looking for forest0.jpg instead of forest.jpg), and for what purpose? The filename and image type prefix code is now no longer uniform among the classes, making the architecture more fragile and less parallel. Why, Max? Why? I tried to have a discussion with you about this while the branch was still separate, and you did not respond. After a large branch merge is NOT the time to do major rework on the code from that branch, especially not without communicating fully with the developer who wrote that branch. Please revert the madness from today back to where the code was in a working, tested state. What is there now can probably be fixed to work again, but the code that was there before has /days/ of careful testing behind it. I do not object to a lot of the changes that were made, but this is just not the time to be making them. Not so quickly, not so much at once. Maybe I just have the wrong impression of the level of professionalism that is expected here, but what you did today appeared to me to be impulsive and counterproductive.
@other devs: if I am out of line here, please tell me, and I'll simmer down. Right now, I'm going to bed.
@other devs: if I am out of line here, please tell me, and I'll simmer down. Right now, I'm going to bed.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: myk's code contributions
by Max mtg » 18 Mar 2013, 09:10
Yes, I admit that the import could have been affected by yesterday's changes. I asked to point me at ocurring problems, I'll handle them. So no catastrophes or reverts are happening.
myk, I would never interfere into that tested and working code if: it worked for everyone (1) and if it were reasonably organized (2).
1st point refers to aliases for pictures folder.
2nd point is about adding unrelated methods into core classes. I am very jealous about CardPrinted, ItemPool, Deck and most classes from forge.card package. Without similiar care Card and Player classes became several thousands of code lines monsters.
About the level of professionals - there are no godly professionals here.
myk, I would never interfere into that tested and working code if: it worked for everyone (1) and if it were reasonably organized (2).
1st point refers to aliases for pictures folder.
2nd point is about adding unrelated methods into core classes. I am very jealous about CardPrinted, ItemPool, Deck and most classes from forge.card package. Without similiar care Card and Player classes became several thousands of code lines monsters.
About the level of professionals - there are no godly professionals here.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 18 Mar 2013, 09:10
Is this name mapping of old pics dir correct?
- Code: Select all
Will move plains.jpg -> Plains1.full.jpg
Will move plains1.jpg -> Plains2.full.jpg
Will move plains2.jpg -> Plains3.full.jpg
Will move plains3.jpg -> Plains4.full.jpg
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 18 Mar 2013, 09:51
I've just looked at what came out of my changes - it's pretty much the same API as you've put into CardPrinted
There are similiar static methods in ImageCache to get ImageKey and DownloadUrl for CardPrinted, except they don't allow custom artIndex.
And this gives an advantage - CardPrinted does not depend on local picture storage.
Dowloader got changed because its lists of download objects were making it difficult to trace duplicates - attempts to download picture for same destination file several times.
NIO was introduced because it's just cool
. I was looking at download code and wanted to make it simplier.
MigrationSourceAnalyzer was changed because it used to obtain images of cardprinted passing the card and a different artindex. It's just wrong - get the card with the desired artindex and do pass it as parameter. Code in newGame does extactly that thing to randomize art indices.
And yes, I was in a rush and commited some wrong code for _addDefaultPicNames(CardPrinted, boolean). I am sorry. Hope the current code is better.
There are similiar static methods in ImageCache to get ImageKey and DownloadUrl for CardPrinted, except they don't allow custom artIndex.
And this gives an advantage - CardPrinted does not depend on local picture storage.
Dowloader got changed because its lists of download objects were making it difficult to trace duplicates - attempts to download picture for same destination file several times.
NIO was introduced because it's just cool
. I was looking at download code and wanted to make it simplier.MigrationSourceAnalyzer was changed because it used to obtain images of cardprinted passing the card and a different artindex. It's just wrong - get the card with the desired artindex and do pass it as parameter. Code in newGame does extactly that thing to randomize art indices.
And yes, I was in a rush and commited some wrong code for _addDefaultPicNames(CardPrinted, boolean). I am sorry. Hope the current code is better.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Chris H. » 18 Mar 2013, 13:16
myk wrote:I think what Chris means is that the pictures are no longer getting migrated correctly. I'll see if I can redo my testing from last week and figure out what has gone wrong. : /
Yeah, My importing and migration tests were not transferring all of the pics from my pics folder. Most of these pics were transferring but there was a small number of pics that did not and I had to download them and noticed that a number was added to the end of the name.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: myk's code contributions
by Max mtg » 18 Mar 2013, 13:26
Chris, I have worked on this subject in the morning (at least it was morning here) and hope that the problem was fixed.
Does the current version transfer pictures correctly?
Does the current version transfer pictures correctly?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Who is online
Users browsing this forum: Google [Bot] and 47 guests