Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 30 Apr 2014, 18:22
Ahh.. In this scenario, is the card lost to ante available in subsequent games? Or is it just temporarily gone and restored with a card from your collection at the end of the match?KrazyTheFox wrote:I've located the cause of the antes not being removed from decks after games, however, the problem is my misunderstanding of the way the game handles removing the cards from the decks. Cards weren't being removed from my deck after games because I had more copies in my collection than were in my deck. The game doesn't remove the card from the deck because there's a "replacement" card available in my collection. Once the number of cards in the collection is equivalent to the number in the deck the card is removed as it should be.
No bug here, moving along to other things.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 30 Apr 2014, 18:39
Running through the logic for the code responsible:friarsol wrote:Ahh.. In this scenario, is the card lost to ante available in subsequent games? Or is it just temporarily gone and restored with a card from your collection at the end of the match?
- Code: Select all
this.qa.getCardPool().remove(card, qty);
if (addToShop) {
this.qa.getShopList().add(card, qty);
}
// remove card being sold from all decks
final int leftInPool = this.qa.getCardPool().count(card);
// remove sold cards from all decks:
for (final Deck deck : this.qc.getMyDecks()) {
int cntInMain = deck.getMain().count(card);
int cntInSb = deck.has(DeckSection.Sideboard) ? deck.get(DeckSection.Sideboard).count(card) : 0;
int nToRemoveFromThisDeck = cntInMain + cntInSb - leftInPool;
if (nToRemoveFromThisDeck <= 0) {
continue; // this is not the deck you are looking for
}
//etc...
deck.getMain().remove(card, nToRemoveFromThisDeck);
}
1 card is removed from the card pool (this.qa.getCardPool().remove(card, qty);), card pool now has 3 of that card.
leftInPool is set to 3 (leftInPool = this.qa.getCardPool().count(card);).
cntInMain is set to 2 (cntInMain = deck.getMain().count(card);).
cntInSb is set to 0.
nToRemoveFromThisDeck is calculated to be ((2 + 0) - 3), or -1 (nToRemoveFromThisDeck = cntInMain + cntInSb - leftInPool;). This indicates that there's 1 more card in the collection than there is in the deck.
Since there's that extra card, the method continues on to the next deck without removing the card (if (nToRemoveFromThisDeck <= 0) { continue; }).
As the card isn't removed from the deck here, it remains available in all subsequent games until the collection is reduced enough to trigger the removal.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by friarsol » 30 Apr 2014, 18:52
Oh, by subsequent games I meant actual games. Not subsequent matches.KrazyTheFox wrote:As the card isn't removed from the deck here, it remains available in all subsequent games until the collection is reduced enough to trigger the removal.
Start a match:
Game 1: I ante a precious Swamp Mosquito. Devastated by this predicament, I lose. I started this match having 4 in my Main, and 45 in my collection. Obviously my "in collection" number is reduced to 44.
Game 2: I ante a Marsh Viper. On my first turn I cast a Vampiric Tutor, not seeing a Swamp Mosquito in my hand. Are there 3 Swamp Mosquitos in my deck? Or 4? If there are 4 in the same match where I lost the card in the ante then that portion is incorrect, even if the "auto-replace from collection" bits makes sense from a multiple match standpoint.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 30 Apr 2014, 19:05
It works that way for games (and by extension, matches).
If you have 4 cards in your collection and deck and you lose 1 of them as an ante, the card will be removed at the end of the game that you lost it in and won't be available in subsequent games. However, if you have 4 cards in your collection and only 3 in your deck, you still own 3 copies of the card and it won't be removed from your deck (but it will be removed from your collection, leaving you with 3 total cards). If you then lost another one of those cards in the next game, it will be removed from both the deck and collection, as there's only 2 total cards now.
In your example, it gets removed as you'd expect it to be and during the second game, you'll have only 3 of the card in your deck.
I had to work through the code several times to figure out exactly how it works. It's just a little bit confusing.
If you have 4 cards in your collection and deck and you lose 1 of them as an ante, the card will be removed at the end of the game that you lost it in and won't be available in subsequent games. However, if you have 4 cards in your collection and only 3 in your deck, you still own 3 copies of the card and it won't be removed from your deck (but it will be removed from your collection, leaving you with 3 total cards). If you then lost another one of those cards in the next game, it will be removed from both the deck and collection, as there's only 2 total cards now.
In your example, it gets removed as you'd expect it to be and during the second game, you'll have only 3 of the card in your deck.
I had to work through the code several times to figure out exactly how it works. It's just a little bit confusing.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by Fizanko » 30 Apr 2014, 20:40
Just played Shock (that had worked everytime i played it on previous duels on the same snapshot build) on Lionheart Maverick , using KrazyTheFox's snapshot build from there and pressed the OK button :
Description: [describe what you were doing when the crash occurred]
Description: [describe what you were doing when the crash occurred]
- NullPointerException | Open
Last edited by Fizanko on 30 Apr 2014, 22:09, edited 1 time in total.
probably outdated by now so you should avoid : Innistrad world for Forge (updated 17/11/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Re: Bug Reports (snapshot builds)
by Fizanko » 30 Apr 2014, 22:09
Similar bug, i just played Midnight Duelist and pressed OK to resolve
Description: [describe what you were doing when the crash occurred]
Description: [describe what you were doing when the crash occurred]
- NullPointerException | Open
probably outdated by now so you should avoid : Innistrad world for Forge (updated 17/11/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Re: Bug Reports (snapshot builds)
by mark » 04 May 2014, 20:22
The imprint of Panoptic Mirror is broken: it can be tapped and the mana can be paid... and no card may be exiled.
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 04 May 2014, 22:37
It That Betrays doesn't put permanents under my control when my opponent sacrifices them, however the ability does go on the stack.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by swordshine » 05 May 2014, 04:43
The timestamp system in this program is very fragile. I attempt to tweak the related code to fix this bug. There might be other bugs of triggered abilities. I'll test all the other cases when I have plenty of time.KrazyTheFox wrote:It That Betrays doesn't put permanents under my control when my opponent sacrifices them, however the ability does go on the stack.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Leviathan » 05 May 2014, 06:16
I'm getting ConcurrentModificationExceptions fairly often (maybe once every 5-10 games on average). I'm using the SVN, and have seen these exceptions with several revisions over the past few days. The stack traces are different every time. Here's the most recent example, from revision 25779:
Edit: The ConcurrentModificationExceptions have largely gone away. I didn't do anything to fix them, so maybe it was just cosmic rays all along?
- ConcurrentModificationException | Open
Edit: The ConcurrentModificationExceptions have largely gone away. I didn't do anything to fix them, so maybe it was just cosmic rays all along?
Last edited by Leviathan on 06 May 2014, 02:43, edited 1 time in total.
- Leviathan
- Posts: 4
- Joined: 29 May 2012, 03:30
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 06 May 2014, 00:57
When attempting to unlock the Starter 2000 set in quest mode:
Edit: This also occurs with the Time Shifted 'set'.
Edit: This also occurs with the Time Shifted 'set'.
- Code: Select all
EDT > java.lang.NullPointerException
at forge.card.BoosterGenerator.getBoosterPack(BoosterGenerator.java:63)
at forge.card.UnOpenedProduct.get(UnOpenedProduct.java:61)
at forge.quest.QuestUtilUnlockSets.doUnlock(QuestUtilUnlockSets.java:189)
at forge.screens.home.quest.SSubmenuQuestUtil.chooseAndUnlockEdition(SSubmenuQuestUtil.java:290)
at forge.screens.home.quest.CSubmenuDuels$6.run(CSubmenuDuels.java:50)
at forge.toolbox.FLabel._doMouseAction(FLabel.java:289)
at forge.toolbox.FLabel.access$3(FLabel.java:286)
at forge.toolbox.FLabel$4.onLeftClick(FLabel.java:327)
at forge.toolbox.FMouseAdapter.mouseReleased(FMouseAdapter.java:245)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$200(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by timmermac » 07 May 2014, 11:35
I believe this is because no real boosters exist of those sets.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 07 May 2014, 17:41
IIRC, Starter 1999 and 2000 both had booster packs (though I have no idea how random they actually were). Regardless, they should probably be removed from the quest selection as they prevent progression by filling up the possible unlock slots.timmermac wrote:I believe this is because no real boosters exist of those sets.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by knightowl71 » 07 May 2014, 21:19
Description: Playing a standard 1V1 game with constructed decks. This was game 3. Game continued but creatures and lands did not tap or untap from this point on. The game did recognize if they were tapped such as attacking or getting mana just did not show visually.
- ConcurrentModificationException | Open
- knightowl71
- Posts: 7
- Joined: 15 Mar 2014, 21:49
- Has thanked: 3 times
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Fizanko » 07 May 2014, 21:52
Not the first time it happened, i had this sometime in previous version (and reported it here and there and over there )
It's fortunately rare, but when it happens, it's after winning or losing a round (in that case i won it) and pressing Next for starting the next round, instead of doing the next round the game go back to the main menu with that error popping up :
Description: [describe what you were doing when the crash occurred]
It's fortunately rare, but when it happens, it's after winning or losing a round (in that case i won it) and pressing Next for starting the next round, instead of doing the next round the game go back to the main menu with that error popping up :
Description: [describe what you were doing when the crash occurred]
- UncheckedExecutionException | Open
probably outdated by now so you should avoid : Innistrad world for Forge (updated 17/11/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Who is online
Users browsing this forum: No registered users and 21 guests