Developing Bugs
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Developing Bugs
by friarsol » 27 May 2013, 03:27
Also, the Play/Draw dialog shows up but I can already see my opening hand, which shouldn't happen.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Developing Bugs
by Max mtg » 29 May 2013, 18:45
@Sloth, I don't know how you manage to do this, but you are really great at finding concurrency problems.
(for InputAttack issue)
This time Game thread has changed defenders variable (a field of Combat class) but EDT was not aware of that, since the event didn't happen-before from ETD's point of view.
I have added a call to a block syncronized on the same variable (let it be inputLock) so that release of that lock in Game thread (and whatever was executed by same thread) is performed. When EDT thread is about to show message of a newly selected input it shall acquire lock on the same object (inputLock) . That ensures propper order or operations.
(for concede before turns start)
fixed by 21821
(for InputAttack issue)
This time Game thread has changed defenders variable (a field of Combat class) but EDT was not aware of that, since the event didn't happen-before from ETD's point of view.
I have added a call to a block syncronized on the same variable (let it be inputLock) so that release of that lock in Game thread (and whatever was executed by same thread) is performed. When EDT thread is about to show message of a newly selected input it shall acquire lock on the same object (inputLock) . That ensures propper order or operations.
(for concede before turns start)
fixed by 21821
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by swordshine » 01 Jun 2013, 12:22
The leave-play trigger of Patron of the Nezumi doesn't quite work. The rule says
I cast Wrath of God, but nothing triggered. Then I tried multiple Blood Artists in play and cast Wrath of God, each Blood Artist only triggered once for himself.2/1/2005: Patron of the Nezumi's ability triggers even if an event puts this and multiple other permanents into the graveyard at the same time (Wrath of God, gang blocks, etc.)
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Developing Bugs
by friarsol » 01 Jun 2013, 12:34
I believe this is an issue with this trigger in general as Blood Artist also doesn't handle this scenario correctly.swordshine wrote:The leave-play trigger of Patron of the Nezumi doesn't quite work. The rule says
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Developing Bugs
by Hanmac » 06 Jun 2013, 10:41
Modular Creatures like Arcbound Worker does not trigger anymore the effect of Sword of the Meek.
Modular says: "enters the Battlefield with" so its an 1/1 when entering the field and should activate the effect of the Sword
Modular says: "enters the Battlefield with" so its an 1/1 when entering the field and should activate the effect of the Sword
Re: Developing Bugs
by friarsol » 08 Jun 2013, 16:46
Re: r22013
Hey Max, if you are gonna tell someone to follow naming conventions, you should probably tell the person who actually had something to do with the file, not a random other person.
Hey Max, if you are gonna tell someone to follow naming conventions, you should probably tell the person who actually had something to do with the file, not a random other person.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Developing Bugs
by Max mtg » 08 Jun 2013, 17:00
Huh, you were not involved, right. I am sorry. Swordshine was.
I just remember you've changed all costs at some point of time
How can I correct SVN log?
I just remember you've changed all costs at some point of time
How can I correct SVN log?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by Max mtg » 08 Jun 2013, 17:02
I am going on a vacation for the next week because I fail to understand new code works and I also mix up the things I should not.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Developing Bugs
by swordshine » 09 Jun 2013, 00:25
Oops, my fault.Max mtg wrote:Huh, you were not involved, right. I am sorry. Swordshine was.
I just remember you've changed all costs at some point of time
How can I correct SVN log?
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Developing Bugs
by friarsol » 09 Jun 2013, 01:11
Heh no worries. When I was way more active in Forge codebase (2 years ago) I felt like that sometimes too. I promise I won't break too much of your stuff while you are taking a few days for mental healthMax mtg wrote:I am going on a vacation for the next week because I fail to understand new code works and I also mix up the things I should not.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Developing Bugs
by swordshine » 15 Jun 2013, 16:05
I'm trying to script Ayesha Tanaka.
It's weird that the TargetedController of the activated ability is always my opponent. I tried to counter a equip ability of my Sword of Body and Mind, but ai paid the cost.
Ruhan of the Fomori doesn't actually choose a player at random.
It's weird that the TargetedController of the activated ability is always my opponent. I tried to counter a equip ability of my Sword of Body and Mind, but ai paid the cost.
Ruhan of the Fomori doesn't actually choose a player at random.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Developing Bugs
by Agetian » 18 Jun 2013, 12:32
I'm getting this compilation error when trying to compile r22144:
new Target("Target a creature to Hunt", new String[]{"Creature"}, "1", "1");
But I'm not sure about the min/max parameters, so I decided not to jump right into tweaking this myself...
- Agetian
- Code: Select all
1. ERROR in D:\NetBeansProjects\trunk\src\main\java\forge\card\cardfactory\CardFactoryCreatures.java (at line 135)
final Target abTgt = new Target("Target a creature to Hunt", new String[]{"Creature"});
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The constructor Target(String, String[]) is undefined
new Target("Target a creature to Hunt", new String[]{"Creature"}, "1", "1");
But I'm not sure about the min/max parameters, so I decided not to jump right into tweaking this myself...
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Developing Bugs
by Chris H. » 21 Jun 2013, 16:50
I updated to the head version 22193 and Forge will not build as there are three errors:
- Code: Select all
Cannot instantiate the type ArrayList<?> ChangeTargetsEffect.java /ForgeSVN/src/main/java/forge/card/ability/effects line 54 Java Problem
Syntax error on token "<", ? expected after this token ChangeTargetsEffect.java /ForgeSVN/src/main/java/forge/card/ability/effects line 54 Java Problem
Type mismatch: cannot convert from ArrayList<?> to List<Pair<SpellAbilityStackInstance,ITargetable>> ChangeTargetsEffect.java /ForgeSVN/src/main/java/forge/card/ability/effects line 54 Java Problem
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Who is online
Users browsing this forum: No registered users and 70 guests