Bug Reports (snapshot builds)
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by ArsenalNut » 02 May 2012, 15:40
I'll work on the additions to changeZone tonight if someone doesn't beat me to it.Sloth wrote:I took a look at getLKICopy (and made some changes which may or may not be relevant), but yes only testing will reveal bugs. But i think we can take the chance.friarsol wrote:The only issue that may arise from that is messing up LKI.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by friarsol » 02 May 2012, 17:22
Yea that's fine, I just wanted to point it out so it got tested while the changes were happening instead of them "magically" being broken.Sloth wrote:I took a look at getLKICopy (and made some changes which may or may not be relevant), but yes only testing will reveal bugs. But i think we can take the chance.friarsol wrote:The only issue that may arise from that is messing up LKI.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 03 May 2012, 03:59
I made the change to look for a enchanted/enchanting and equipped/equipping when a card changes zone. I tested with Restoration Angel and enchantments went to the graveyard and equipment became unequipped. How would I test the effect on LKI?friarsol wrote:Yea that's fine, I just wanted to point it out so it got tested while the changes were happening instead of them "magically" being broken.Sloth wrote:I took a look at getLKICopy (and made some changes which may or may not be relevant), but yes only testing will reveal bugs. But i think we can take the chance.friarsol wrote:The only issue that may arise from that is messing up LKI.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by friarsol » 03 May 2012, 04:08
Altar of Dementia is my favorite LKI tester. Just put a Rancor on or some such.ArsenalNut wrote:I made the change to look for a enchanted/enchanting and equipped/equipping when a card changes zone. I tested with Restoration Angel and enchantments went to the graveyard and equipment became unequipped. How would I test the effect on LKI?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 03 May 2012, 04:23
Just did a quick test using Altar of Dementia on a Frenzied Goblin enchanted with Rancor (now a 3/1 creature). The top three cards of the AI's library were correctly moved to the graveyard and Rancor returned to my hand. Looks like my changes didn't hurt LKI.friarsol wrote:Altar of Dementia is my favorite LKI tester. Just put a Rancor on or some such.ArsenalNut wrote:I made the change to look for a enchanted/enchanting and equipped/equipping when a card changes zone. I tested with Restoration Angel and enchantments went to the graveyard and equipment became unequipped. How would I test the effect on LKI?
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by friarsol » 03 May 2012, 12:55
Sounds good. I guess the only part of "flickering" we have to deal with left is fizzling SAs.ArsenalNut wrote:Just did a quick test using Altar of Dementia on a Frenzied Goblin enchanted with Rancor (now a 3/1 creature). The top three cards of the AI's library were correctly moved to the graveyard and Rancor returned to my hand. Looks like my changes didn't hurt LKI.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Sloth » 03 May 2012, 16:10
I've found that Murderous Spoils, Eaten by Spiders and Soul Nova don't work correctly any more (they don't use LKI copies). I will think about a solution.ArsenalNut wrote:I made the change to look for a enchanted/enchanting and equipped/equipping when a card changes zone. I tested with Restoration Angel and enchantments went to the graveyard and equipment became unequipped. How would I test the effect on LKI?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 03 May 2012, 18:59
If there is not an easy solution in the code, what about reordering the actions in the script. Generically, the problem scripts could be rewritten doSloth wrote:I've found that Murderous Spoils, Eaten by Spiders and Soul Nova don't work correctly any more (they don't use LKI copies). I will think about a solution.ArsenalNut wrote:I made the change to look for a enchanted/enchanting and equipped/equipping when a card changes zone. I tested with Restoration Angel and enchantments went to the graveyard and equipment became unequipped. How would I test the effect on LKI?
1) empty Pump to target a creature
2) do the stuff to the equipment
3) do the stuff to the target creature
I think these would functionally equivalent.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by Sloth » 03 May 2012, 20:43
Changing the order will mess up the AI, but i don't have any better ideas.ArsenalNut wrote:If there is not an easy solution in the code, what about reordering the actions in the script. Generically, the problem scripts could be rewritten do
1) empty Pump to target a creature
2) do the stuff to the equipment
3) do the stuff to the target creature
I think these would functionally equivalent.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by 7Durandal7 » 04 May 2012, 04:46
Forge 1.2.7r15413
Computer plays Zombie Cutthroat by paying 3. It should end up face down 2/2, but instead it came into play face up 3/4. Computer did not play the morph cost.
Computer plays Zombie Cutthroat by paying 3. It should end up face down 2/2, but instead it came into play face up 3/4. Computer did not play the morph cost.
-
7Durandal7 - Posts: 15
- Joined: 04 May 2012, 04:38
- Has thanked: 7 times
- Been thanked: 9 times
Re: Bug Reports (snapshot builds)
by DemoneNero » 05 May 2012, 20:48
Tested with Forge Beta: 05-04-2012 ver 1.2.7
Life Chisel has a "cumulative" effect, if you sacrifice a creature with 2 toughness it says "you gain 2 life", then if you sacrifice another creature with 1 toughness it says "you gain 3 life", but at the end you gain 5 life instead of 3
Life Chisel has a "cumulative" effect, if you sacrifice a creature with 2 toughness it says "you gain 2 life", then if you sacrifice another creature with 1 toughness it says "you gain 3 life", but at the end you gain 5 life instead of 3
Hold The Heathen Hammer High
-
DemoneNero - Posts: 91
- Joined: 26 Jul 2010, 19:41
- Location: Italy
- Has thanked: 4 times
- Been thanked: 1 time
Re: Bug Reports (snapshot builds)
by Milod » 05 May 2012, 22:41
kruin striker get 2 counters when 1 creature enters the field i see in code buffed by creature 2x ;]
Re: Bug Reports (snapshot builds)
by friarsol » 06 May 2012, 01:18
AF_Fights doesn't check if the creature is still on the battlefield before making it fight.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Neskit » 07 May 2012, 15:20
Myr Propagator tokens due not all have the ability to make more tokens.
- Neskit
- Posts: 5
- Joined: 04 Sep 2011, 02:41
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Sloth » 07 May 2012, 20:19
Fixed! Thanks 7Durandal7.7Durandal7 wrote:Forge 1.2.7r15413
Computer plays Zombie Cutthroat by paying 3. It should end up face down 2/2, but instead it came into play face up 3/4. Computer did not play the morph cost.
Fixed! Thanks solfriarsol wrote:AF_Fights doesn't check if the creature is still on the battlefield before making it fight.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Who is online
Users browsing this forum: No registered users and 16 guests