It is currently 29 Oct 2025, 12:29
   
Text Size

UI Improvements, Round 2: Match UI

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Re: UI Improvements, Round 2: Match UI

Postby friarsol » 03 Feb 2012, 05:02

Doublestrike wrote:I think Max mentioned quests saved between 13703 and 13735 (?) are permanently broken?

But that shouldn't have anything to do with the prefs saving...I'll test again using your clues.
Could be, but I wouldn't think that would affect prefs. I'll let you know if my new quest is broken too.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: UI Improvements, Round 2: Match UI

Postby Max mtg » 03 Feb 2012, 05:07

friarsol wrote:
Doublestrike wrote:I think Max mentioned quests saved between 13703 and 13735 (?) are permanently broken?

But that shouldn't have anything to do with the prefs saving...I'll test again using your clues.
Could be, but I wouldn't think that would affect prefs. I'll let you know if my new quest is broken too.
I never tried to load that broken quest saves with the updated client, but in theory such saves should load normally without exceptions, as for decks - I expect them to contain no cards after deserialization from incorrecly saved decksections.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: UI Improvements, Round 2: Match UI

Postby friarsol » 03 Feb 2012, 05:19

Saving in a new quest didn't work.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: UI Improvements, Round 2: Match UI

Postby Doublestrike » 03 Feb 2012, 06:13

I just tested again, in quest mode.

- Old quest, persist across match
- Old quest, persist across restart
- New quest, persist across match
- New quest, persist across restart

No problems. :?
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Re: UI Improvements, Round 2: Match UI

Postby goonjamin » 03 Feb 2012, 13:35

I am also still having the same issue as friarsol, with layout and phase prefs not saving.

What version of java is everyone running? Right now I am using java 6 update 30 (computer is windows 7 x86). I am going to try installing java 7u2 and see if that makes a difference.
goonjamin
 
Posts: 133
Joined: 19 Aug 2010, 19:51
Has thanked: 39 times
Been thanked: 5 times

Re: UI Improvements, Round 2: Match UI

Postby friarsol » 03 Feb 2012, 14:19

The machine I'm having issues with is my Netbook, Win 7x86 6u25. goonjamin, Java 7 will probably have worse errors as they broke backwards compatibility.

I'll check on my Gaming machine some point today when I have some time.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: UI Improvements, Round 2: Match UI

Postby friarsol » 03 Feb 2012, 17:26

Tested my gaming machine Win7x64 java 6u23 same as above. Doesn't save for me in Quest mode. But it does in Constructed..
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: UI Improvements, Round 2: Match UI

Postby Chris H. » 03 Feb 2012, 18:57

friarsol wrote:Tested my gaming machine Win7x64 java 6u23 same as above. Doesn't save for me in Quest mode. But it does in Constructed..
`
I ran the same test on my machine and got the same results.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: UI Improvements, Round 2: Match UI

Postby friarsol » 03 Feb 2012, 23:54

It looks like forge.view.GuiTopLevel.savePrefs() is only being called from forge.control.match.ControlDock.concede()

I can't even tell where this is called for the Quest? Is there some different function?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: UI Improvements, Round 2: Match UI

Postby Doublestrike » 04 Feb 2012, 00:28

Ahh that's the clue that broke the camel's eye of the needle! I've been testing using only the concede button, not the regular game end! #-o

Should be fixed now.
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Previous

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 12 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 12 users online :: 0 registered, 0 hidden and 12 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 12 guests

Login Form