Bug Reports (snapshot builds)
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by jeffwadsworth » 03 Feb 2015, 22:56
Well, it just says that it has to be cast, not resolved.matrix4767 wrote:r28775: AI has Dovescape on the field. I have a Seeker of the Way and a Monastery Mentor.
I activate Lightning Strike, Dovescape triggers and counters spell, Prowess triggers resolve and Ai is dealt 3 damage.
Should this happen?
Here is the ruling.
http://mtgsalvation.gamepedia.com/Prowess
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: Bug Reports (snapshot builds)
by mastroego » 03 Feb 2015, 23:23
Yeah but the 3 damage being dealt do seem like a bug.jeffwadsworth wrote:Well, it just says that it has to be cast, not resolved.matrix4767 wrote:r28775: AI has Dovescape on the field. I have a Seeker of the Way and a Monastery Mentor.
I activate Lightning Strike, Dovescape triggers and counters spell, Prowess triggers resolve and Ai is dealt 3 damage.
Should this happen?
Here is the ruling.
http://mtgsalvation.gamepedia.com/Prowess
Re: Bug Reports (snapshot builds)
by Snowstorm » 04 Feb 2015, 09:30
r29775
"New" Bugs:
When planeswalking from Sanctum of Serra the game crashes (oh and if it means anything Astral Arena was the next plane).
1. Casting Order of Succession and not owning a creature card crashes the game.
3. Whenever the AI uses cards like Blatant Thievery and any Primordial creature such as Molten Primordial they have a choice to choose more than one card from any player/bot instead of one per player.
4. Hive Mind suffers the same problem in 3+ multiplayer as some of the bugs I previously posted by only giving the first bot and myself a copy. But it also suffers another bug when copying certain cards such as Timetwister (it maybe just Timetwister itself) which causes the game to crash.
"New" Bugs:
When planeswalking from Sanctum of Serra the game crashes (oh and if it means anything Astral Arena was the next plane).
- NullPointerException | Open
- NullPointerException | Open
- NullPointerException | Open
1. Casting Order of Succession and not owning a creature card crashes the game.
- NullPointerException | Open
3. Whenever the AI uses cards like Blatant Thievery and any Primordial creature such as Molten Primordial they have a choice to choose more than one card from any player/bot instead of one per player.
4. Hive Mind suffers the same problem in 3+ multiplayer as some of the bugs I previously posted by only giving the first bot and myself a copy. But it also suffers another bug when copying certain cards such as Timetwister (it maybe just Timetwister itself) which causes the game to crash.
- IllegalArgumentException | Open
Re: Bug Reports (snapshot builds)
by Hellfish » 06 Feb 2015, 08:32
On it first thing after work. EDIT: Done!Snowstorm wrote:r29775
"New" Bugs:
When planeswalking from Sanctum of Serra the game crashes (oh and if it means anything Astral Arena was the next plane).Edit: Another plane related bug pop up this time with Prahv and the next plane was Shiv.
- NullPointerException | Open
Edit2: Seems like a lot of planes have a similar problem, here is another this time Selesnya Loft Gardens and the plane I planeswalk to this time was Orzhova.
- NullPointerException | Open
- NullPointerException | Open
Last edited by Hellfish on 06 Feb 2015, 22:13, edited 1 time in total.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Bug Reports (snapshot builds)
by apollov » 06 Feb 2015, 20:49
- apollov
- Posts: 9
- Joined: 22 Jan 2015, 15:30
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Snowstorm » 07 Feb 2015, 10:33
Thanks Hellfish!Hellfish wrote:On it first thing after work. EDIT: Done!Snowstorm wrote:r29775
"New" Bugs:
When planeswalking from Sanctum of Serra the game crashes (oh and if it means anything Astral Arena was the next plane).Edit: Another plane related bug pop up this time with Prahv and the next plane was Shiv.
- NullPointerException | Open
Edit2: Seems like a lot of planes have a similar problem, here is another this time Selesnya Loft Gardens and the plane I planeswalk to this time was Orzhova.
- NullPointerException | Open
- NullPointerException | Open
Well onto the other bugs I found 
"New" Bug(s): as of r28787
1. The Fourth Sphere makes two zombie tokens when chaos is roll instead of just one.
2. When using Ignite the Cloneforge! ability and choosing to make a token of a land you are unable to tap the land token for mana.
Older Unfixed Previously Reported Bugs: (All of them have been retested as of r28787)
1. Casting Order of Succession and not owning a creature card crashes the game.
- NullPointerException | Open
3. Whenever the AI uses cards like Blatant Thievery and any Primordial creature such as Molten Primordial they have a choice to choose more than one card from any player/bot instead of one per player.
4. Hive Mind suffers the same problem in 3+ multiplayer as some of the bugs I previously posted by only giving the first bot and myself a copy. But it also suffers another bug when copying certain cards such as Timetwister (it maybe just Timetwister itself) which causes the game to crash.
- IllegalArgumentException | Open
Re: Bug Reports (snapshot builds)
by apollov » 07 Feb 2015, 19:18
Description: At «Constructed» view, choosing a deck for a Human, clicked on table header to sort. If it helps, a window with this exception appears twice when I click on a table header.
- NullPointerException | Open
- apollov
- Posts: 9
- Joined: 22 Jan 2015, 15:30
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Myrd » 08 Feb 2015, 18:33
Looks like Sloth's r28803 broke GameSimulatorTest.testEquippedAbilities. I've disabled the test for now.
The test fails even before it gets to run the simulation code - fails this check:
assertEquals(1, bear.getAmountOfKeyword("Unblockable"));
It seems Whispersilk Cloak is no longer granting Unblockable to the creature it's equipping? I don't understand r28803, so would appreciate if someone who understand static ability layers could take a look and see if that revision indeed introduced a bug or whether the test is wrong (e.g. I need to check for Unblockable keyword using some other API that c.getAmountOfKeyword()). Thanks!
The test fails even before it gets to run the simulation code - fails this check:
assertEquals(1, bear.getAmountOfKeyword("Unblockable"));
It seems Whispersilk Cloak is no longer granting Unblockable to the creature it's equipping? I don't understand r28803, so would appreciate if someone who understand static ability layers could take a look and see if that revision indeed introduced a bug or whether the test is wrong (e.g. I need to check for Unblockable keyword using some other API that c.getAmountOfKeyword()). Thanks!
Re: Bug Reports (snapshot builds)
by Agetian » 09 Feb 2015, 05:06
I can confirm that r28803 indeed breaks e.g. Whispersilk Cloak and it no longer grants Unblockable to the creature it's equipping, which is indeed wrong behavior. I admit I have no idea what r28803 was meant to do or how the code in that section of Forge is meant to work, so hopefully Sloth or someone else will be able to comment more on this change...Myrd wrote:Looks like Sloth's r28803 broke GameSimulatorTest.testEquippedAbilities. I've disabled the test for now.
The test fails even before it gets to run the simulation code - fails this check:
assertEquals(1, bear.getAmountOfKeyword("Unblockable"));
It seems Whispersilk Cloak is no longer granting Unblockable to the creature it's equipping? I don't understand r28803, so would appreciate if someone who understand static ability layers could take a look and see if that revision indeed introduced a bug or whether the test is wrong (e.g. I need to check for Unblockable keyword using some other API that c.getAmountOfKeyword()). Thanks!
- Agetian
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Sloth » 09 Feb 2015, 08:08
I will take a look.Agetian wrote:I can confirm that r28803 indeed breaks e.g. Whispersilk Cloak and it no longer grants Unblockable to the creature it's equipping, which is indeed wrong behavior. I admit I have no idea what r28803 was meant to do or how the code in that section of Forge is meant to work, so hopefully Sloth or someone else will be able to comment more on this change...Myrd wrote:Looks like Sloth's r28803 broke GameSimulatorTest.testEquippedAbilities. I've disabled the test for now.
The test fails even before it gets to run the simulation code - fails this check:
assertEquals(1, bear.getAmountOfKeyword("Unblockable"));
It seems Whispersilk Cloak is no longer granting Unblockable to the creature it's equipping? I don't understand r28803, so would appreciate if someone who understand static ability layers could take a look and see if that revision indeed introduced a bug or whether the test is wrong (e.g. I need to check for Unblockable keyword using some other API that c.getAmountOfKeyword()). Thanks!
EDIT: Done!
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by Agetian » 09 Feb 2015, 15:26
Hmm it looks like something is still wrong - I tried r28813 and now Whispersilk Cloak grants Unblockable but does not grant Shroud (the creature can indeed still be targeted and "Shroud" does not appear in the card detail box). This must be a related issue because it works correctly in r28802.Sloth wrote:I will take a look.Agetian wrote:I can confirm that r28803 indeed breaks e.g. Whispersilk Cloak and it no longer grants Unblockable to the creature it's equipping, which is indeed wrong behavior. I admit I have no idea what r28803 was meant to do or how the code in that section of Forge is meant to work, so hopefully Sloth or someone else will be able to comment more on this change...Myrd wrote:Looks like Sloth's r28803 broke GameSimulatorTest.testEquippedAbilities. I've disabled the test for now.
The test fails even before it gets to run the simulation code - fails this check:
assertEquals(1, bear.getAmountOfKeyword("Unblockable"));
It seems Whispersilk Cloak is no longer granting Unblockable to the creature it's equipping? I don't understand r28803, so would appreciate if someone who understand static ability layers could take a look and see if that revision indeed introduced a bug or whether the test is wrong (e.g. I need to check for Unblockable keyword using some other API that c.getAmountOfKeyword()). Thanks!
EDIT: Done!
- Agetian
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Snowstorm » 11 Feb 2015, 04:28
"New" Bug(s): as of r28813
1. Temple Bell only draws cards for the first and second player in 3+ multiplayer, so it basically has the same problem as a lot of bugs I have previously listed.
2. Windbrisk Heights does not allow me to see what I put face-down.
3. When an AI uses Mindclaw Shaman effect it crashes the game.
1. Casting Order of Succession and not owning a creature card crashes the game.
3. Whenever the AI uses cards like Blatant Thievery and any Primordial creature such as Molten Primordial they have a choice to choose more than one card from any player/bot instead of one per player.
4. Hive Mind suffers the same problem in 3+ multiplayer as some of the bugs I previously posted by only giving the first bot and myself a copy. But it also suffers another bug when copying certain cards such as Timetwister (it maybe just Timetwister itself) which causes the game to crash.
5. The Fourth Sphere makes two zombie tokens when chaos is roll instead of just one. Thanks for taking care of one of the bugs on my list yet again Hellfish!
6. When using Ignite the Cloneforge! ability and choosing to make a token of a land you are unable to tap the land token for mana.
1. Temple Bell only draws cards for the first and second player in 3+ multiplayer, so it basically has the same problem as a lot of bugs I have previously listed.
2. Windbrisk Heights does not allow me to see what I put face-down.
3. When an AI uses Mindclaw Shaman effect it crashes the game.
- IllegalArgumentException | Open
1. Casting Order of Succession and not owning a creature card crashes the game.
- NullPointerException | Open
3. Whenever the AI uses cards like Blatant Thievery and any Primordial creature such as Molten Primordial they have a choice to choose more than one card from any player/bot instead of one per player.
4. Hive Mind suffers the same problem in 3+ multiplayer as some of the bugs I previously posted by only giving the first bot and myself a copy. But it also suffers another bug when copying certain cards such as Timetwister (it maybe just Timetwister itself) which causes the game to crash.
- IllegalArgumentException | Open
6. When using Ignite the Cloneforge! ability and choosing to make a token of a land you are unable to tap the land token for mana.
Last edited by Snowstorm on 13 Feb 2015, 10:13, edited 1 time in total.
Re: Bug Reports (snapshot builds)
by Hellfish » 12 Feb 2015, 18:27
Easily fixed, just a mistype. Thanks for reporting!5. The Fourth Sphere makes two zombie tokens when chaos is roll instead of just one.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Bug Reports (snapshot builds)
by Agetian » 14 Feb 2015, 07:30
r28834: Not sure if this is a bug or a feature (need a rule consultation here): I had a Mourning Thrull on the battlefield and my opponent played Humility, which says "all creatures lose all abilities and are 1/1 creatures". However, my Mourning Thrull did not lose its ability ("Whenever it deals damage, you gain that much life" or whatever it's phrased like). My other creature did lose Trample, and Mourning Thrull did lose Flying, so I think keyworded abilities are removed but non-keyworded abilities are not removed. Is this correct or is this a bug? (I think the latter, but please confirm). Also, if it is a bug, then I'm not sure how to fix it, to be honest.
EDIT: I think it's triggered abilities in particular that are not removed by static continuous effects such as Humility.
EDIT 2: Changing the 'layer' parameter in StaticAbilityContinuous.java:588 to ABILITIES1 (from ABILITIES2) seems to make this work correctly (even though the triggers do not visually disappear from the card detail box, they are indeed suppressed, and if Humility is Disenchanted, then the triggered abilities are restored and work correctly), but I'm not sure if this is the correct way to solve it, I'm not very good with the code that deals with layers. Can someone please comment on whether it's possible to fix it this way, and if not, maybe suggest a better solution?
- Agetian
EDIT: I think it's triggered abilities in particular that are not removed by static continuous effects such as Humility.
EDIT 2: Changing the 'layer' parameter in StaticAbilityContinuous.java:588 to ABILITIES1 (from ABILITIES2) seems to make this work correctly (even though the triggers do not visually disappear from the card detail box, they are indeed suppressed, and if Humility is Disenchanted, then the triggered abilities are restored and work correctly), but I'm not sure if this is the correct way to solve it, I'm not very good with the code that deals with layers. Can someone please comment on whether it's possible to fix it this way, and if not, maybe suggest a better solution?
- Agetian
Last edited by Agetian on 14 Feb 2015, 08:08, edited 1 time in total.
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by elcnesh » 14 Feb 2015, 08:02
Could be my fault, related to the continuous effects revamp. I'll investigate.
EDIT: Found it, it's actually only a display problem... Game-technically it seems to work correctly.
EDIT2: Ah actually it's probably related to a single line of code I changed... Let me investigate
EDIT3: Yup that was it, fix committed in r28837. Something with brackets...
EDIT: Found it, it's actually only a display problem... Game-technically it seems to work correctly.
EDIT2: Ah actually it's probably related to a single line of code I changed... Let me investigate
EDIT3: Yup that was it, fix committed in r28837. Something with brackets...
- elcnesh
- Posts: 290
- Joined: 16 May 2014, 15:11
- Location: Netherlands
- Has thanked: 34 times
- Been thanked: 92 times
Who is online
Users browsing this forum: No registered users and 68 guests