Images by Set

[Rob Cashwalker]

All right, that's what I feared. So the solution for the time being would then have to be setting the alternate pics as rancor1.jpg, rancor2.jpg, etc. in the pics\ULG\ folder, and similar for other cards. Thanks for the heads-up, and keep us posted for when that support does come.

Actually, adding numbers to the card names isn't going to make any difference.
Rancor only appeared in one set, ULG, Urza's Legacy, right? Then in the ULG sub-folder there may be a file present, rancor.jpg. If there is, then use it, if not, just use rancor.jpg from the regular pics folder. If that's not present then it will be a black background.

Take Rampant Growth as a different example. It's been printed a lot.

Code: Select all

SetInfo:8ED|Common|http://magiccards.info/scans/en/8e/274.jpg
SetInfo:TMP|Common|http://magiccards.info/scans/en/tp/139.jpg
SetInfo:7ED|Common|http://magiccards.info/scans/en/7e/262.jpg
SetInfo:9ED|Common|http://magiccards.info/scans/en/9e/263.jpg
SetInfo:10E|Common|http://magiccards.info/scans/en/10e/288.jpg
SetInfo:M10|Common|http://magiccards.info/scans/en/m10/201.jpg
SetInfo:6ED|Common|http://magiccards.info/scans/en/6e/246.jpg
SetInfo:MIR|Common|http://magiccards.info/scans/en/mr/133.jpg

Under each sub folder, 6ED, 7ED, 8ED, 9ED, etc, there MAY be a rancor.jpg. If the specified version isn't present, then it still defaults to the pics folder.

One possible option I may throw in, if the card isn't necessarily locked to a particular set, is to then keep trying more and more recent versions until it's found, or it simply defaults.

Another option, will be to download the URL specified, on the fly.

As I said I would look into attempting the alternate set codes as well, I may consider trying to find the file by including "_full", so that the standard HQ MWS distribution can be used more directly. I'm not sure if MWS pics names follow our exact string cleaning rules.

I haven't seen anyone take notice of my change to the CardDetailPanel, where I added a label with the set code in a color scheme according to the rarity.

[friarsol]

I noticed it. It looks nice.

Has Unique ID been replaced by Set ID? If that's the case and the AI targets something of mine, and I have two in play, I don't really know exactly which one is targeted. This only matters if the stack description prints the Unique ID as well (which it should). Without a Unique Identifier how can I really tell the difference between two identical objects.

[Rob Cashwalker]

No, the Unique ID is still Unique. Didn't touch the number, just the label...

[friarsol]

Ah good. It was just missing so I wasn't sure. I hadn't dug very far into it, just mostly curious.

[PhoenixAvenger]

Actually, adding numbers to the card names isn't going to make any difference.

Yeah, sorry, I forgot to add "...and set the PicCount SVar to X in CARDNAME.txt, where X is the highest {n} attached to CARDNAME{n}.jpg plus 1" to that logic. I know the workaround I was going for, anyways. =p

As I said I would look into attempting the alternate set codes as well, I may consider trying to find the file by including "_full", so that the standard HQ MWS distribution can be used more directly. I'm not sure if MWS pics names follow our exact string cleaning rules.

I haven't seen anyone take notice of my change to the CardDetailPanel, where I added a label with the set code in a color scheme according to the rarity.

The MWS-distro images a) have spaces and b) keep characters like apostrophes, dashes, and the like - so they would have to be mass-renamed to fit Forge's data structure, unless someone (zerker, maybe) changes the card/image parser to auto-trim the extraneous characters. I might pester woogerboy to add Forge conversion functionality to his renaming tool, but until then, I would be content with just manually renaming everything.

And the set info bit in there seems... different than I would have imagined it. Looks fairly good, though. Does it support mythic rarity? I haven't seen it in the couple times I've run Forge since the conversion...

[Chris H.]

As I said I would look into attempting the alternate set codes as well, I may consider trying to find the file by including "_full", so that the standard HQ MWS distribution can be used more directly. I'm not sure if MWS pics names follow our exact string cleaning rules.

I haven't seen anyone take notice of my change to the CardDetailPanel, where I added a label with the set code in a color scheme according to the rarity.

`
Yeah, the naming format used by the HQ images here at CCGH are:

Code: Select all

cardName() + ".full.jpg"

`
rather than

Code: Select all

imageName

`

I like the idea of having forge recognize this format as it may make it easier for the users. I could download the HQ archives at night, uncompress and put the pic files into the proper folders. And not having to rename these HQ pics would be an awesome bonus.



Oh, and BTW, I noticed the new Set ID, it is attractive.

[Rob Cashwalker]

In theory, the set boosters will support mythics. When I get to that part.

There have to be some characters that the HQ pics don't use. I don't think a comma can be in a filename, can it?

[Hellfish]

Comma can be in a filename.
\ / : * ? " < > | can't.

Also, seconding Chris here, some way of not having to massrename would be nice for us who've already downloaded most/all HQ cardpics rather than let Forge do it for us. Also for the factor of other program's using other naming schemes. I think using <Full non-cleaned name>.full.jpg is standard for several programs, so at least being able to use that would be nice.

Edited because of font.

[Rob Cashwalker]

How is Boom / Bust and other split cards handled?

[Chris H.]

How is Boom / Bust and other split cards handled?

`
I looked inside of the /res/pics_link/ folder and I found this:

Code: Select all

boombust.jpg   http://[server]/PLC/BoomBust.full.jpg

[Rob Cashwalker]

Pang Tong, "Young Phoenix" -
pang_tong_young_phoenix.jpg http://[server]/P3/Pang%20Tong,%20Young%20Phoenix.full.jpg

So, in the case of " or /, the characters are dropped.

[PhoenixAvenger]

So as to note this for the record in the forum, Rob added MWS-style card name parsing in revision 3863.

So far, in the tests I've run (after syncing to r3865 and extracting pics en masse from my CCGHQ zips), everything seems to be in order except for basic lands and a few assorted cards. I suspect this has something to do with the number right before the .full.jpg not being properly handled (the parser is probably expecting .full{n}.jpg instead of ...{n}.full.jpg); there might be a similar problem with cards from early expansions like Hymn to Tourach, which has four possible images.

[Rob Cashwalker]

Yeah, I wanted to get the code for it pushed up to the SVN, but my wife was pushing me to get to sleep....

Funny enough, I forgot about testing the lands, my test deck consisted of 10 Giant Growth, so I could make sure the various images were found.

I'm not expecting more than one card for any given name, unless the set image isn't found and it defaults back to the original Forge filename format. I guess I could try to work that in..

Edit - Looking at Alpha, there are only 2 land images. Revised only 3. Fifth was the first to have 4 images.

So how should this work? No matter what, the code will always default back to regular images..

[friarsol]

We could use a Regex to look for the files. If we just have two optional characters in the spot where lands and multiple images go, we could just randomnly pick one that fit the regex and go with that. The LQ pics from magiccards.info will never use any other pictures except for the the first one it finds for multi-images.

[Rob Cashwalker]

That's a little bit more complicated than I wanted.... Especially when considering if Forge downloads the pic, there will only be one image per set.

The original Forge format assumed that the first picture had no number, and each additional picture incremented, starting at 1.