AbilityFactory TODO list

[friarsol]

Ok. I'll look at AF_CopySpell today. I'm going to use the Kiki argument: "If I just copy Fork, it can't be worse than we already have!"

Yea I think the important thing with CopySpell is being able to choose new targets. Even if all this is doing is porting hardcoded to an AF it should help in the process of generalizing.

[slapshot5]

I only ask that I be the one to finally and forever delete all WheneverKeyword code.

[slapshot5]

I'm not seeing much of a need for custom parameters for AF_CopySpell, except maybe for targeting based on what it targets, like "Copy target instant or sorcery spell that targets you.", but I don't think that would be handled in AF_CopySpell.

Oh, the one I did think of would be for Fork making the copied spell red. But the infrastructure doesn't exist for changing color of SAs. Not sure if the card code can just be copied over to SpellAbility.java and basically work or not.

Anyone know anything differently?

-slapshot5

[slapshot5]

I checked in a first pass of AF_CopySpell. There is no AI. Copying spells without targets will give an exception (Fork/Twincast does the same thing now). Check out Sigil Tracer as a checked-in example.

-slapshot5

[Hellfish]

Sweet as. Added Echo Mage quite effortlessly
With some tweaks to Triggered-variables I also managed to add an incorrect, but functioning non-WheneverKeyword Mirari.There are some problems with it, though:
*SpellCast triggers run on SAs being added to the stack, but isn't put on the stack themselves until priority is passed,when the top SA on the stack resolves. This is incorrect.
*Mirari triggers again for copies it made itself, which is incorrect.Technically, spell copies aren't *cast*, they're just put on stack.Either CopySpell should use another way of adding SAs to the stack or the SpellAbilityCast running should be moved.

[friarsol]

Does SpellCast check for isCopiedSpell() and is AF_CopySpell properly setting it?

[friarsol]

I converted Mishra over to AF, although there's definitely some improvements still possible. On the AI side, Mishra should grab a card from the Library first, then the Graveyard, then Hand. For the Human, it should be more clear where each card is currently located so the Player can make the "right" decision. Our Option boxes are pretty inflexible, so I'm not sure how easy to do that. But it's probably easier to tweak that away,

[Hellfish]

Does SpellCast check for isCopiedSpell() and is AF_CopySpell properly setting it?

That was easy. I was a bit worried since isCopiedSpell is per Card and not per SpellAbility, but it worked.

[slapshot5]

Does SpellCast check for isCopiedSpell() and is AF_CopySpell properly setting it?

AF_CopySpell just calls CardFactory.copySpellontoStack(Card, Card, boolean) which calls copySpellontoStack(Card, Card, SpellAbility, boolean), which sets c.setCopiedSpell(true);

-slapshot5

[friarsol]

Does SpellCast check for isCopiedSpell() and is AF_CopySpell properly setting it?

AF_CopySpell just calls CardFactory.copySpellontoStack(Card, Card, boolean) which calls copySpellontoStack(Card, Card, SpellAbility, boolean), which sets c.setCopiedSpell(true);

Yep. It sounds like Hellfish was able to fix the issue by adding a check for the Copied Spell in the same location.

[friarsol]

I only ask that I be the one to finally and forever delete all WheneverKeyword code.

Slap, where'd you go? I think WheneverKeyword is ready to be axed (along with a cascading number of helper functions)

[slapshot5]

I only ask that I be the one to finally and forever delete all WheneverKeyword code.

Slap, where'd you go? I think WheneverKeyword is ready to be axed (along with a cascading number of helper functions)

Consider it done.

-slapshot5

[Chris H.]

I also want to change over the various ".getController().equals(AllZone.ComputerPlayer)" and ".getController().equals(AllZone.HumanPlayer)" to "getController().isComputer()" and "getController().isHuman()".

`
I just searched the project and discovered that all but one of the code simplifications that I was planning to make have now been taken care of, wow you have been busy.

Thank you Slapshot.

[slapshot5]

I just searched the project and discovered that all but one of the code simplifications that I was planning to make have now been taken care of, wow you have been busy.

Thank you Slapshot.

Yeah, well, I was digging in stuff anyway, and Find/Replace is your friend.

-slapshot5

[Sloth]

I've added AbilityFactory_PreventDamage.java. A wiki entry will follow.

Example:

| Open

Name:Anoint
ManaCost:W
Types:Instant
Text:no text
A:SP$ PreventDamage | Cost$ W | ValidTgts$ Creature | Amount$ 3 | TgtPrompt$ Select target creature | SpellDescription$ Prevent the next 3 damage that would be dealt to target creature this turn.
SVar:Buyback:3
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/anoint.jpg
End