Incorrect Scripts

[ZzzzSleep]

. Olivia Voldaren has an incorrect spell description. It says "Gain control of target creature" instead of "Gain control of target Vampire".

From http://svn.slightlymagic.net/websvn/fil ... ldaren.txt
A:AB$ GainControl | Cost$ 3 B B | ValidTgts$ Creature.Vampire | TgtPrompt$ Select target vampire | LoseControl$ LeavesPlay,LoseControl | SpellDescription$ Gain control of target creature for as long as you control CARDNAME.

[jeffwadsworth]

. Olivia Voldaren has an incorrect spell description. It says "Gain control of target creature" instead of "Gain control of target Vampire".

From http://svn.slightlymagic.net/websvn/fil ... ldaren.txt
A:AB$ GainControl | Cost$ 3 B B | ValidTgts$ Creature.Vampire | TgtPrompt$ Select target vampire | LoseControl$ LeavesPlay,LoseControl | SpellDescription$ Gain control of target creature for as long as you control CARDNAME.

Thanks.

[jeffwadsworth]

For some bizarre reason, the boolean remSacrificed inside AB Sacrifice would not accept the scripted "RememberSacrificed$ True". Perhaps someone can look at it. I forced it to true for the time being.

[moomarc]

Jeff, I think your Curse of the Cabal needs to have a check on the trigger to make sure it has at least 1 time counter otherwise I assume it will trigger whenever its in exile, rather than just when its suspended.

EDIT: Nevermind. I'm over my temporary laziness and fixed it myself.

[Sloth]

For some bizarre reason, the boolean remSacrificed inside AB Sacrifice would not accept the scripted "RememberSacrificed$ True". Perhaps someone can look at it. I forced it to true for the time being.

I think your changes to sacrificeHuman fixed the remembering (the previous state looks messed up to me), i can't imagine "final boolean remSacrificed = params.containsKey("RememberSacrificed");" not working (and forcing it can have side effects on other scripts).

[jeffwadsworth]

For some bizarre reason, the boolean remSacrificed inside AB Sacrifice would not accept the scripted "RememberSacrificed$ True". Perhaps someone can look at it. I forced it to true for the time being.

I think your changes to sacrificeHuman fixed the remembering (the previous state looks messed up to me), i can't imagine "final boolean remSacrificed = params.containsKey("RememberSacrificed");" not working (and forcing it can have side effects on other scripts).

Agreed, but it wouldn't work. Can someone test that? Quite simple of course.

[Sloth]

For some bizarre reason, the boolean remSacrificed inside AB Sacrifice would not accept the scripted "RememberSacrificed$ True". Perhaps someone can look at it. I forced it to true for the time being.

I think your changes to sacrificeHuman fixed the remembering (the previous state looks messed up to me), i can't imagine "final boolean remSacrificed = params.containsKey("RememberSacrificed");" not working (and forcing it can have side effects on other scripts).

Agreed, but it wouldn't work. Can someone test that? Quite simple of course.

It works for me. Both if suspended by the AI or suspended by human. Note that the AI will refuse to scarifice anything no matter who controls it.

[Sloth]

The script of Blood Feud has not improved since i posted about it: It will now always throw an error when cast. And even if fixed it will not work correctly targeting two creatures with infect.

[jeffwadsworth]

The script of Blood Feud has not improved since i posted about it: It will now always throw an error when cast. And even if fixed it will not work correctly targeting two creatures with infect.

I did not see anything written about Blood Feud. I will delete it.

[Sloth]

The script of Blood Feud has not improved since i posted about it: It will now always throw an error when cast. And even if fixed it will not work correctly targeting two creatures with infect.

I did not see anything written about Blood Feud. I will delete it.

Sorry Jeff, that i'm nagging so much these days. I know that the amount of work per card is rising as well as the chance to eventually fail. I really appreciate every card that gets added (even the obscure ones). So keep up the good scripting and coding work.

[jeffwadsworth]

The script of Blood Feud has not improved since i posted about it: It will now always throw an error when cast. And even if fixed it will not work correctly targeting two creatures with infect.

I did not see anything written about Blood Feud. I will delete it.

Sorry Jeff, that i'm nagging so much these days. I know that the amount of work per card is rising as well as the chance to eventually fail. I really appreciate every card that gets added (even the obscure ones). So keep up the good scripting and coding work.

You do realize I was just kidding around. If anything is wrong, by all means, let me have it with both barrels. When I scripted that card, it seemed to work. Completely missed the Infect aspect. As for the obscure cards, I played with all those back in the day.

[moomarc]

The script for Fork doesn't make the copy red. We'll need to either make an extra optional param in CopySpell that changes the color, or we need to add CopiedSA to the Defined list so that a pump can add a hidden "CARDNAME is red". I've had a look at the code but its beyond my paltry abilities (although I'm sure its horrible easy).

[jeffwadsworth]

The script for Fork doesn't make the copy red. We'll need to either make an extra optional param in CopySpell that changes the color, or we need to add CopiedSA to the Defined list so that a pump can add a hidden "CARDNAME is red". I've had a look at the code but its beyond my paltry abilities (although I'm sure its horrible easy).

The script was done because the original code didn't change the new copied source to red either.

[moomarc]

Understood. I just came across it and thought I'd post a quick note about it before I forget (I have a tendency to do that)

[squee1968]

Not sure if this should be posted here or in Bug Reports, but the script for Profane Prayers is incorrect. The current script does not include a subability for the life gain portion of the card. I've included a corrected script.

Code: Select all

Name:Profane Prayers
ManaCost:2 B B
Types:Sorcery
Text:no text
A:SP$ DealDamage | Cost$ 2 B B | Tgt$ TgtCP | NumDmg$ X |
SubAbility$ DBGainLife | SpellDescription$ Profane Prayers
deals X damage to target creature or player and you gain X
life, where X is the number of Clerics on the battlefield.
SVar:DBGainLife:DB$GainLife | Defined$ You | LifeAmount$ X
SVar:X:Count$TypeOnBattlefield.Cleric
SVar:RemRandomDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general
/profane_prayers.jpg
SetInfo:ONS|Common|http://magiccards.info/scans/en/on/162.jpg
Oracle:Profane Prayers deals X damage to target creature or
player and you gain X life, where X is the number of Clerics on
the battlefield.
End