Card Contributions

[friarsol]

I was just debugging some multi-targeting code, when I came across the hard-coded Counterbalance. What would we need to convert this to Trigger+AF_Counter?

Edit: And similarly, Chalice of the Void, Dovescape, and a few others that are similarly coded.

[jeffwadsworth]

I was just debugging some multi-targeting code, when I came across the hard-coded Counterbalance. What would we need to convert this to Trigger+AF_Counter?

Edit: And similarly, Chalice of the Void, Dovescape, and a few others that are similarly coded.

For Counterbalance, you would need to remember the Dig card that was revealed.

Something like this:

Code: Select all

Name:Counterbalance
ManaCost:U U
Types:Enchantment
Text:no text
T:Mode$ SpellCast | ValidCard$ Card | ValidActivatingPlayer$ Opponent | OptionalDecider$ You | TriggerZones$ Battlefield | Execute$ TrigReveal | TriggerDescription$ Whenever an opponent casts a spell, you may reveal the top card of your library. If you do, counter that spell if it has the same converted mana cost as the revealed card.
SVar:TrigReveal:AB$Dig | Cost$ 0 | DigNum$ 1 | Reveal$ True | RememberDigged$ True | ForgetOtherDigged$ True | SubAbility$ SVar=DBCounter
SVar:DBCounter:DB$Counter | Defined$ TriggeredSpellAbility | ConditionDefined$ Triggered | ConditionPresent$ Card.cmcEQX | ConditionCompare$ EQ1
SVar:X:Remembered$CardManaCost
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/counterbalance.jpg
End

[Sloth]

I was just debugging some multi-targeting code, when I came across the hard-coded Counterbalance. What would we need to convert this to Trigger+AF_Counter?

Edit: And similarly, Chalice of the Void, Dovescape, and a few others that are similarly coded.

The difficulties won't lie in AF Countermagic. Slapshot made cards like Nether Void possible. Counterbalance can be easily converted by adding something to xcount (like topOfLibraryCMC).

[slapshot5]

. Dovescape should be ok to convert. I'll check it in soon.

-slapshot5

[jeffwadsworth]

I was just debugging some multi-targeting code, when I came across the hard-coded Counterbalance. What would we need to convert this to Trigger+AF_Counter?

Edit: And similarly, Chalice of the Void, Dovescape, and a few others that are similarly coded.

The difficulties won't lie in AF Countermagic. Slapshot made cards like Nether Void possible. Counterbalance can be easily converted by adding something to xcount (like topOfLibraryCMC).

Eh, that is too easy. Besides, I wanted to spread the Remembered love.

Counterbalance...jeez. The SubAbility fires even if you choose No on the option to reveal the card. Sloth's idea is added if someone wants to give it a go.

Code: Select all

Name:Counterbalance
ManaCost:U U
Types:Enchantment
Text:no text
T:Mode$ SpellCast | ValidCard$ Card | ValidActivatingPlayer$ Opponent | OptionalDecider$ You | TriggerZones$ Battlefield | Execute$ TrigReveal | TriggerDescription$ Whenever an opponent casts a spell, you may reveal the top card of your library. If you do, counter that spell if it has the same converted mana cost as the revealed card.
SVar:TrigReveal:AB$Dig | Cost$ 0 | DigNum$ 1 | Reveal$ True | DestinationZone$ Library | LibraryPosition$ 0 | SubAbility$ SVar=DBCounter
SVar:DBCounter:DB$Counter | Defined$ TriggeredSpellAbility | IsPresent$ TriggeredSpellAbility.cmcEQX
SVar:X:Count$TopOfLibraryCMC
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/counterbalance.jpg
End

As for Chalice of the Void:

Code: Select all

Name:Chalice of the Void
ManaCost:X X
Types:Artifact
Text:no text
K:etbCounter:CHARGE:X
T:Mode$ SpellCast | ValidCard$ Card.cmcEQY | ValidActivatingPlayer$ Each | TriggerZones$ Battlefield | Execute$ TrigCounter | TriggerDescription$ Whenever a player casts a spell with converted mana cost equal to the number of charge counters on CARDNAME, counter that spell.
SVar:TrigCounter:AB$Counter | Cost$ 0 | Defined$ TriggeredSpellAbility
SVar:X:Count$xPaid
SVar:Y:Count$CardCounters.CHARGE
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/chalice_of_the_void.jpg
End

ValidCard$ doesn't handle Card.cmcEQY very well.

[Starcrash]

Name:Deathbringer Liege
ManaCost:2 WB WB WB
Types:Creature Horror
Text:no text
PT:3/4
K:stPumpAll:Creature.White+Other+YouCtrl:1/1:No Condition:Other white creatures you control get +1/+1.
K:stPumpAll:Creature.Black+Other+YouCtrl:1/1:No Condition:Other black creatures you control get +1/+1.
T:Mode$ SpellCast | ValidCard$ Card.White+YouCtrl | TriggerZones$ Battlefield | Execute$ TrigTap | OptionalDecider$ You | TriggerDescription$ Whenever you cast a white spell, you may tap target creature.
T:Mode$ SpellCast | ValidCard$ Card.Black+YouCtrl | TriggerZones$ Battlefield | Execute$ TrigDestroy | OptionalDecider$ You | TriggerDescription$ Whenever you cast a black spell, you may destroy target creature if it's tapped.
SVar:TrigTap:AB$ Tap | Cost$ 0 | ValidTgts$ Creature | TgtPrompt$ Select target creature to tap
SVar:TrigDestroy:AB$ Destroy | Cost$ 0 | ValidTgts$ Creature | TgtPrompt$ Select target creature to destroy | ConditionDefined$ Targeted | ConditionPresent$ Creature.tapped
SVar:BuffedBy:Spell.White,Spell.Black
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/deathbringer_liege.jpg
SetInfo:EVE|Rare|http://magiccards.info/scans/en/eve/85.jpg
End

Despite working properly in other respects, it includes the phrase "(Targeting ERROR)" after each of the listed trigger descriptions upon playing a spell. If anyone understands why this is showing up, or better yet how to fix it, I'd appreciate the input.

[Sloth]

As for Chalice of the Void:

Code: Select all

Name:Chalice of the Void
ManaCost:X X
Types:Artifact
Text:no text
K:etbCounter:CHARGE:X
T:Mode$ SpellCast | ValidCard$ Card.cmcEQY | ValidActivatingPlayer$ Each | TriggerZones$ Battlefield | Execute$ TrigCounter | TriggerDescription$ Whenever a player casts a spell with converted mana cost equal to the number of charge counters on CARDNAME, counter that spell.
SVar:TrigCounter:AB$Counter | Cost$ 0 | Defined$ TriggeredSpellAbility
SVar:X:Count$xPaid
SVar:Y:Count$CardCounters.CHARGE
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/chalice_of_the_void.jpg
End

ValidCard$ doesn't handle Card.cmcEQY very well.

This should work now.

Eh, that is too easy. Besides, I wanted to spread the Remembered love.

Counterbalance...jeez. The SubAbility fires even if you choose No on the option to reveal the card. Sloth's idea is added if someone wants to give it a go.

Code: Select all

Name:Counterbalance
ManaCost:U U
Types:Enchantment
Text:no text
T:Mode$ SpellCast | ValidCard$ Card | ValidActivatingPlayer$ Opponent | OptionalDecider$ You | TriggerZones$ Battlefield | Execute$ TrigReveal | TriggerDescription$ Whenever an opponent casts a spell, you may reveal the top card of your library. If you do, counter that spell if it has the same converted mana cost as the revealed card.
SVar:TrigReveal:AB$Dig | Cost$ 0 | DigNum$ 1 | Reveal$ True | DestinationZone$ Library | LibraryPosition$ 0 | SubAbility$ SVar=DBCounter
SVar:DBCounter:DB$Counter | Defined$ TriggeredSpellAbility | IsPresent$ TriggeredSpellAbility.cmcEQX
SVar:X:Count$TopOfLibraryCMC
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/counterbalance.jpg
End

I will try to get Counterbalance to work.

[jeffwadsworth]

Name:Deathbringer Liege
ManaCost:2 WB WB WB
Types:Creature Horror
Text:no text
PT:3/4
K:stPumpAll:Creature.White+Other+YouCtrl:1/1:No Condition:Other white creatures you control get +1/+1.
K:stPumpAll:Creature.Black+Other+YouCtrl:1/1:No Condition:Other black creatures you control get +1/+1.
T:Mode$ SpellCast | ValidCard$ Card.White+YouCtrl | TriggerZones$ Battlefield | Execute$ TrigTap | OptionalDecider$ You | TriggerDescription$ Whenever you cast a white spell, you may tap target creature.
T:Mode$ SpellCast | ValidCard$ Card.Black+YouCtrl | TriggerZones$ Battlefield | Execute$ TrigDestroy | OptionalDecider$ You | TriggerDescription$ Whenever you cast a black spell, you may destroy target creature if it's tapped.
SVar:TrigTap:AB$ Tap | Cost$ 0 | ValidTgts$ Creature | TgtPrompt$ Select target creature to tap
SVar:TrigDestroy:AB$ Destroy | Cost$ 0 | ValidTgts$ Creature | TgtPrompt$ Select target creature to destroy | ConditionDefined$ Targeted | ConditionPresent$ Creature.tapped
SVar:BuffedBy:Spell.White,Spell.Black
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/deathbringer_liege.jpg
SetInfo:EVE|Rare|http://magiccards.info/scans/en/eve/85.jpg
End

Despite working properly in other respects, it includes the phrase "(Targeting ERROR)" after each of the listed trigger descriptions upon playing a spell. If anyone understands why this is showing up, or better yet how to fix it, I'd appreciate the input.

I believe you need "ConditionCompare$ EQ1" to finish up the check. No idea if this helps with the "Targeting ERROR" you are seeing.

[jeffwadsworth]

This should work now.

Thanks Sloth. After more testing, the value for Y always remains 0. So I will check the issue in the line SVar:Y:Count$CardCounters.CHARGE

I believe the issue is possibly related to the object issue some others have been noticing. The card has the correct counter number after it is set via etbCounter. But, even if you set it to another value and increment it every turn, 2 different int values will exist (0 in Card and whatever int is set up within CardFactoryUtil.

[Starcrash]

Name:Canker Abomination
ManaCost:2 BG BG
Types:Creature Treefolk Horror
Text:As CARDNAME enters the battlefield, choose an opponent. CARDNAME enters the battlefield with a -1/-1 counter on it for each creature that player controls.
PT:6/6
K:etbCounter:M1M1:X
SVar:X:Count$Valid Creature.YouDontCtrl
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/canker_abomination.jpg
SetInfo:EVE|Uncommon|http://magiccards.info/scans/en/eve/115.jpg
End

The description on the card is horrible, as the Keyword description is automatic, redundant, and uninformative (CARDNAME gets X -1/-1 counters when it comes into play). But functionally the card works like it's supposed to.

[Sloth]

Name:Canker Abomination
ManaCost:2 BG BG
Types:Creature Treefolk Horror
Text:As CARDNAME enters the battlefield, choose an opponent. CARDNAME enters the battlefield with a -1/-1 counter on it for each creature that player controls.
PT:6/6
K:etbCounter:M1M1:X
SVar:X:Count$Valid Creature.YouDontCtrl
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/canker_abomination.jpg
SetInfo:EVE|Uncommon|http://magiccards.info/scans/en/eve/115.jpg
End

The description on the card is horrible, as the Keyword description is automatic, redundant, and uninformative (CARDNAME gets X -1/-1 counters when it comes into play). But functionally the card works like it's supposed to.

I've added your Liege (Target ERROR inclusive) and Canker Abomination (etbCounter does allow an optional description - just look at my submitted version). Thanks Starcrash.

[Starcrash]

Name:Genesis Chamber
ManaCost:2
Types:Artifact
Text:no text
T:Mode$ ChangesZone | ValidPlayer$ Player | Origin$ Any | Destination$ Battlefield | ValidCard$ Creature.nonToken | TriggerZones$ Battlefield | Execute$ TrigToken | IsPresent$ Card.Self+untapped | TriggerDescription$ Whenever a nontoken creature enters the battlefield, if CARDNAME is untapped, that creature's controller puts a 1/1 Myr artifact creature token onto the battlefield.
SVar:TrigToken:AB$ Token | Cost$ 0 | TokenAmount$ 1 | TokenOwner$ TriggeredCardController | TokenName$ Myr | TokenTypes$ Artifact,Creature,Myr | TokenColors$ Colorless | TokenPower$ 1 | TokenToughness$ 1 | SpellDescription$ Put a 1/1 Myr artifact creature token onto the battlefield.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/genesis_chamber.jpg
SetInfo:DST|Rare|http://magiccards.info/scans/en/ds/122.jpg
End

Name:Spawning Pit
ManaCost:2
Types:Artifact
Text:no text
A:AB$ PutCounter | Cost$ Sac<1/Creature> | Defined$ Self | CounterType$ CHARGE | CounterNum$ 1 | SpellDescription$ Put a charge counter on CARDNAME.
A:AB$ Token | Cost$ 1 SubCounter<2/CHARGE> | TokenAmount$ 1 | TokenController$ You | TokenName$ Spawn | TokenTypes$ Artifact,Creature,Spawn | TokenColors$ Colorless | TokenPower$ 2 | TokenToughness$ 2 | SpellDescription$ Put a 2/2 Spawn artifact creature token onto the battlefield.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/spawning_pit.jpg
SetInfo:DST|Rare|http://magiccards.info/scans/en/ds/141.jpg
End

[jeffwadsworth]

Eh, that is too easy. Besides, I wanted to spread the Remembered love.

Counterbalance...jeez. The SubAbility fires even if you choose No on the option to reveal the card. Sloth's idea is added if someone wants to give it a go.

Code: Select all

Name:Counterbalance
ManaCost:U U
Types:Enchantment
Text:no text
T:Mode$ SpellCast | ValidCard$ Card | ValidActivatingPlayer$ Opponent | OptionalDecider$ You | TriggerZones$ Battlefield | Execute$ TrigReveal | TriggerDescription$ Whenever an opponent casts a spell, you may reveal the top card of your library. If you do, counter that spell if it has the same converted mana cost as the revealed card.
SVar:TrigReveal:AB$Dig | Cost$ 0 | DigNum$ 1 | Reveal$ True | DestinationZone$ Library | LibraryPosition$ 0 | SubAbility$ SVar=DBCounter
SVar:DBCounter:DB$Counter | Defined$ TriggeredSpellAbility | IsPresent$ TriggeredSpellAbility.cmcEQX
SVar:X:Count$TopOfLibraryCMC
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/counterbalance.jpg
End

I will try to get Counterbalance to work.

Well, one reason why Counterbalance didn't work for me was my src installation got screwed up. Thanks.

[Starcrash]

Name:Arcbound Fiend
ManaCost:6
Types:Artifact Creature Horror
Text:no text
PT:0/0
K:Fear
K:Modular 3
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | Execute$ TrigRemoveCounter | TriggerZones$ Battlefield | OptionalDecider$ You | TriggerDescription$ At the beginning of your upkeep, you may move a +1/+1 counter from target creature onto Arcbound Fiend.
SVar:TrigRemoveCounter:AB$ RemoveCounter | Cost$ 0 | ValidTgts$ Creature.Other+YouCtrl | CounterType$ P1P1 | CounterNum$ 1 | SubAbility$ SVar=TrigAddCounter | TgtPrompt$ Select target creature you control with a +1/+1 counter on it
SVar:TrigAddCounter:DB$ PutCounter | Cost$ 0 | Defined$ Self | CounterType$ P1P1 | CounterNum$ 1
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/arcbound_fiend.jpg
SetInfo:DST|Uncommon|http://magiccards.info/scans/en/ds/96.jpg
End

[friarsol]

Starcrash, two things about Arcbound Fiend. First, it looks like the creature you are stealing counters from doesn't have to be a Creature you Control (even though it feels like it should be). The other is this:
"The creature that's targeted by Arcbound Fiend's middle ability doesn't have to have any +1/+1 counters on it. If it doesn't have a counter on it when the ability resolves, nothing happens." Where your script will try add a Counter whether or not the targeted creature has a Counter. We probably need a AF_MoveCounter for this to work properly.